Skip to content

✨ feat(agent-explorer): support multi-select delete in document tree#15125

Merged
Innei merged 6 commits into
canaryfrom
feat/agent-doc-tree-multi-delete
May 23, 2026
Merged

✨ feat(agent-explorer): support multi-select delete in document tree#15125
Innei merged 6 commits into
canaryfrom
feat/agent-doc-tree-multi-delete

Conversation

@Innei

@Innei Innei commented May 22, 2026

Copy link
Copy Markdown
Member

πŸ’» Change Type

  • ✨ feat
  • πŸ› fix
  • ♻️ refactor
  • πŸ’„ style
  • πŸ‘· build
  • ⚑️ perf
  • βœ… test
  • πŸ“ docs
  • πŸ”¨ chore

πŸ”€ Description of Change

Three bundled improvements around the agent workspace:

  1. Multi-select delete in document tree β€” right-clicking a row that is part of an active multi-selection now acts on the whole selection (typical file-tree UX). When a selected folder is an ancestor of another selection the descendant is skipped, since the folder's recursive delete already covers it. deleteDocument(id) is replaced by deleteDocuments(ids[]) with per-target error aggregation.

  2. SkillsList chevron alignment β€” atomic skills (no embedded files) previously rendered without a chevron slot, causing the icon column to misalign with bundled skills. A new reserveChevronSlot prop lets the list reserve the slot when at least one row in the group has files.

  3. EMPTY_ARRAY centralization β€” added packages/const/src/empty.ts exporting a frozen never[] so x ?? EMPTY_ARRAY preserves the element type of x (avoids the unknown[]-widening problem). Wired into @lobechat/const. Migrated the local EMPTY constant in SkillsList; broader migration is intentionally deferred (most ?? [] sites are transient and would not benefit, while mutation of a frozen shared array would surface late bugs).

i18n keys added: workingPanel.resources.deleteTitleMulti, workingPanel.resources.tree.deleteSelected (EN + zh-CN).

πŸ§ͺ How to Test

  • Tested locally
  • Added/updated tests
  • No tests needed
  1. Open an agent's documents panel.
  2. Cmd/Ctrl-click multiple rows in the tree.
  3. Right-click any row in the selection β†’ confirm the menu shows "Delete selected (N)" and that deleting cascades through descendants without double-deletes.
  4. Right-click outside the selection β†’ confirm it acts on only that row.
  5. Inspect SkillsList: a group containing both atomic and bundled skills should align icons in the same column.

πŸ“ Additional Information

EMPTY_ARRAY is typed as never[] and Object.freeze-d. Reason: never[] is assignable to any array type, so x ?? EMPTY_ARRAY does not widen x's element type. Freezing prevents accidental mutation of the shared reference at runtime.

- Right-click on a multi-selected row deletes the whole selection; dedupe descendants when an ancestor folder is also selected
- Reserve chevron slot in SkillsList rows so atomic and bundled skills align
- Centralize EMPTY_ARRAY (typed `never[]`, frozen) in @lobechat/const
@vercel

vercel Bot commented May 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
lobehub Ready Ready Preview, Comment May 23, 2026 8:17am

Request Review

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @Innei, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. feature:agent-builder Agent builder πŸ’„ Design Design and style issues labels May 22, 2026
@codecov

codecov Bot commented May 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 64.86486% with 39 lines in your changes missing coverage. Please review.
βœ… Project coverage is 70.85%. Comparing base (8cd03c8) to head (adc3694).
⚠️ Report is 6 commits behind head on canary.

Additional details and impacted files
@@             Coverage Diff             @@
##           canary   #15125       +/-   ##
===========================================
- Coverage   82.45%   70.85%   -11.61%     
===========================================
  Files         310     3138     +2828     
  Lines       23140   312454   +289314     
  Branches     4500    28303    +23803     
===========================================
+ Hits        19080   221385   +202305     
- Misses       3955    90904    +86949     
- Partials      105      165       +60     
Flag Coverage Ξ”
app 61.67% <64.86%> (?)
database 92.17% <ΓΈ> (?)
packages/agent-runtime 80.48% <ΓΈ> (?)
packages/builtin-tool-lobe-agent 19.87% <ΓΈ> (?)
packages/context-engine 84.13% <ΓΈ> (?)
packages/conversation-flow 91.28% <ΓΈ> (?)
packages/file-loaders 87.89% <ΓΈ> (ΓΈ)
packages/memory-user-memory 75.01% <ΓΈ> (?)
packages/model-bank 99.99% <ΓΈ> (?)
packages/model-runtime 83.75% <ΓΈ> (ΓΈ)
packages/prompts 71.60% <ΓΈ> (ΓΈ)
packages/python-interpreter 92.90% <ΓΈ> (?)
packages/ssrf-safe-fetch 0.00% <ΓΈ> (?)
packages/types 35.02% <ΓΈ> (?)
packages/utils 88.20% <ΓΈ> (?)
packages/web-crawler 88.08% <ΓΈ> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Ξ”
Store 67.94% <ΓΈ> (βˆ…)
Services 54.68% <100.00%> (βˆ…)
Server 72.09% <ΓΈ> (βˆ…)
Libs 56.42% <ΓΈ> (βˆ…)
Utils 85.96% <ΓΈ> (-7.51%) ⬇️
πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Innei Innei force-pushed the feat/agent-doc-tree-multi-delete branch from 1e64d70 to adc3694 Compare May 23, 2026 08:05
@Innei Innei merged commit f685d5c into canary May 23, 2026
35 checks passed
@Innei Innei deleted the feat/agent-doc-tree-multi-delete branch May 23, 2026 08:44
hardy-one pushed a commit to hardy-one/lobehub that referenced this pull request May 27, 2026
…obehub#15125)

* ✨ feat(agent-explorer): support multi-select delete in document tree

- Right-click on a multi-selected row deletes the whole selection; dedupe descendants when an ancestor folder is also selected
- Reserve chevron slot in SkillsList rows so atomic and bundled skills align
- Centralize EMPTY_ARRAY (typed `never[]`, frozen) in @lobechat/const

* ♻️ refactor: migrate delete confirm dialog from antd modal to confirmModal

* βœ… test: stabilize bun vitest environment

* πŸ”§ ci: avoid authenticated checkout for PR tests
arvinxx added a commit that referenced this pull request May 29, 2026
# πŸš€ LobeHub Release (20260528)

**Release Date:** May 28, 2026  
**Since v2.2.0:** 220 merged PRs Β· 15 contributors

> This cycle brings heterogeneous "platform agents" you can dispatch to
local or remote devices, a rebuilt onboarding flow, document-centric
chat, and a unified model-runtime error model β€” with new DeepSeek V4 and
Gemini 3.5 Flash support along the way.

---

## ✨ Highlights

- **More Hetero Agents (OpenClaw / Hermes)** β€” Create heterogeneous
agents and dispatch them to local or remote devices through the device
gateway, with an execution-target switcher in the composer and
persistent CLI sessions. (#15065, #15179, #15022)
- **iMessage on Desktop** β€” New iMessage setup and bridge on desktop,
plus bot attachments across every platform. (#15228, #15227, #15029)
- **Skills in the Composer** β€” Drag skill chips into chat, trigger
installed skills from the slash menu mid-line, and surface project-level
skills in the homogeneous agent runtime. (#15095, #15061, #15110)
- **New Models** β€” DeepSeek V4 Flash/Pro and Gemini 3.5 Flash across
providers, with thinking params for structured output and chat cost
estimates. (#15031, #15001, #15051, #14876)
- **Agent Runtime Observability** β€” OpenTelemetry GenAI semantic
conventions plus per-call generation tracing. (#15123, #15124)

---

## πŸ€– Agents & Heterogeneous Runtime

- **Platform agent creation** β€” OpenClaw/Hermes creation UI, device
guard, and remote dispatch backend. (#15065)
- **Execution-target switcher** β€” Pick local vs remote execution
directly in the composer; device-selection UX with actionable guidance.
(#15179, #15111)
- **CLI hetero dispatch** β€” OpenClaw/Hermes dispatch with persistent
sessions and a notify protocol. (#15022)
- **Gateway snapshot as source of truth** β€” Consume the gateway
`uiMessages` snapshot at step boundaries to keep chat state consistent.
(#15153, #15152)
- **Client sub-agent as a normal tool call** β€” Simplifies the sub-agent
execution path. (#15281)
- **Hermes agent chain** β€” Implements the Hermes agent chain logic.
(#15189)
- **Device registry** β€” TRPC endpoints to register, list, update, and
remove devices. (#15299)
- **Desktop device routing** β€” Route gateway agent runs through `lh
hetero exec`; restore `userId` in gateway dispatch and gate local-system
by execution target. (#15132, #15232)
- **Agent signals** β€” Anchor agent-signal receipts to messages and
isolate memory-agent messages into a child thread. (#14969, #14921)

---

## πŸš€ Onboarding

- **Simplified first screen** β€” Defer topic creation to first send.
(#15090)
- **Market Agent Picker** β€” Added as a classic onboarding step, with
template prefetch. (#14980, #15041)
- **Welcome guidance** β€” Show agent welcome guidance on first run.
(#15098)
- **Mobile** β€” Adapt agent onboarding UI and restore Classic-step
padding on mobile. (#15019, #15032)
- **Discovery** β€” Streamline discovery to a single profession question.
(#14987)
- **Analytics** β€” Track onboarding step events and create-agent modal
source. (#15133, #15028)

---

## πŸ“„ Documents, Pages & Knowledge

- **Thread chat in preview** β€” Embed thread chat in the document preview
portal. (#15216)
- **Non-markdown rendering** β€” Render non-markdown docs as a read-only
highlight. (#15272)
- **Multi-select** β€” Multi-select delete in the document tree. (#15125)
- **Page-agent streaming** β€” Preview `initPage` streaming arguments.
(#15039)
- **Per-agent topics** β€” Per-agent topic management page. (#15207)
- **Server-side category** β€” Derive document category server-side and
drop frontend predicates. (#15076)

---

## 🧩 Skills & Tools

- **Drag skill chips** β€” Drag skills into chat input and register
agent-document skills. (#15095)
- **Slash menu** β€” Installed skills appear in the slash menu with a
mid-line trigger. (#15061)
- **Project skills** β€” Recognize project-level skills in the homogeneous
agent runtime and surface them regardless of active device. (#15110,
#15177)
- **VFS archiving** β€” Archive oversized tool results to VFS instead of
truncating. (#15074)
- **@localfile mentions** β€” Drag folders into chat input as `@localFile`
mentions on desktop. (#15071)

---

## 🧠 Model Runtime & Providers

- **Error spec registry** β€” Unify error codes into a spec + pattern
registry, split `ProviderBizError` into finer codes, classify Cloud-only
codes via a tier digit, and add `DatabasePersistError`. (#15262, #15286,
#15278, #15279)
- **New models** β€” DeepSeek V4 Flash/Pro (opencode-go) and Gemini 3.5
Flash; DeepSeek V4 Pro on SiliconCloud. (#15031, #15001, #15017, #15267)
- **Structured output** β€” Thinking params for structured output, Bedrock
structured generation, and DeepSeek `generateObject` tool choice.
(#15051, #15174, #15054)
- **Cost** β€” Chat cost estimate support; preserve usage cost in custom
streams. (#14876, #15218)

---

## πŸ’¬ Chat & User Experience

- **Follow-up chips** β€” Extend follow-up chip suggestions to general
chat with scene-specific model config. (#15101, #14797)
- **Input drafts** β€” Persist unsent input drafts across tab switches and
prevent repeated draft restore. (#14992, #15024)
- **Command menu** β€” Order topic/message search by recency and promote
inline type filters. (#15094, #14986)
- **Zoom HUD** β€” Show a zoom-level HUD on Cmd +/βˆ’ and Cmd 0. (#15294)
- **Copy** β€” Unescape markdown escapes when copying user messages.
(#15253)

---

## πŸ–₯️ Desktop

- **App Nap fix** β€” Prevent App Nap from dropping the gateway WebSocket
during display sleep. (#14994)
- **File preview** β€” Preview `.cjs`/`.mjs`/no-extension files instead of
binary fallback and expand `~` when opening local files. (#15168,
#15284)
- **Cross-platform settings** β€” Open settings via main-window navigation
on Windows/Linux and restore the route after an update restart. (#15036,
#14922)
- **Token refresh** β€” Prevent frequent logout from token-refresh
retries. (#14928)

---

## πŸ“Š Observability

- **OTel GenAI** β€” Instrument Agent Runtime with OpenTelemetry GenAI
semantic conventions. (#15123)
- **Generation tracing** β€” Per-call `llm_generation_tracing` with a
pre-allocated tracingId and recordFeedback router. (#15124, #15146)
- **Error classification** β€” Persist `ERROR_CODE_SPECS` classification
on operation errors. (#15273)

---

## πŸ—ƒοΈ Database Migrations

- **Batch migrations** β€” Topic usage stats, push tokens,
`tasks.editor_data`, and document shares. (#15280)
- **Tracing & eval tables** β€” Add `llm_generation_tracing` and agent
eval experiment tables. (#15126)

> Self-hosted operators should run the database migration (`pnpm
db:migrate`, or restart with auto-migrate enabled) after upgrading. The
changes are additive and backwards-compatible.

---

## πŸ”’ Security & Reliability

- **Security:** Remove the `getPlaintextCred` tool to prevent plaintext
credential exposure. (#14998)
- **Security:** Prompt account selection for Google OAuth and add
`prompt=consent` to the OIDC authorization URL to fix missing refresh
tokens. (#15234, #15010)
- **Reliability:** Preserve streamed content across a mid-stream cancel.
(#15173)
- **Reliability:** Bound the Redis command timeout and configure the
Anthropic client timeout. (#15091, #15042)
- **Reliability:** Prevent infinite recursion in the assistant chain.
(#15288)

---

## πŸ‘₯ Contributors

Huge thanks to **15 contributors** who shipped **220 merged PRs** this
cycle.

@AnotiaWang Β· @sxjeru Β· @algojogacor Β· @hardy-one Β· @arvinxx Β· @Innei Β·
@tjx666 Β· @lijian Β· @AmAzing129 Β· @rdmclin2 Β· @neko Β· @cy948 Β·
@CanisMinor Β· @sudongyuer Β· @rivertwilight

Plus @lobehubbot and renovate[bot] for maintenance.

---

**Full Changelog**: v2.2.0...release/weekly-20260528
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

πŸ’„ Design Design and style issues feature:agent-builder Agent builder size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant