Skip to content

πŸ› fix: preserve backend traceId in error handler#13607

Merged
tjx666 merged 2 commits intocanaryfrom
fix/preserve-backend-traceId
Apr 7, 2026
Merged

πŸ› fix: preserve backend traceId in error handler#13607
tjx666 merged 2 commits intocanaryfrom
fix/preserve-backend-traceId

Conversation

@tjx666
Copy link
Copy Markdown
Member

@tjx666 tjx666 commented Apr 7, 2026

πŸ’» Change Type

  • πŸ› fix

πŸ”— Related Issue

Regression from #13468

πŸ”€ Description of Change

onErrorHandle in createAgentExecutors.ts unconditionally overwrites error.body.traceId with a local traceId variable that is always undefined (from operation.metadata?.traceId). This destroys the backend-provided traceId (error log ID), causing the frontend to display {} instead of the trace ID.

Fix: fall back to error.body?.traceId when local traceId is undefined.

πŸ§ͺ How to Test

  • No tests needed

Trigger a provider error (e.g. send invalid tool schema to Vertex AI) and verify the error UI now shows the traceId instead of {}.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
lobehub Ready Ready Preview, Comment Apr 7, 2026 4:56am

Request Review

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine

@lobehubbot
Copy link
Copy Markdown
Member

@arvinxx - This is a bug fix for a regression introduced in #13468. The fix preserves the backend-provided traceId in the agent error handler. Please take a look.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 66.68%. Comparing base (d5eec83) to head (ca7acd4).
⚠️ Report is 1 commits behind head on canary.

Additional details and impacted files
@@           Coverage Diff            @@
##           canary   #13607    +/-   ##
========================================
  Coverage   66.68%   66.68%            
========================================
  Files        1997     1997            
  Lines      165873   165873            
  Branches    16854    16093   -761     
========================================
  Hits       110612   110612            
  Misses      55137    55137            
  Partials      124      124            
Flag Coverage Ξ”
app 58.57% <100.00%> (ΓΈ)
database 92.60% <ΓΈ> (ΓΈ)
packages/agent-runtime 88.98% <ΓΈ> (ΓΈ)
packages/context-engine 85.51% <ΓΈ> (ΓΈ)
packages/conversation-flow 92.36% <ΓΈ> (ΓΈ)
packages/file-loaders 87.02% <ΓΈ> (ΓΈ)
packages/memory-user-memory 66.68% <ΓΈ> (ΓΈ)
packages/model-bank 99.85% <ΓΈ> (ΓΈ)
packages/model-runtime 84.66% <ΓΈ> (ΓΈ)
packages/prompts 65.80% <ΓΈ> (ΓΈ)
packages/python-interpreter 92.90% <ΓΈ> (ΓΈ)
packages/ssrf-safe-fetch 0.00% <ΓΈ> (ΓΈ)
packages/utils 89.74% <ΓΈ> (ΓΈ)
packages/web-crawler 88.82% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Ξ”
Store 67.10% <100.00%> (ΓΈ)
Services 51.45% <ΓΈ> (ΓΈ)
Server 66.37% <ΓΈ> (ΓΈ)
Libs 51.05% <ΓΈ> (ΓΈ)
Utils 91.01% <ΓΈ> (ΓΈ)
πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tjx666 tjx666 merged commit b068c42 into canary Apr 7, 2026
34 checks passed
@tjx666 tjx666 deleted the fix/preserve-backend-traceId branch April 7, 2026 04:58
arvinxx added a commit that referenced this pull request Apr 7, 2026
# πŸš€ release: 20260407

This release includes **148 commits**. Key updates are below.

- **Response API tool execution is more capable and reliable** β€” Added
hosted builtin tools + client-side function tools and improved tool-call
streaming/completion behavior.
[#13406](#13406)
[#13414](#13414)
[#13506](#13506)
[#13555](#13555)
- **Input and composition UX upgraded** β€” Added AI input auto-completion
and multiple chat-input stability fixes.
[#13458](#13458)
[#13551](#13551)
[#13481](#13481)
- **Model/provider compatibility improved** β€” Better Gemini/Google tool
schema handling and additional model updates.
[#13429](#13429)
[#13465](#13465)
[#13613](#13613)
- **Desktop and CLI reliability improved** β€” Gateway WebSocket support
and desktop runtime upgrades.
[#13608](#13608)
[#13550](#13550)
[#13557](#13557)
- **Security hardening continued** β€” Fixed auth and sanitization risks
and upgraded vulnerable dependencies.
[#13535](#13535)
[#13529](#13529)
[#13479](#13479)

### Models & Providers

- Added/updated support for `glm-5v-turbo`, GLM-5.1 updates, and
qwen3.5-omni series.
[#13487](#13487)
[#13405](#13405)
[#13422](#13422)
- Added additional ImageGen providers/models (Wanxiang 2.7 and Keling
from Qwen). [#13478](#13478)
- Improved Gemini/Google tool schema and compatibility handling across
runtime paths. [#13429](#13429)
[#13465](#13465)
[#13613](#13613)

### Response API & Runtime

- Added hosted builtin tools in Response API and client-side function
tool execution support.
[#13406](#13406)
[#13414](#13414)
- Improved stream tool-call argument handling and `response.completed`
output correctness.
[#13506](#13506)
[#13555](#13555)
- Improved runtime error/context handling for intervention and provider
edge cases. [#13420](#13420)
[#13607](#13607)

### Desktop App

- Bumped desktop dependencies and runtime integrations (`agent-browser`,
`electron`). [#13550](#13550)
[#13557](#13557)
- Simplified desktop release channel setup by removing nightly release
flow. [#13480](#13480)

### CLI

- Added OpenClaw migration command.
[#13566](#13566)
- Added local device binding support for `lh agent run`.
[#13277](#13277)
- Added WebSocket gateway support and reconnect reliability
improvements. [#13608](#13608)
[#13418](#13418)

### Security

- Removed risky `apiKey` fallback behavior in webapi auth path to
prevent bypass risk.
[#13535](#13535)
- Sanitized HTML artifact rendering and iframe sandboxing to reduce
XSS-to-RCE risk. [#13529](#13529)
- Upgraded nodemailer to v8 to address SMTP command injection advisory.
[#13479](#13479)

### Bug Fixes

- Fixed image generation model default switch issues.
[#13587](#13587)
- Fixed subtopic re-fork message scope behavior and agent panel reset
edge cases. [#13606](#13606)
[#13556](#13556)
- Fixed chat-input freeze on paste and mention plugin behavior.
[#13551](#13551)
[#13415](#13415)
- Fixed auth/social sign-in and settings UX edge cases.
[#13368](#13368)
[#13392](#13392)
[#13338](#13338)

### Credits

Huge thanks to these contributors:

@chriszf @hardy-one @Innei @lijian @neko @OctopusNote @rdmclin2
@rivertwilight @RylanCai @suyua9 @sxjeru @Tsuki @wangyk @WindSpiritSR
@yizhuo @YuTengjing @hezhijie0327 @arvinxx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants