π fix(openapi): fix response.completed output missing message, wrong tool name & id#13555
π fix(openapi): fix response.completed output missing message, wrong tool name & id#13555
Conversation
β¦tool name & id Fix three bugs in extractOutputItems for the Response API: 1. Assistant message with text+tool_calls was dropped from output 2. Function call names kept internal ____-separated format instead of identifier/apiName 3. Function call IDs were off by one due to missing message item Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
π @nekomeowww @Innei Could you please review this PR? It fixes 3 bugs in |
There was a problem hiding this comment.
π‘ Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 93c8b88233
βΉοΈ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with π.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Reportβ
All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## canary #13555 +/- ##
===========================================
- Coverage 86.00% 66.63% -19.37%
===========================================
Files 609 1996 +1387
Lines 49045 165640 +116595
Branches 7596 16074 +8478
===========================================
+ Hits 42179 110367 +68188
- Misses 6742 55149 +48407
Partials 124 124
Flags with carried forward coverage won't be shown. Click here to find out more.
π New features to boost your workflow:
|
Replace local reimplementation with vi.mock stubs + real class import so the tests fail if the production extractOutputItems regresses. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
β¦tool name & id (lobehub#13555) * π fix(openapi): fix response.completed output missing message, wrong tool name & id Fix three bugs in extractOutputItems for the Response API: 1. Assistant message with text+tool_calls was dropped from output 2. Function call names kept internal ____-separated format instead of identifier/apiName 3. Function call IDs were off by one due to missing message item Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * β test(openapi): exercise real ResponsesService in regression tests Replace local reimplementation with vi.mock stubs + real class import so the tests fail if the production extractOutputItems regresses. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
# π release: 20260407 This release includes **148 commits**. Key updates are below. - **Response API tool execution is more capable and reliable** β Added hosted builtin tools + client-side function tools and improved tool-call streaming/completion behavior. [#13406](#13406) [#13414](#13414) [#13506](#13506) [#13555](#13555) - **Input and composition UX upgraded** β Added AI input auto-completion and multiple chat-input stability fixes. [#13458](#13458) [#13551](#13551) [#13481](#13481) - **Model/provider compatibility improved** β Better Gemini/Google tool schema handling and additional model updates. [#13429](#13429) [#13465](#13465) [#13613](#13613) - **Desktop and CLI reliability improved** β Gateway WebSocket support and desktop runtime upgrades. [#13608](#13608) [#13550](#13550) [#13557](#13557) - **Security hardening continued** β Fixed auth and sanitization risks and upgraded vulnerable dependencies. [#13535](#13535) [#13529](#13529) [#13479](#13479) ### Models & Providers - Added/updated support for `glm-5v-turbo`, GLM-5.1 updates, and qwen3.5-omni series. [#13487](#13487) [#13405](#13405) [#13422](#13422) - Added additional ImageGen providers/models (Wanxiang 2.7 and Keling from Qwen). [#13478](#13478) - Improved Gemini/Google tool schema and compatibility handling across runtime paths. [#13429](#13429) [#13465](#13465) [#13613](#13613) ### Response API & Runtime - Added hosted builtin tools in Response API and client-side function tool execution support. [#13406](#13406) [#13414](#13414) - Improved stream tool-call argument handling and `response.completed` output correctness. [#13506](#13506) [#13555](#13555) - Improved runtime error/context handling for intervention and provider edge cases. [#13420](#13420) [#13607](#13607) ### Desktop App - Bumped desktop dependencies and runtime integrations (`agent-browser`, `electron`). [#13550](#13550) [#13557](#13557) - Simplified desktop release channel setup by removing nightly release flow. [#13480](#13480) ### CLI - Added OpenClaw migration command. [#13566](#13566) - Added local device binding support for `lh agent run`. [#13277](#13277) - Added WebSocket gateway support and reconnect reliability improvements. [#13608](#13608) [#13418](#13418) ### Security - Removed risky `apiKey` fallback behavior in webapi auth path to prevent bypass risk. [#13535](#13535) - Sanitized HTML artifact rendering and iframe sandboxing to reduce XSS-to-RCE risk. [#13529](#13529) - Upgraded nodemailer to v8 to address SMTP command injection advisory. [#13479](#13479) ### Bug Fixes - Fixed image generation model default switch issues. [#13587](#13587) - Fixed subtopic re-fork message scope behavior and agent panel reset edge cases. [#13606](#13606) [#13556](#13556) - Fixed chat-input freeze on paste and mention plugin behavior. [#13551](#13551) [#13415](#13415) - Fixed auth/social sign-in and settings UX edge cases. [#13368](#13368) [#13392](#13392) [#13338](#13338) ### Credits Huge thanks to these contributors: @chriszf @hardy-one @Innei @lijian @neko @OctopusNote @rdmclin2 @rivertwilight @RylanCai @suyua9 @sxjeru @Tsuki @wangyk @WindSpiritSR @yizhuo @YuTengjing @hezhijie0327 @arvinxx
π» Change Type
π Related Issue
N/A
π Description of Change
Fix three bugs in
ResponsesService.extractOutputItemsthat caused theresponse.completedevent to differ from streaming events:____-separated format (e.g.lobe-cloud-sandbox____executeCode____builtin) was passed through instead of being decoded to the display format (lobe-cloud-sandbox/executeCode), which is what streaming events emit.itemCounterstarted at 0 for the function_call instead of 1, causing ID mismatch with streaming output.π§ͺ How to Test
9 regression tests covering all 3 bugs.