feat: rename the environment variable used to communicate wtih user scripts#130
feat: rename the environment variable used to communicate wtih user scripts#130levibostian merged 2 commits intomainfrom
Conversation
…able DECAF_COMM_FILE_PATH I just want a better name. DATA_FILE_PATH describes poorly what tool owns the env var and what the purpose is. This is a breaking change. Even though we are pre-1.0, I dont want to make it breaking now for such a small change. So for now, we are just adding support for the new env var so users can begin to use it. then in 1.0, we will drop the old one.
decafRunning deployments in test mode. Results will appear below. ...🟩 squash 🟩 merge method... 🚢 The next version of the project will be: 0.10.0 Learn moreLatest release: 0.9.2 Commit of latest release: fe10806 Commits since last release: - feat: rename the environment variable used to communicate wtih user scripts Related GitHub Issues<!-- Link to any related GitHub issues that this pull request addresses or closes. --> Problem<!-- A clear description of the problem that this pull request is solving. --> I just want a better name. DATA_FILE_PATH describes poorly what tool owns the env var and what the purpose is. Solution<!-- Describe the approach you took to solve the problem and the changes made in this pull request. --> New name: This has the potential of being a breaking change. Though we are pre-1.0, I dont want to make it breaking now for such a small change. Because of that, we are just adding support for the new env var so users can begin to use it. Then in 1.0, we will drop the old one. Testing<!-- Choose one of the below options for how you tested the code change. Include any specific setup or instructions for testing. -->
Notes for reviewers<!-- If there is any additional information you would like to share with the person reviewing this pull request, please provide it here. --> Marking this as a This PR contains the following updates: | Package | Change | Configuration📅 Schedule: Branch creation - "every weekend" in timezone 🚦 Automerge: Disabled by config. Please merge this manually once you ♻ Rebasing: Whenever PR becomes conflicted, or you tick the 🔕 Ignore: Close this PR and you won't be reminded about this update
This PR was generated by Mend Renovate. Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Related GitHub IssuesProblemSo, you wrote some scripts for decaf deployment. Have you properly SolutionThis PR...
Testing
Notes for reviewers- chore(deps): update granodigital/report-annotate action to v3.1.3 (#128) This PR contains the following updates:
| Release Notesgranodigital/report-annotate (granodigital/report-annotate)What's Changed
Full Changelog: Fixed
Improved
Full Changelog: Configuration📅 Schedule: Branch creation - "every weekend" in timezone 🚦 Automerge: Enabled. ♻ Rebasing: Whenever PR is behind base branch, or you tick the 🔕 Ignore: Close this PR and you won't be reminded about this update
This PR was generated by Mend Renovate. Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> This PR contains the following updates:
Release Notesdenoland/deno (deno)
(#31683)
(#31829)
(#31510)
(#31780)
(#31785) Configuration📅 Schedule: Branch creation - "every weekend" in timezone 🚦 Automerge: Disabled by config. Please merge this manually once you ♻ Rebasing: Whenever PR becomes conflicted, or you tick the 🔕 Ignore: Close this PR and you won't be reminded about this update
This PR was generated by Mend Renovate. Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> This PR contains the following updates:
Configuration📅 Schedule: Branch creation - "every weekend" in timezone 🚦 Automerge: Disabled by config. Please merge this manually once you ♻ Rebasing: Whenever PR becomes conflicted, or you tick the 🔕 Ignore: Close this PR and you won't be reminded about this update
This PR was generated by Mend Renovate. Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> ...🟩 rebase 🟩 merge method... 🌴 It will not trigger a deployment. No new version will be deployed. Learn moreLatest release: 0.9.2 Commit of latest release: fe10806 Commits since last release: - ci: disable git push for deployment script, not even dry-run to fix CI Getting error in test mode decaf deployments in PR: This code was introduced in the previous pull request that I just merged in, which added the dry run. I'm wondering if, for some reason, that's just not working. I looked at the CI runs, and this command simply did not run in test mode in the previous pull request. So, I have a good feeling that this just isn't going to work. I just want a better name. DATA_FILE_PATH describes poorly what tool owns the env var and what the purpose is. This is a breaking change. Even though we are pre-1.0, I dont want to make it breaking now for such a small change. So for now, we are just adding support for the new env var so users can begin to use it. then in 1.0, we will drop the old one. This PR contains the following updates: | Package | Change | Configuration📅 Schedule: Branch creation - "every weekend" in timezone 🚦 Automerge: Disabled by config. Please merge this manually once you ♻ Rebasing: Whenever PR becomes conflicted, or you tick the 🔕 Ignore: Close this PR and you won't be reminded about this update
This PR was generated by Mend Renovate. Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Related GitHub IssuesProblemSo, you wrote some scripts for decaf deployment. Have you properly SolutionThis PR...
Testing
Notes for reviewers- chore(deps): update granodigital/report-annotate action to v3.1.3 (#128) This PR contains the following updates:
| Release Notesgranodigital/report-annotate (granodigital/report-annotate)What's Changed
Full Changelog: Fixed
Improved
Full Changelog: Configuration📅 Schedule: Branch creation - "every weekend" in timezone 🚦 Automerge: Enabled. ♻ Rebasing: Whenever PR is behind base branch, or you tick the 🔕 Ignore: Close this PR and you won't be reminded about this update
This PR was generated by Mend Renovate. Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> This PR contains the following updates:
Release Notesdenoland/deno (deno)
(#31683)
(#31829)
(#31510)
(#31780)
(#31785) Configuration📅 Schedule: Branch creation - "every weekend" in timezone 🚦 Automerge: Disabled by config. Please merge this manually once you ♻ Rebasing: Whenever PR becomes conflicted, or you tick the 🔕 Ignore: Close this PR and you won't be reminded about this update
This PR was generated by Mend Renovate. Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> This PR contains the following updates:
Configuration📅 Schedule: Branch creation - "every weekend" in timezone 🚦 Automerge: Disabled by config. Please merge this manually once you ♻ Rebasing: Whenever PR becomes conflicted, or you tick the 🔕 Ignore: Close this PR and you won't be reminded about this update
This PR was generated by Mend Renovate. Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> |
Pull Request Test Coverage Report for Build 21143968078Details
💛 - Coveralls |
decaf is going to do a rename of the environment variable - from DATA_FILE_PATH to DECAF_COMM_FILE_PATH. learn more: levibostian/decaf#130 this commit prepares for that change by adding support for DECAF_COMM_FILE_PATH while still keeping backwards compatible support until v1.0
Getting error in test mode decaf deployments in PR: ``` > git push '--dry-run' fatal: could not read Username for 'https://github.com': No such device or address ``` This code was introduced in the previous pull request that I just merged in, which added the dry run. I'm wondering if, for some reason, that's just not working. I looked at the CI runs, and this command simply did not run in test mode in the previous pull request. So, I have a good feeling that this just isn't going to work.
…cripts (#8) decaf is going to do a rename of the environment variable - from DATA_FILE_PATH to DECAF_COMM_FILE_PATH. learn more: levibostian/decaf#130 this commit prepares for that change by adding support for DECAF_COMM_FILE_PATH while still keeping backwards compatible support until v1.0
Related GitHub Issues
Problem
I just want a better name. DATA_FILE_PATH describes poorly what tool owns the env var and what the purpose is.
Solution
New name:
DECAF_COMM_FILE_PATH- it includes "decaf" in the name, "comm" to indicate it's used for communication, and "file path" is still in the name because the value is a file path.This has the potential of being a breaking change. Though we are pre-1.0, I dont want to make it breaking now for such a small change. Because of that, we are just adding support for the new env var so users can begin to use it. Then in 1.0, we will drop the old one.
Testing
Notes for reviewers
Marking this as a
feat:to ship this change to prod as a new release. Even though this is a small change, we are updating the README docs to encourage people to use the new env var name as soon as possible to prepare for v1.0. To do that, we need to ship this change, otherwise their script will not work.