Skip to content

fix(cli/test): close Node HTTP connections before sanitizer check#31782

Merged
fraidev merged 2 commits intodenoland:mainfrom
fraidev:fix-fetch-test-leak
Jan 7, 2026
Merged

fix(cli/test): close Node HTTP connections before sanitizer check#31782
fraidev merged 2 commits intodenoland:mainfrom
fraidev:fix-fetch-test-leak

Conversation

@fraidev
Copy link
Copy Markdown
Contributor

@fraidev fraidev commented Jan 7, 2026

Closes #31777

Fixes false positive "leaking resources" errors when running tests that use Node.js HTTP/HTTPS client with connection pooling.

  • Add closeIdleConnections() to close HTTP Agent pooled connections before test sanitizer runs
  • Remove sanitizeResources: false workarounds from HTTPS tests that no longer need them

@fraidev fraidev changed the title fix(cli/test): close Node.js HTTP agent pooled connections before san… fix(cli/test): close Node HTTP conns before sanitizer check Jan 7, 2026
@fraidev fraidev changed the title fix(cli/test): close Node HTTP conns before sanitizer check fix(cli/test): close Node HTTP connections before sanitizer check Jan 7, 2026
Copy link
Copy Markdown
Contributor

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fraidev fraidev merged commit 014ba79 into denoland:main Jan 7, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fetch() keep-alive / connection pooling triggers resource leak sanitizer

2 participants