Skip to content

fix(node/child_process): improve arg type validation for execFile and fork#31829

Merged
fraidev merged 2 commits intodenoland:mainfrom
fraidev:fix/node-child-process-spawn-typeerror
Jan 13, 2026
Merged

fix(node/child_process): improve arg type validation for execFile and fork#31829
fraidev merged 2 commits intodenoland:mainfrom
fraidev:fix/node-child-process-spawn-typeerror

Conversation

@fraidev
Copy link
Copy Markdown
Contributor

@fraidev fraidev commented Jan 13, 2026

  • Improves argument type validation in execFile() and fork() to match Node.js behavior
  • Fixes error code from ERR_INVALID_ARG_VALUE to ERR_INVALID_ARG_TYPE in fork argument validation
  • Adds explicit array rejection in options position (arrays are objects but not valid options)
  • Enables test-child-process-spawn-typeerror.js in node compatibility tests

@fraidev fraidev marked this pull request as ready for review January 13, 2026 05:07
@fraidev fraidev changed the title fix(node/child_process): improve argument type validation for execFil… fix(node/child_process): improve argument type validation for execFile and fork Jan 13, 2026
@fraidev fraidev changed the title fix(node/child_process): improve argument type validation for execFile and fork fix(node/child_process): improve arg type validation for execFile and fork Jan 13, 2026
@fraidev fraidev force-pushed the fix/node-child-process-spawn-typeerror branch from b73351c to b7a171b Compare January 13, 2026 05:09
@fraidev fraidev force-pushed the fix/node-child-process-spawn-typeerror branch from b7a171b to fea6658 Compare January 13, 2026 05:10
Copy link
Copy Markdown
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fraidev fraidev merged commit 7be740f into denoland:main Jan 13, 2026
19 checks passed
@fraidev fraidev mentioned this pull request Jan 13, 2026
68 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants