documentation + automated tests for project's deployment scripts#125
documentation + automated tests for project's deployment scripts#125levibostian merged 20 commits intomainfrom
Conversation
it's best when test mode and non-test mode runs as much similar code as possible.
…nction the method I was using would output stdout and then stderr, but the order matters! Fixed it.
after adding mock-a-bin, code coverage report now includes the deno code for the bin override code written in the steps/*.test.ts files. Exclude them.
…e it's human readable
decafRunning deployments in test mode. Results will appear below. ...🟩 squash 🟩 merge method... 🌴 It will not trigger a deployment. No new version will be deployed. Learn moreLatest release: 0.9.2 Commit of latest release: fe10806 Commits since last release: - documentation + automated tests for project's deployment scripts Related GitHub IssuesProblemSo, you wrote some scripts for decaf deployment. Have you properly tested those scripts? decaf comes with test mode when you open a PR, but for some projects, that may not be enough. SolutionThis PR...
Testing
Notes for reviewers- chore(deps): update granodigital/report-annotate action to v3.1.3 (#128) This PR contains the following updates:
| Release Notesgranodigital/report-annotate (granodigital/report-annotate)What's Changed
Full Changelog: Fixed
Improved
Full Changelog: Configuration📅 Schedule: Branch creation - "every weekend" in timezone 🚦 Automerge: Enabled. ♻ Rebasing: Whenever PR is behind base branch, or you tick the 🔕 Ignore: Close this PR and you won't be reminded about this update
This PR was generated by Mend Renovate. Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> This PR contains the following updates:
Release Notesdenoland/deno (deno)
(#31683)
(#31829)
(#31510)
(#31780)
(#31785) Configuration📅 Schedule: Branch creation - "every weekend" in timezone 🚦 Automerge: Disabled by config. Please merge this manually once you ♻ Rebasing: Whenever PR becomes conflicted, or you tick the 🔕 Ignore: Close this PR and you won't be reminded about this update
This PR was generated by Mend Renovate. Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> This PR contains the following updates:
Configuration📅 Schedule: Branch creation - "every weekend" in timezone 🚦 Automerge: Disabled by config. Please merge this manually once you ♻ Rebasing: Whenever PR becomes conflicted, or you tick the 🔕 Ignore: Close this PR and you won't be reminded about this update
This PR was generated by Mend Renovate. Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> ...🟩 rebase 🟩 merge method... 🌴 It will not trigger a deployment. No new version will be deployed. Learn moreLatest release: 0.9.2 Commit of latest release: fe10806 Commits since last release: - rename deno.json to jsonc to add comments - build: fix generating lcov coverage file turns out, it wasn't making it. the 'deno task test' command already generates the coverage report Tests were passing on my development machine, but not on the CI. After looking into it, I found that when the test suite was running the deploy script, it was actually running the Dino JSR scripts, which had different behavior in the different environments. We actually shouldn't be running those anyway; they are dependencies, and so they should be blocked. I mocked them to fix the problem. In order to successfully mock these, I needed to update the mockabin version to a new version that contains a new feature where you can more conditionally mock binary areas. This is required because originally you could only mock all Deno commands, but that broke the ability for the test runner to even run the deploy script, because it is a Deno script. So now we can conditionally mock, which means we just mock when it's a JSR command. I have some failing tests with the new decaf script tests I wrote. but it's hard to know why because I can't see the script logs! I added this feature ability to the SDK and updated to that version in here. after adding mock-a-bin, code coverage report now includes the deno code for the bin override code written in the steps/*.test.ts files. Exclude them. the method I was using would output stdout and then stderr, but the order matters! Fixed it. it's best when test mode and non-test mode runs as much similar code as possible. This PR contains the following updates:
| Release Notesgranodigital/report-annotate (granodigital/report-annotate)What's Changed
Full Changelog: Fixed
Improved
Full Changelog: Configuration📅 Schedule: Branch creation - "every weekend" in timezone 🚦 Automerge: Enabled. ♻ Rebasing: Whenever PR is behind base branch, or you tick the 🔕 Ignore: Close this PR and you won't be reminded about this update
This PR was generated by Mend Renovate. Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> This PR contains the following updates:
Release Notesdenoland/deno (deno)
(#31683)
(#31829)
(#31510)
(#31780)
(#31785) Configuration📅 Schedule: Branch creation - "every weekend" in timezone 🚦 Automerge: Disabled by config. Please merge this manually once you ♻ Rebasing: Whenever PR becomes conflicted, or you tick the 🔕 Ignore: Close this PR and you won't be reminded about this update
This PR was generated by Mend Renovate. Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> This PR contains the following updates:
Configuration📅 Schedule: Branch creation - "every weekend" in timezone 🚦 Automerge: Disabled by config. Please merge this manually once you ♻ Rebasing: Whenever PR becomes conflicted, or you tick the 🔕 Ignore: Close this PR and you won't be reminded about this update
This PR was generated by Mend Renovate. Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> |
I have some failing tests with the new decaf script tests I wrote. but it's hard to know why because I can't see the script logs! I added this feature ability to the SDK and updated to that version in here.
Tests were passing on my development machine, but not on the CI. After looking into it, I found that when the test suite was running the deploy script, it was actually running the Dino JSR scripts, which had different behavior in the different environments. We actually shouldn't be running those anyway; they are dependencies, and so they should be blocked. I mocked them to fix the problem. In order to successfully mock these, I needed to update the mockabin version to a new version that contains a new feature where you can more conditionally mock binary areas. This is required because originally you could only mock all Deno commands, but that broke the ability for the test runner to even run the deploy script, because it is a Deno script. So now we can conditionally mock, which means we just mock when it's a JSR command.
390f467 to
7ec7207
Compare
the 'deno task test' command already generates the coverage report
turns out, it wasn't making it.
Pull Request Test Coverage Report for Build 21095627508Details
💛 - Coveralls |
821e102 to
8eee6d4
Compare
17aaa12 to
071c842
Compare
Related GitHub Issues
Problem
So, you wrote some scripts for decaf deployment. Have you properly tested those scripts? decaf comes with test mode when you open a PR, but for some projects, that may not be enough.
Solution
This PR...
Testing
Notes for reviewers