[Merged by Bors] - feat: port Algebra.Order.Monoid.WithTop#902
Closed
joneugster wants to merge 18 commits intomasterfrom
Closed
[Merged by Bors] - feat: port Algebra.Order.Monoid.WithTop#902joneugster wants to merge 18 commits intomasterfrom
joneugster wants to merge 18 commits intomasterfrom
Conversation
2 tasks
bors bot
pushed a commit
that referenced
this pull request
Dec 9, 2022
mathlib3: 655994e298904d7e5bbd1e18c95defd7b543eb94 - [x] depends on #910 Not too bad. Mostly renaming instances and a few broken proofs. Things to double-check (all marked with `Porting note`): - `lift` is not implemented yet, I replaced it with `induction`. - In `addSemigroup` I didn't get `repeat` or `repeat'` to work. That could be golfed. - In `WithTop.addHom` the anonymous constructor didn't work, but writing it out, it did. Is that expected? - I'm a bit unsure about coersions. I left in most things and removed (commented out) the lemma `coe_coe_add_hom`. Could be worth gleaming over anything that has `coe` in it's name. Co-authored-by: Jon Eugster <eugster.jon@gmail.com> Co-authored-by: Jon Eugster <Jon.Eugster@hhu.de>
|
Pull request successfully merged into master. Build succeeded: |
bors bot
pushed a commit
to leanprover-community/mathlib3
that referenced
this pull request
Dec 10, 2022
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status). Relates to the following PRs: * `algebra.group.ulift`: leanprover-community/mathlib4#906 * `algebra.group.with_one.basic`: leanprover-community/mathlib4#922 * `algebra.group_with_zero.units.lemmas`: leanprover-community/mathlib4#920 * `algebra.order.field.defs`: leanprover-community/mathlib4#905 * `algebra.order.group.abs`: leanprover-community/mathlib4#896 * `algebra.order.group.inj_surj`: leanprover-community/mathlib4#916 * `algebra.order.group.type_tags`: leanprover-community/mathlib4#921 * `algebra.order.monoid.with_top`: leanprover-community/mathlib4#902 * `algebra.order.positive.ring`: leanprover-community/mathlib4#911 * `algebra.order.ring.canonical`: leanprover-community/mathlib4#905 * `algebra.order.ring.char_zero`: leanprover-community/mathlib4#905 * `algebra.order.ring.defs`: leanprover-community/mathlib4#905 * `algebra.order.ring.inj_surj`: leanprover-community/mathlib4#917 * `algebra.ring.idempotents`: leanprover-community/mathlib4#918
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mathlib3: 655994e298904d7e5bbd1e18c95defd7b543eb94
WithBot,WithTop,WithOneandWithZero#910Not too bad. Mostly renaming instances and a few broken proofs.
Things to double-check (all marked with
Porting note):liftis not implemented yet, I replaced it withinduction.addSemigroupI didn't getrepeatorrepeat'to work. That could be golfed.WithTop.addHomthe anonymous constructor didn't work, but writing it out, it did. Is that expected?coe_coe_add_hom. Could be worth gleaming over anything that hascoein it's name.