[Merged by Bors] - feat: port Algebra.Group.WithOne.Basic#922
Closed
[Merged by Bors] - feat: port Algebra.Group.WithOne.Basic#922
Conversation
Member
|
SHAs shouldn't go in PR titles (ever?). Looking at this PR title and description I have no idea what it's about. |
Contributor
Author
|
sorry, that was just a typo. VS Code auto-named the PR title and I forgot to change it. |
Contributor
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Dec 9, 2022
mathlib3 SHA: 4dc134b97a3de65ef2ed881f3513d56260971562
porting notes:
1. In `WithOne.lift` mathport's output was broken, but I think the only reason was that it was parenthesized wrong (or maybe it was a whitespace / formatting issue?)
2. In `MulEquiv.withOneCongr`, there were some `simp` calls that broke. I think this is a result of the way coercions are handled now. I think the net result is that `simp` doesn't get it into a form where it can apply `Equiv.symm_apply_apply`.
3. I added the `to_additive` attribute to `MulEquiv.withOneCongr_{refl, symm, trans}` because it just seemed to be missing from mathlib3.
4. `WithOne` already has semireducible transparency in mathlib4, so we are just ignoring the changing of transparency settings (this isn't even possible in Lean 4); see [Zulip](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/local.20semireducible)
|
Pull request successfully merged into master. Build succeeded: |
bors bot
pushed a commit
to leanprover-community/mathlib3
that referenced
this pull request
Dec 10, 2022
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status). Relates to the following PRs: * `algebra.group.ulift`: leanprover-community/mathlib4#906 * `algebra.group.with_one.basic`: leanprover-community/mathlib4#922 * `algebra.group_with_zero.units.lemmas`: leanprover-community/mathlib4#920 * `algebra.order.field.defs`: leanprover-community/mathlib4#905 * `algebra.order.group.abs`: leanprover-community/mathlib4#896 * `algebra.order.group.inj_surj`: leanprover-community/mathlib4#916 * `algebra.order.group.type_tags`: leanprover-community/mathlib4#921 * `algebra.order.monoid.with_top`: leanprover-community/mathlib4#902 * `algebra.order.positive.ring`: leanprover-community/mathlib4#911 * `algebra.order.ring.canonical`: leanprover-community/mathlib4#905 * `algebra.order.ring.char_zero`: leanprover-community/mathlib4#905 * `algebra.order.ring.defs`: leanprover-community/mathlib4#905 * `algebra.order.ring.inj_surj`: leanprover-community/mathlib4#917 * `algebra.ring.idempotents`: leanprover-community/mathlib4#918
bors bot
pushed a commit
that referenced
this pull request
Dec 20, 2022
This is a proposed fix for the broken simp calls in #922. See https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/.60simp.60.20calls.20broken.20in.20mathlib4.23922/near/314783451 for more details. Note that `to_fun_as_coe` was a syntactic tautology when it was ported, but this is no longer the case because we now have `FunLike`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mathlib3 SHA: 4dc134b97a3de65ef2ed881f3513d56260971562
porting notes:
WithOne.liftmathport's output was broken, but I think the only reason was that it was parenthesized wrong (or maybe it was a whitespace / formatting issue?)MulEquiv.withOneCongr, there were somesimpcalls that broke. I think this is a result of the way coercions are handled now. I think the net result is thatsimpdoesn't get it into a form where it can applyEquiv.symm_apply_apply.to_additiveattribute toMulEquiv.withOneCongr_{refl, symm, trans}because it just seemed to be missing from mathlib3.WithOnealready has semireducible transparency in mathlib4, so we are just ignoring the changing of transparency settings (this isn't even possible in Lean 4); see Zulip