[Merged by Bors] - feat: port Algebra.Order.[Ring|Field].Defs#905
Closed
[Merged by Bors] - feat: port Algebra.Order.[Ring|Field].Defs#905
Conversation
1 task
Member
|
LGTM! |
Member
|
Thanks 🎉 bors merge |
bors bot
pushed a commit
that referenced
this pull request
Dec 8, 2022
655994e298904d7e5bbd1e18c95defd7b543eb94 Ports: * `Algebra.Order.Ring.Defs` * `Algebra.Order.Ring.Canonical` * `Algebra.Order.Ring.CharZero` * `Algebra.Order.Field.Defs` Todo: * [x] Fix a few proofs; nothing looks bad. * [x] Deal with unused arguments. * [x] Check #aligns * [x] Fix casing of names in comments. * [x] Long lines * [x] Linting * [x] Remove old `Algebra.Order.Ring` Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors bot
pushed a commit
that referenced
this pull request
Dec 10, 2022
655994e298904d7e5bbd1e18c95defd7b543eb94 - [x] depends on: #905 Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
bors bot
pushed a commit
to leanprover-community/mathlib3
that referenced
this pull request
Dec 10, 2022
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status). Relates to the following PRs: * `algebra.group.ulift`: leanprover-community/mathlib4#906 * `algebra.group.with_one.basic`: leanprover-community/mathlib4#922 * `algebra.group_with_zero.units.lemmas`: leanprover-community/mathlib4#920 * `algebra.order.field.defs`: leanprover-community/mathlib4#905 * `algebra.order.group.abs`: leanprover-community/mathlib4#896 * `algebra.order.group.inj_surj`: leanprover-community/mathlib4#916 * `algebra.order.group.type_tags`: leanprover-community/mathlib4#921 * `algebra.order.monoid.with_top`: leanprover-community/mathlib4#902 * `algebra.order.positive.ring`: leanprover-community/mathlib4#911 * `algebra.order.ring.canonical`: leanprover-community/mathlib4#905 * `algebra.order.ring.char_zero`: leanprover-community/mathlib4#905 * `algebra.order.ring.defs`: leanprover-community/mathlib4#905 * `algebra.order.ring.inj_surj`: leanprover-community/mathlib4#917 * `algebra.ring.idempotents`: leanprover-community/mathlib4#918
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
655994e298904d7e5bbd1e18c95defd7b543eb94
Ports:
Algebra.Order.Ring.DefsAlgebra.Order.Ring.CanonicalAlgebra.Order.Ring.CharZeroAlgebra.Order.Field.DefsTodo:
Algebra.Order.Ring