[Merged by Bors] - chore: naming instances around WithBot, WithTop, WithOne and WithZero#910
Closed
joneugster wants to merge 4 commits intomasterfrom
Closed
[Merged by Bors] - chore: naming instances around WithBot, WithTop, WithOne and WithZero#910joneugster wants to merge 4 commits intomasterfrom
WithBot, WithTop, WithOne and WithZero#910joneugster wants to merge 4 commits intomasterfrom
Conversation
Contributor
|
Thanks, even without any #aligns (which we mostly haven't been doing for instances) this is very useful. bors merge |
bors bot
pushed a commit
that referenced
this pull request
Dec 8, 2022
…ithZero` (#910) `#align`s are missing, I'm having a hard time guessing the lean3 instance names... Co-authored-by: Jon Eugster <eugster.jon@gmail.com> Co-authored-by: Jon Eugster <Jon.Eugster@hhu.de>
1 task
|
Canceled. |
Contributor
Author
|
@semorrison if you could run bors merge again, had a typo |
|
🔒 Permission denied Existing reviewers: click here to make joneugster a reviewer |
2 tasks
Member
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Dec 8, 2022
…ithZero` (#910) `#align`s are missing, I'm having a hard time guessing the lean3 instance names... Co-authored-by: Jon Eugster <eugster.jon@gmail.com> Co-authored-by: Jon Eugster <Jon.Eugster@hhu.de>
|
Pull request successfully merged into master. Build succeeded:
|
WithBot, WithTop, WithOne and WithZeroWithBot, WithTop, WithOne and WithZero
bors bot
pushed a commit
that referenced
this pull request
Dec 9, 2022
mathlib3: 655994e298904d7e5bbd1e18c95defd7b543eb94 - [x] depends on #910 Not too bad. Mostly renaming instances and a few broken proofs. Things to double-check (all marked with `Porting note`): - `lift` is not implemented yet, I replaced it with `induction`. - In `addSemigroup` I didn't get `repeat` or `repeat'` to work. That could be golfed. - In `WithTop.addHom` the anonymous constructor didn't work, but writing it out, it did. Is that expected? - I'm a bit unsure about coersions. I left in most things and removed (commented out) the lemma `coe_coe_add_hom`. Could be worth gleaming over anything that has `coe` in it's name. Co-authored-by: Jon Eugster <eugster.jon@gmail.com> Co-authored-by: Jon Eugster <Jon.Eugster@hhu.de>
bors bot
pushed a commit
that referenced
this pull request
Dec 12, 2022
mathlib3 655994e298904d7e5bbd1e18c95defd7b543eb94 ~~All remaining issues are elaboration problems involving the order-dual. I think these should be debugged carefully, but I am not sure whether I will have time this weekend, so help is welcome.~~ I fixed these with a bunch of `@` and opened a [Zulip thread](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Type.20synonyms). - [x] depends on #910 - [x] depends on #923 Co-authored-by: Jon <jon.eugster@gmx.ch> Co-authored-by: Jon Eugster <eugster.jon@gmail.com> Co-authored-by: Jon Eugster <Jon.Eugster@hhu.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#aligns are missing, I'm having a hard time guessing the lean3 instance names...