[Merged by Bors] - feat: re-port Algebra.Order.Monoid.WithZero#923
Closed
[Merged by Bors] - feat: re-port Algebra.Order.Monoid.WithZero#923
Conversation
2 tasks
Contributor
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Dec 9, 2022
This file had been modified in mathlib3 since the commit that the first port was based on. Here is the mathlib3 commit that this port is based on: [4dc134b97a3de65ef2ed881f3513d56260971562](leanprover-community/mathlib3@4dc134b) The first commit here is the output of mathport on that commit, in case anyone wants to check the diff.
|
Pull request successfully merged into master. Build succeeded:
|
bors bot
pushed a commit
that referenced
this pull request
Dec 12, 2022
mathlib3 655994e298904d7e5bbd1e18c95defd7b543eb94 ~~All remaining issues are elaboration problems involving the order-dual. I think these should be debugged carefully, but I am not sure whether I will have time this weekend, so help is welcome.~~ I fixed these with a bunch of `@` and opened a [Zulip thread](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Type.20synonyms). - [x] depends on #910 - [x] depends on #923 Co-authored-by: Jon <jon.eugster@gmx.ch> Co-authored-by: Jon Eugster <eugster.jon@gmail.com> Co-authored-by: Jon Eugster <Jon.Eugster@hhu.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This file had been modified in mathlib3 since the commit that the first port was based on.
Here is the mathlib3 commit that this port is based on:
4dc134b97a3de65ef2ed881f3513d56260971562
The first commit here is the output of mathport on that commit, in case anyone wants to check the diff.