[Merged by Bors] - port: Algebra.Order.Monoid.NatCast#893
Closed
[Merged by Bors] - port: Algebra.Order.Monoid.NatCast#893
Conversation
1 task
Ruben-VandeVelde
approved these changes
Dec 7, 2022
Member
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Dec 7, 2022
Ported by hand from current mathlib: 07fee0ca54c320250c98bacf31ca5f288b2bcbe2 This is thoroughly ridiculous, but it my fault for merging leanprover-community/mathlib3#17820, see discussion on [zulip](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/OfNat). Rather than proving 1 + 1 = 2 (I feel ridiculous), these lemmas should just happen later in mathlib, with stronger typeclasses. But these files are holding up the port, so its better to get this ported as is, and we can make it more sensible later... Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Pull request successfully merged into master. Build succeeded:
|
bors bot
pushed a commit
to leanprover-community/mathlib3
that referenced
this pull request
Dec 8, 2022
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status). Relates to the following PRs: * `algebra.euclidean_domain.defs`: leanprover-community/mathlib4#871 * `algebra.group.ext`: leanprover-community/mathlib4#850 * `algebra.group_power.basic`: leanprover-community/mathlib4#874 * `algebra.hom.equiv.units.basic`: leanprover-community/mathlib4#895 * `algebra.hom.equiv.units.group_with_zero`: leanprover-community/mathlib4#901 * `algebra.order.group.instances`: leanprover-community/mathlib4#890 * `algebra.order.group.order_iso`: leanprover-community/mathlib4#895 * `algebra.order.group.units`: leanprover-community/mathlib4#898 * `algebra.order.monoid.nat_cast`: leanprover-community/mathlib4#893 * `algebra.order.monoid.type_tags`: leanprover-community/mathlib4#873 * `algebra.order.monoid.units`: leanprover-community/mathlib4#873 * `algebra.order.zero_le_one`: leanprover-community/mathlib4#893 * `combinatorics.quiver.push`: leanprover-community/mathlib4#868 * `control.traversable.basic`: leanprover-community/mathlib4#788 * `data.sum.order`: leanprover-community/mathlib4#880 * `group_theory.group_action.option`: leanprover-community/mathlib4#884 * `group_theory.group_action.sigma`: leanprover-community/mathlib4#885 * `group_theory.group_action.sum`: leanprover-community/mathlib4#882 * `group_theory.group_action.units`: leanprover-community/mathlib4#878 * `order.antisymmetrization`: leanprover-community/mathlib4#876
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ported by hand from current mathlib: 07fee0ca54c320250c98bacf31ca5f288b2bcbe2
This is thoroughly ridiculous, but it my fault for merging leanprover-community/mathlib3#17820, see discussion on zulip.
Rather than proving 1 + 1 = 2 (I feel ridiculous), these lemmas should just happen later in mathlib, with stronger typeclasses. But these files are holding up the port, so its better to get this ported as is, and we can make it more sensible later...