Closed
Conversation
kim-em
reviewed
Dec 7, 2022
| rfl | ||
| #align order_hom.coe_antisymmetrization OrderHom.coe_antisymmetrization | ||
|
|
||
| /- Porting notes: Removed @[simp] attribute -/ |
Contributor
There was a problem hiding this comment.
Probably best if you say why in the porting note.
kim-em
reviewed
Dec 7, 2022
| map_rel_iff' := ofAntisymmetrization_le_ofAntisymmetrization_iff | ||
| #align order_embedding.of_antisymmetrization OrderEmbedding.ofAntisymmetrization | ||
|
|
||
| /-- `antisymmetrization` and `order_dual` commute. -/ |
Contributor
There was a problem hiding this comment.
Suggested change
| /-- `antisymmetrization` and `order_dual` commute. -/ | |
| /-- `Antisymmetrization` and `OrderDual` commute. -/ |
kim-em
reviewed
Dec 7, 2022
Comment on lines
+86
to
+87
| /-- The partial order derived from a preorder by making pairwise comparable elements equal. This is | ||
| the quotient by `λ a b, a ≤ b ∧ b ≤ a`. -/ |
Contributor
There was a problem hiding this comment.
Suggested change
| /-- The partial order derived from a preorder by making pairwise comparable elements equal. This is | |
| the quotient by `λ a b, a ≤ b ∧ b ≤ a`. -/ | |
| /-- The partial order derived from a preorder by making pairwise comparable elements equal. This is | |
| the quotient by `fun a b => a ≤ b ∧ b ≤ a`. -/ |
Contributor
|
bors d+ |
|
✌️ ChrisHughes24 can now approve this pull request. To approve and merge a pull request, simply reply with |
Member
Author
|
bors merge |
Member
Author
|
This seems to have been merged without the PR being closed. Closing it now |
Ruben-VandeVelde
pushed a commit
that referenced
this pull request
Dec 7, 2022
Mathlib SHA f1a2caaf51ef593799107fe9a8d5e411599f3996 There were a bunch of changes from `toAntisymmetrization (. ≤ .)` to `@toAntisymmetrization α (· ≤ ·) _` and also the coercion to fun for `OrderIso.dualAntisymmetrization α` did not trigger without making `α` explicit, previously there was an underscore in place of `α` Co-authored-by: Gabriel Ebner <gebner@gebner.org>
bors bot
pushed a commit
to leanprover-community/mathlib3
that referenced
this pull request
Dec 8, 2022
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status). Relates to the following PRs: * `algebra.euclidean_domain.defs`: leanprover-community/mathlib4#871 * `algebra.group.ext`: leanprover-community/mathlib4#850 * `algebra.group_power.basic`: leanprover-community/mathlib4#874 * `algebra.hom.equiv.units.basic`: leanprover-community/mathlib4#895 * `algebra.hom.equiv.units.group_with_zero`: leanprover-community/mathlib4#901 * `algebra.order.group.instances`: leanprover-community/mathlib4#890 * `algebra.order.group.order_iso`: leanprover-community/mathlib4#895 * `algebra.order.group.units`: leanprover-community/mathlib4#898 * `algebra.order.monoid.nat_cast`: leanprover-community/mathlib4#893 * `algebra.order.monoid.type_tags`: leanprover-community/mathlib4#873 * `algebra.order.monoid.units`: leanprover-community/mathlib4#873 * `algebra.order.zero_le_one`: leanprover-community/mathlib4#893 * `combinatorics.quiver.push`: leanprover-community/mathlib4#868 * `control.traversable.basic`: leanprover-community/mathlib4#788 * `data.sum.order`: leanprover-community/mathlib4#880 * `group_theory.group_action.option`: leanprover-community/mathlib4#884 * `group_theory.group_action.sigma`: leanprover-community/mathlib4#885 * `group_theory.group_action.sum`: leanprover-community/mathlib4#882 * `group_theory.group_action.units`: leanprover-community/mathlib4#878 * `order.antisymmetrization`: leanprover-community/mathlib4#876
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mathlib SHA f1a2caaf51ef593799107fe9a8d5e411599f3996
There were a bunch of changes from
toAntisymmetrization (. ≤ .)to@toAntisymmetrization α (· ≤ ·) _and also the coercion to fun forOrderIso.dualAntisymmetrization αdid not trigger without makingαexplicit, previously there was an underscore in place ofα