[Merged by Bors] - feat: port Algebra.Group.Ext#850
Closed
Conversation
Member
|
Don't forget to update the porting notes! |
Member
|
bors merge |
Member
|
bors r- Let's update the porting notes to reflect the working version first |
|
✌️ rosborn can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
Author
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Dec 7, 2022
mathlib SHA: e574b1a4e891376b0ef974b926da39e05da12a06 Porting notes: 1. Constructing a `MonoidHom` (or `OneHom`) with ambiguous instances requires the use of the `mk` constructor and using `(_)` to disable the TC inference on the input type. 2. For the proofs of injectivity, I needed to destructure the instances further for the proofs to work. In the case of `CancelCommMonoid.toCommMonoid_injective`, I needed to nest `injection` tactics. Not sure if `injection` or `congr` should do these automatically. Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
bors bot
pushed a commit
to leanprover-community/mathlib3
that referenced
this pull request
Dec 8, 2022
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status). Relates to the following PRs: * `algebra.euclidean_domain.defs`: leanprover-community/mathlib4#871 * `algebra.group.ext`: leanprover-community/mathlib4#850 * `algebra.group_power.basic`: leanprover-community/mathlib4#874 * `algebra.hom.equiv.units.basic`: leanprover-community/mathlib4#895 * `algebra.hom.equiv.units.group_with_zero`: leanprover-community/mathlib4#901 * `algebra.order.group.instances`: leanprover-community/mathlib4#890 * `algebra.order.group.order_iso`: leanprover-community/mathlib4#895 * `algebra.order.group.units`: leanprover-community/mathlib4#898 * `algebra.order.monoid.nat_cast`: leanprover-community/mathlib4#893 * `algebra.order.monoid.type_tags`: leanprover-community/mathlib4#873 * `algebra.order.monoid.units`: leanprover-community/mathlib4#873 * `algebra.order.zero_le_one`: leanprover-community/mathlib4#893 * `combinatorics.quiver.push`: leanprover-community/mathlib4#868 * `control.traversable.basic`: leanprover-community/mathlib4#788 * `data.sum.order`: leanprover-community/mathlib4#880 * `group_theory.group_action.option`: leanprover-community/mathlib4#884 * `group_theory.group_action.sigma`: leanprover-community/mathlib4#885 * `group_theory.group_action.sum`: leanprover-community/mathlib4#882 * `group_theory.group_action.units`: leanprover-community/mathlib4#878 * `order.antisymmetrization`: leanprover-community/mathlib4#876
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mathlib SHA: e574b1a4e891376b0ef974b926da39e05da12a06
Porting notes:
MonoidHom(orOneHom) with ambiguous instances requires the use of themkconstructor and using(_)to disable the TC inference on the input type.CancelCommMonoid.toCommMonoid_injective, I needed to nestinjectiontactics. Not sure ifinjectionorcongrshould do these automatically.