[Merged by Bors] - feat: port Algebra.Order.Group.Instances#890
Closed
[Merged by Bors] - feat: port Algebra.Order.Group.Instances#890
Conversation
Member
|
I don't know the answer to the instance naming convention but just to note that when I ported Algebra.Group.WithOne.Defs I just changed the many Lean 3 instance names into the appropriate Lean 4 instance names and I didn't align anything :-( |
Contributor
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Dec 7, 2022
mathlib3 a95b16cbade0f938fc24abd05412bde1e84bab9b Porting notes: - cannibalizes the former ad-hoc port `Algebra/Order/Group` - a number of proofs were broken because of instance auto-naming differences between Lean 3 and Lean 4. I did not change such names, instead I corrected the instance-invocations-by-name in the place where they were used, and added `#align`s by the original instances so that mathport won't make the same mistake again. Is this the correct fix or should I do something different?
|
Pull request successfully merged into master. Build succeeded:
|
bors bot
pushed a commit
that referenced
this pull request
Dec 7, 2022
mathlib3 a95b16cbade0f938fc24abd05412bde1e84bab9b Porting notes: - the module docstring title in mathlib3 was incorrect (probably a relic of a hasty split), I have changed it here without backporting - one elaboration issue, see [Zulip](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/elaboration.20failure.20in.20algebra.2Eorder.2Egroup.2Eunits) - same issue with instance names as in #890, and I made the same choice about how to fix it
bors bot
pushed a commit
to leanprover-community/mathlib3
that referenced
this pull request
Dec 8, 2022
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status). Relates to the following PRs: * `algebra.euclidean_domain.defs`: leanprover-community/mathlib4#871 * `algebra.group.ext`: leanprover-community/mathlib4#850 * `algebra.group_power.basic`: leanprover-community/mathlib4#874 * `algebra.hom.equiv.units.basic`: leanprover-community/mathlib4#895 * `algebra.hom.equiv.units.group_with_zero`: leanprover-community/mathlib4#901 * `algebra.order.group.instances`: leanprover-community/mathlib4#890 * `algebra.order.group.order_iso`: leanprover-community/mathlib4#895 * `algebra.order.group.units`: leanprover-community/mathlib4#898 * `algebra.order.monoid.nat_cast`: leanprover-community/mathlib4#893 * `algebra.order.monoid.type_tags`: leanprover-community/mathlib4#873 * `algebra.order.monoid.units`: leanprover-community/mathlib4#873 * `algebra.order.zero_le_one`: leanprover-community/mathlib4#893 * `combinatorics.quiver.push`: leanprover-community/mathlib4#868 * `control.traversable.basic`: leanprover-community/mathlib4#788 * `data.sum.order`: leanprover-community/mathlib4#880 * `group_theory.group_action.option`: leanprover-community/mathlib4#884 * `group_theory.group_action.sigma`: leanprover-community/mathlib4#885 * `group_theory.group_action.sum`: leanprover-community/mathlib4#882 * `group_theory.group_action.units`: leanprover-community/mathlib4#878 * `order.antisymmetrization`: leanprover-community/mathlib4#876
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mathlib3 a95b16cbade0f938fc24abd05412bde1e84bab9b
Porting notes:
Algebra/Order/Group#aligns by the original instances so that mathport won't make the same mistake again. Is this the correct fix or should I do something different?