[Merged by Bors] - feat: computation of Levenshtein edit distance#6117
Closed
[Merged by Bors] - feat: computation of Levenshtein edit distance#6117
Conversation
This was referenced Jul 25, 2023
11 tasks
ocfnash
reviewed
Aug 2, 2023
eric-wieser
reviewed
Aug 10, 2023
eric-wieser
reviewed
Aug 10, 2023
eric-wieser
reviewed
Aug 10, 2023
eric-wieser
reviewed
Aug 10, 2023
Member
|
Thanks 🎉 bors merge |
eric-wieser
reviewed
Aug 14, 2023
Comment on lines
+282
to
+288
| #guard | ||
| (suffixLevenshtein Levenshtein.defaultCost "kitten".toList "sitting".toList).1 = | ||
| [3, 3, 4, 5, 6, 6, 7] | ||
|
|
||
| #guard levenshtein Levenshtein.defaultCost | ||
| "but our fish said, 'no! no!'".toList | ||
| "'put me down!' said the fish.".toList = 21 |
Member
There was a problem hiding this comment.
Should these be in a separate test file? Should we have a style guide that gives an opinion on this?
(no need to un-bors the PR, we can clean this type of thing up another time)
bors bot
pushed a commit
that referenced
this pull request
Aug 14, 2023
Subsequent PRs will prove properties of this definition, and implement the `rw_search` tactic using it. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
This PR was included in a batch that was canceled, it will be automatically retried |
bors bot
pushed a commit
that referenced
this pull request
Aug 14, 2023
Subsequent PRs will prove properties of this definition, and implement the `rw_search` tactic using it. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
bors bot
pushed a commit
that referenced
this pull request
Aug 14, 2023
Subsequent PRs will prove properties of this definition, and implement the `rw_search` tactic using it. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
bors bot
pushed a commit
that referenced
this pull request
Aug 14, 2023
Subsequent PRs will prove properties of this definition, and implement the `rw_search` tactic using it. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
bors bot
pushed a commit
that referenced
this pull request
Aug 14, 2023
Subsequent PRs will prove properties of this definition, and implement the `rw_search` tactic using it. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
bors bot
pushed a commit
that referenced
this pull request
Aug 14, 2023
Subsequent PRs will prove properties of this definition, and implement the `rw_search` tactic using it. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
bors bot
pushed a commit
that referenced
this pull request
Aug 14, 2023
Subsequent PRs will prove properties of this definition, and implement the `rw_search` tactic using it. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
bors bot
pushed a commit
that referenced
this pull request
Aug 14, 2023
Subsequent PRs will prove properties of this definition, and implement the `rw_search` tactic using it. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
bors bot
pushed a commit
that referenced
this pull request
Aug 14, 2023
Subsequent PRs will prove properties of this definition, and implement the `rw_search` tactic using it. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Canceled. |
eric-wieser
reviewed
Aug 14, 2023
Member
I pushed the four character fix, but wonder if the offending lemma should exist at all (see my comment above). |
This PR protects `Function.Commute`, so that it no longer clashes with `Commute` in the root namespace, as suggested by @j-loreaux in #6290.
… ≃ (Aᵐᵒᵖ ≃ₐ[R] B)` (#6525) This also adds the missing `AlgEquiv.equivCongr` as a more general version of `AlgEquiv.autCongr`.
…ar order (#6571) Currently, in a conditionally complete linear order, the supremum of an unbounded set hasn't any specific property. However, in all instances in mathlib, all unbounded sets have the same supremum. This PR adds this requirement in mathlib. This will be convenient to remove boundedness assumptions in measurability statements.
The main changes are: - we replace the data-bearing `PerfectRing` typeclass with a `Prop`-valued (non-constructive) version, - we introduce a new typeclass `PerfectField`, - we add a proof that a perfect field of positive characteristic has surjective Frobenius map, - we add some basic facts such as perfection of finite rings / fields and products of perfect rings.
Removing some linters and error codes that are not Lean 4 relevant Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Prove [Gershgorin circle theorem](https://en.wikipedia.org/wiki/Gershgorin_circle_theorem) and some applications that will be useful for the proof of Dirichlet's unit theorem #5960
… identities (#6139) Co-authored-by: michaellee94 <michael.a.rodrigues.lee@gmail.com> Co-authored-by: Oliver Nash <github@olivernash.org>
Member
|
@semorrison, it looks like you ran a rebase with the wrong arguments; can you revert the last few commits and try again? |
Contributor
Author
|
It was an automatic rebase, no arguments from me! :-) In any case, I'd already merged this branch up into all the dependent PRs before seeing this, so I think it's done now. I'll happily share the credit! |
Contributor
Author
|
bors merge |
Contributor
Author
|
bors seems to be confused on this one. bors r- |
Contributor
Author
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 16, 2023
Subsequent PRs will prove properties of this definition, and implement the `rw_search` tactic using it. Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Thomas Browning <tb65536@uw.edu> Co-authored-by: Chris Hughes <chrishughes24@gmail.com> Co-authored-by: Oliver Nash <github@olivernash.org> Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr> Co-authored-by: Alex J Best <alex.j.best@gmail.com> Co-authored-by: Xavier Roblot <46200072+xroblot@users.noreply.github.com> Co-authored-by: michaellee94 <michael_lee1@brown.edu>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
kim-em
added a commit
that referenced
this pull request
Aug 17, 2023
Subsequent PRs will prove properties of this definition, and implement the `rw_search` tactic using it. Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Thomas Browning <tb65536@uw.edu> Co-authored-by: Chris Hughes <chrishughes24@gmail.com> Co-authored-by: Oliver Nash <github@olivernash.org> Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr> Co-authored-by: Alex J Best <alex.j.best@gmail.com> Co-authored-by: Xavier Roblot <46200072+xroblot@users.noreply.github.com> Co-authored-by: michaellee94 <michael_lee1@brown.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subsequent PRs will prove properties of this definition, and implement the
rw_searchtactic using it.