[Merged by Bors] - feat: use junk value in the definition of conditionally complete linear order#6571
Closed
[Merged by Bors] - feat: use junk value in the definition of conditionally complete linear order#6571
Conversation
eric-wieser
reviewed
Aug 14, 2023
eric-wieser
reviewed
Aug 14, 2023
Comment on lines
+982
to
+986
| theorem csSup_of_not_bddAbove {s : Set α} (hs : ¬BddAbove s) : sSup s = sSup univ := | ||
| ConditionallyCompleteLinearOrder.csSup_of_not_bddAbove s hs | ||
|
|
||
| theorem csInf_of_not_bddBelow {s : Set α} (hs : ¬BddBelow s) : sInf s = sInf univ := | ||
| ConditionallyCompleteLinearOrder.csInf_of_not_bddBelow s hs |
Member
There was a problem hiding this comment.
Are there any other places in mathlib where these two lemmas can be used to simplify a proof?
Contributor
Author
There was a problem hiding this comment.
Yes, even to simplify statements. Coming later.
eric-wieser
approved these changes
Aug 14, 2023
Member
eric-wieser
left a comment
There was a problem hiding this comment.
bors d+
It's not clear to me whether this really gains much (maybe that's coming in a future PR), but the new fields in the typeclass are at worst harmless.
|
✌️ sgouezel can now approve this pull request. To approve and merge a pull request, simply reply with |
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Contributor
Author
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 14, 2023
…ar order (#6571) Currently, in a conditionally complete linear order, the supremum of an unbounded set hasn't any specific property. However, in all instances in mathlib, all unbounded sets have the same supremum. This PR adds this requirement in mathlib. This will be convenient to remove boundedness assumptions in measurability statements.
|
This PR was included in a batch that was canceled, it will be automatically retried |
bors bot
pushed a commit
that referenced
this pull request
Aug 14, 2023
…ar order (#6571) Currently, in a conditionally complete linear order, the supremum of an unbounded set hasn't any specific property. However, in all instances in mathlib, all unbounded sets have the same supremum. This PR adds this requirement in mathlib. This will be convenient to remove boundedness assumptions in measurability statements.
bors bot
pushed a commit
that referenced
this pull request
Aug 14, 2023
…ar order (#6571) Currently, in a conditionally complete linear order, the supremum of an unbounded set hasn't any specific property. However, in all instances in mathlib, all unbounded sets have the same supremum. This PR adds this requirement in mathlib. This will be convenient to remove boundedness assumptions in measurability statements.
bors bot
pushed a commit
that referenced
this pull request
Aug 14, 2023
…ar order (#6571) Currently, in a conditionally complete linear order, the supremum of an unbounded set hasn't any specific property. However, in all instances in mathlib, all unbounded sets have the same supremum. This PR adds this requirement in mathlib. This will be convenient to remove boundedness assumptions in measurability statements.
bors bot
pushed a commit
that referenced
this pull request
Aug 14, 2023
…ar order (#6571) Currently, in a conditionally complete linear order, the supremum of an unbounded set hasn't any specific property. However, in all instances in mathlib, all unbounded sets have the same supremum. This PR adds this requirement in mathlib. This will be convenient to remove boundedness assumptions in measurability statements.
bors bot
pushed a commit
that referenced
this pull request
Aug 14, 2023
…ar order (#6571) Currently, in a conditionally complete linear order, the supremum of an unbounded set hasn't any specific property. However, in all instances in mathlib, all unbounded sets have the same supremum. This PR adds this requirement in mathlib. This will be convenient to remove boundedness assumptions in measurability statements.
bors bot
pushed a commit
that referenced
this pull request
Aug 14, 2023
…ar order (#6571) Currently, in a conditionally complete linear order, the supremum of an unbounded set hasn't any specific property. However, in all instances in mathlib, all unbounded sets have the same supremum. This PR adds this requirement in mathlib. This will be convenient to remove boundedness assumptions in measurability statements.
bors bot
pushed a commit
that referenced
this pull request
Aug 14, 2023
…ar order (#6571) Currently, in a conditionally complete linear order, the supremum of an unbounded set hasn't any specific property. However, in all instances in mathlib, all unbounded sets have the same supremum. This PR adds this requirement in mathlib. This will be convenient to remove boundedness assumptions in measurability statements.
bors bot
pushed a commit
that referenced
this pull request
Aug 14, 2023
…ar order (#6571) Currently, in a conditionally complete linear order, the supremum of an unbounded set hasn't any specific property. However, in all instances in mathlib, all unbounded sets have the same supremum. This PR adds this requirement in mathlib. This will be convenient to remove boundedness assumptions in measurability statements.
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Aug 14, 2023
…ar order (#6571) Currently, in a conditionally complete linear order, the supremum of an unbounded set hasn't any specific property. However, in all instances in mathlib, all unbounded sets have the same supremum. This PR adds this requirement in mathlib. This will be convenient to remove boundedness assumptions in measurability statements.
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
kim-em
pushed a commit
that referenced
this pull request
Aug 15, 2023
…ar order (#6571) Currently, in a conditionally complete linear order, the supremum of an unbounded set hasn't any specific property. However, in all instances in mathlib, all unbounded sets have the same supremum. This PR adds this requirement in mathlib. This will be convenient to remove boundedness assumptions in measurability statements.
kim-em
pushed a commit
that referenced
this pull request
Aug 15, 2023
…ar order (#6571) Currently, in a conditionally complete linear order, the supremum of an unbounded set hasn't any specific property. However, in all instances in mathlib, all unbounded sets have the same supremum. This PR adds this requirement in mathlib. This will be convenient to remove boundedness assumptions in measurability statements.
kim-em
pushed a commit
that referenced
this pull request
Aug 15, 2023
…ar order (#6571) Currently, in a conditionally complete linear order, the supremum of an unbounded set hasn't any specific property. However, in all instances in mathlib, all unbounded sets have the same supremum. This PR adds this requirement in mathlib. This will be convenient to remove boundedness assumptions in measurability statements.
kim-em
pushed a commit
that referenced
this pull request
Aug 17, 2023
…ar order (#6571) Currently, in a conditionally complete linear order, the supremum of an unbounded set hasn't any specific property. However, in all instances in mathlib, all unbounded sets have the same supremum. This PR adds this requirement in mathlib. This will be convenient to remove boundedness assumptions in measurability statements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, in a conditionally complete linear order, the supremum of an unbounded set hasn't any specific property. However, in all instances in mathlib, all unbounded sets have the same supremum. This PR adds this requirement in mathlib. This will be convenient to remove boundedness assumptions in measurability statements.