[Merged by Bors] - feat: cleanup lint-style a bit#6549
Closed
[Merged by Bors] - feat: cleanup lint-style a bit#6549
Conversation
1 task
Ruben-VandeVelde
approved these changes
Aug 14, 2023
Contributor
Ruben-VandeVelde
left a comment
There was a problem hiding this comment.
Looks good to me
Contributor
|
While you're here, you might consider removing the "!" exception in |
Member
Author
nice catch thanks |
We should clean up this whole file at some point anyway.
Member
|
bors merge I figured that fixing up the place where someone cheated with a |
bors bot
pushed a commit
that referenced
this pull request
Aug 14, 2023
Removing some linters and error codes that are not Lean 4 relevant Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
kim-em
pushed a commit
that referenced
this pull request
Aug 15, 2023
Removing some linters and error codes that are not Lean 4 relevant Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
kim-em
pushed a commit
that referenced
this pull request
Aug 15, 2023
Removing some linters and error codes that are not Lean 4 relevant Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
kim-em
pushed a commit
that referenced
this pull request
Aug 15, 2023
Removing some linters and error codes that are not Lean 4 relevant Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
kim-em
pushed a commit
that referenced
this pull request
Aug 17, 2023
Removing some linters and error codes that are not Lean 4 relevant Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing some linters and error codes that are not Lean 4 relevant