Conversation
Contributor
|
Oof, this is a much worse diff than I expected. I thought that Lean would have trouble figuring out it needed |
Member
|
Would the diff be better if we used |
Member
|
To justify this change, are there any existing |
eric-wieser
approved these changes
Aug 14, 2023
Contributor
|
Thanks both! bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 14, 2023
This PR protects `Function.Commute`, so that it no longer clashes with `Commute` in the root namespace, as suggested by @j-loreaux in #6290.
|
This PR was included in a batch that was canceled, it will be automatically retried |
bors bot
pushed a commit
that referenced
this pull request
Aug 14, 2023
This PR protects `Function.Commute`, so that it no longer clashes with `Commute` in the root namespace, as suggested by @j-loreaux in #6290.
bors bot
pushed a commit
that referenced
this pull request
Aug 14, 2023
This PR protects `Function.Commute`, so that it no longer clashes with `Commute` in the root namespace, as suggested by @j-loreaux in #6290.
bors bot
pushed a commit
that referenced
this pull request
Aug 14, 2023
This PR protects `Function.Commute`, so that it no longer clashes with `Commute` in the root namespace, as suggested by @j-loreaux in #6290.
bors bot
pushed a commit
that referenced
this pull request
Aug 14, 2023
This PR protects `Function.Commute`, so that it no longer clashes with `Commute` in the root namespace, as suggested by @j-loreaux in #6290.
bors bot
pushed a commit
that referenced
this pull request
Aug 14, 2023
This PR protects `Function.Commute`, so that it no longer clashes with `Commute` in the root namespace, as suggested by @j-loreaux in #6290.
bors bot
pushed a commit
that referenced
this pull request
Aug 14, 2023
This PR protects `Function.Commute`, so that it no longer clashes with `Commute` in the root namespace, as suggested by @j-loreaux in #6290.
bors bot
pushed a commit
that referenced
this pull request
Aug 14, 2023
This PR protects `Function.Commute`, so that it no longer clashes with `Commute` in the root namespace, as suggested by @j-loreaux in #6290.
bors bot
pushed a commit
that referenced
this pull request
Aug 14, 2023
This PR protects `Function.Commute`, so that it no longer clashes with `Commute` in the root namespace, as suggested by @j-loreaux in #6290.
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Aug 14, 2023
This PR protects `Function.Commute`, so that it no longer clashes with `Commute` in the root namespace, as suggested by @j-loreaux in #6290.
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Function.CommuteFunction.Commute
kim-em
pushed a commit
that referenced
this pull request
Aug 15, 2023
This PR protects `Function.Commute`, so that it no longer clashes with `Commute` in the root namespace, as suggested by @j-loreaux in #6290.
kim-em
pushed a commit
that referenced
this pull request
Aug 15, 2023
This PR protects `Function.Commute`, so that it no longer clashes with `Commute` in the root namespace, as suggested by @j-loreaux in #6290.
kim-em
pushed a commit
that referenced
this pull request
Aug 15, 2023
This PR protects `Function.Commute`, so that it no longer clashes with `Commute` in the root namespace, as suggested by @j-loreaux in #6290.
kim-em
pushed a commit
that referenced
this pull request
Aug 17, 2023
This PR protects `Function.Commute`, so that it no longer clashes with `Commute` in the root namespace, as suggested by @j-loreaux in #6290.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR protects
Function.Commute, so that it no longer clashes withCommutein the root namespace, as suggested by @j-loreaux in #6290.