[Merged by Bors] - feat: port Order.RelClasses#560
Closed
[Merged by Bors] - feat: port Order.RelClasses#560
Conversation
TODO: decide on min/max alignment with mathlib3 Used the mathport3 output, with sparse proof copying from previous version
3 tasks
kim-em
reviewed
Nov 18, 2022
Mathlib/Order/RelClasses.lean
Outdated
Comment on lines
+457
to
+458
| -- TODO: How to align this? | ||
| -- it was `⟨measure_wf f⟩` before |
Contributor
Author
There was a problem hiding this comment.
Basically, the question is, in places where measure_wf f is used, now one would use (measure \.).wf. Ideally, that transformation is something that mathport can handle.
Contributor
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Nov 18, 2022
mathlib3 hash: fd47bdf09e90f553519c712378e651975fe8c829 - [x] depends on: #556 Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors bot
pushed a commit
that referenced
this pull request
Nov 18, 2022
mathlib3 hash: fd47bdf09e90f553519c712378e651975fe8c829 - [x] depends on: #567 - [x] depends on: #560 - [x] depends on: #569 Co-authored-by: Yakov Pechersky <ypechersky@treeline.bio> Co-authored-by: Vierkantor <vierkantor@vierkantor.com> Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mathlib3 hash: fd47bdf09e90f553519c712378e651975fe8c829
checked against mathlib3port using: