[Merged by Bors] - feat: port Order.Basic#556
Closed
Conversation
TODO: decide on min/max alignment with mathlib3 Used the mathport3 output, with sparse proof copying from previous version
1 task
2 tasks
Contributor
|
Can you explain the TODO in the PR description? What are the choices? |
Contributor
Author
|
Updated the description |
Contributor
|
Okay, I propose we backport the Lean 4 behaviour to Lean 3. Here's the PR: |
Contributor
|
Optionally wait until people have opinions on those PRs, but you can copy my changes in the mathlib PR here if you like. |
Contributor
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Nov 13, 2022
`min` and `max` defaults are now the same between lean3 and lean4, so porting proofs in the future should be easier.
|
Build failed: |
Contributor
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Nov 14, 2022
`min` and `max` defaults are now the same between lean3 and lean4, so porting proofs in the future should be easier. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Build failed: |
Contributor
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Nov 14, 2022
`min` and `max` defaults are now the same between lean3 and lean4, so porting proofs in the future should be easier. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors bot
pushed a commit
that referenced
this pull request
Nov 18, 2022
mathlib3 hash: fd47bdf09e90f553519c712378e651975fe8c829 - [x] depends on: #556 Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
bors bot
pushed a commit
that referenced
this pull request
Nov 18, 2022
mathlib3 hash: fd47bdf09e90f553519c712378e651975fe8c829 - [x] depends on: #556 - [x] depends on: #550 Co-authored-by: Yakov Pechersky <ypechersky@treeline.bio> Co-authored-by: Vierkantor <vierkantor@vierkantor.com> Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com> Co-authored-by: David Wärn <codwarn@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
minandmaxdefaults are now the same between lean3 and lean4, so porting proofs in the future should be easier.