Skip to content

[Merged by Bors] - feat: port Order.Max#567

Closed
pechersky wants to merge 76 commits intomasterfrom
pechersky/port-order-max
Closed

[Merged by Bors] - feat: port Order.Max#567
pechersky wants to merge 76 commits intomasterfrom
pechersky/port-order-max

Conversation

@pechersky
Copy link
Copy Markdown
Contributor

@pechersky pechersky commented Nov 11, 2022

mathlib3 hash: fd47bdf09e90f553519c712378e651975fe8c829


Checked the hash against recent mathlib3port via:

leanf=Order/Max.lean; diff Mathlib/$leanf ../mathlib3port/Mathbin/$leanf -y --suppress-common-lines | rg "(lemma|theorem|def)"

kim-em and others added 30 commits November 6, 2022 20:20
TODO: decide on min/max alignment with mathlib3
Used the mathport3 output, with sparse proof copying
from previous version
by calling out to root
There was a clash between PRs
@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Nov 18, 2022

bors merge

@bors
Copy link
Copy Markdown

bors bot commented Nov 18, 2022

👎 Rejected by label

@kim-em kim-em removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Nov 18, 2022
@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Nov 18, 2022

bors merge

bors bot pushed a commit that referenced this pull request Nov 18, 2022
mathlib3 hash: fd47bdf09e90f553519c712378e651975fe8c829

- [x] depends on: #566 
- [x] depends on: #562 



Co-authored-by: Yakov Pechersky <ypechersky@treeline.bio>
Co-authored-by: Vierkantor <vierkantor@vierkantor.com>
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
@bors
Copy link
Copy Markdown

bors bot commented Nov 18, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Order.Max [Merged by Bors] - feat: port Order.Max Nov 18, 2022
@bors bors bot closed this Nov 18, 2022
@bors bors bot deleted the pechersky/port-order-max branch November 18, 2022 04:23
bors bot pushed a commit that referenced this pull request Nov 18, 2022
mathlib3 hash: fd47bdf09e90f553519c712378e651975fe8c829

- [x] depends on: #567 
- [x] depends on: #560 
- [x] depends on: #569 



Co-authored-by: Yakov Pechersky <ypechersky@treeline.bio>
Co-authored-by: Vierkantor <vierkantor@vierkantor.com>
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mathlib-port This is a port of a theory file from mathlib.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants