Skip to content

[Merged by Bors] - feat: port mk_iff and mk_iff_of_inductive_prop#561

Closed
dwrensha wants to merge 17 commits intomasterfrom
mk-iffs
Closed

[Merged by Bors] - feat: port mk_iff and mk_iff_of_inductive_prop#561
dwrensha wants to merge 17 commits intomasterfrom
mk-iffs

Conversation

@dwrensha
Copy link
Copy Markdown
Member

@dwrensha dwrensha commented Nov 9, 2022

This is a direct translation of the mathlib3 version and its tests

@dwrensha dwrensha changed the title feat: [WORK IN PROGRESS] port mk_iff and mk_iff_of_inductive_prop feat: port mk_iff and mk_iff_of_inductive_prop Nov 9, 2022
@dwrensha dwrensha marked this pull request as ready for review November 9, 2022 22:00
@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Nov 13, 2022

bors merge

@bors
Copy link
Copy Markdown

bors bot commented Nov 13, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port mk_iff and mk_iff_of_inductive_prop [Merged by Bors] - feat: port mk_iff and mk_iff_of_inductive_prop Nov 13, 2022
@bors bors bot closed this Nov 13, 2022
@bors bors bot deleted the mk-iffs branch November 13, 2022 23:33
bors bot pushed a commit that referenced this pull request Nov 14, 2022
Some cleanup and documentation for #561.
bors bot pushed a commit that referenced this pull request Nov 16, 2022
mathlib3 sha: 5ca6e9d2bb25feeebdefe9bd9de163897bdecd05

Relatively straightforward.

Depends on ~~#559 (`EqvGen`)~~ and ~~#561 (`mk-iffs` attribute)~~

Co-authored-by: Vierkantor <vierkantor@vierkantor.com>
Co-authored-by: David Renshaw <dwrenshaw@gmail.com>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
bors bot pushed a commit that referenced this pull request Nov 23, 2022
This note was added in #560. Since then, `@[mk_iff]` was implemented in #561, and was added to `IsWellFounded` in #663.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants