Closed
Conversation
2 tasks
pechersky
reviewed
Nov 8, 2022
Member
|
Note that this PR crashes a linter, so we need help here. |
Contributor
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Nov 10, 2022
This is my first PR to mathlib4 so please check carefully! This PR ports `data.quot` and the definition of `eqv_gen` from core Lean 3. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Pull request successfully merged into master. Build succeeded:
|
bors bot
pushed a commit
that referenced
this pull request
Nov 16, 2022
mathlib3 sha: 5ca6e9d2bb25feeebdefe9bd9de163897bdecd05 Relatively straightforward. Depends on ~~#559 (`EqvGen`)~~ and ~~#561 (`mk-iffs` attribute)~~ Co-authored-by: Vierkantor <vierkantor@vierkantor.com> Co-authored-by: David Renshaw <dwrenshaw@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
bors bot
pushed a commit
that referenced
this pull request
Nov 18, 2022
mathlib3 sha: 7951ed37deb3b2923a6f47d9bdcb4d69a8703550 ~~Waiting on the release of [nightly-2022-11-17](https://github.com/leanprover/lean4-nightly/releases/tag/nightly-2022-11-17).~~ - [x] depends on: #541 - [x] depends on: #559 Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Vierkantor <vierkantor@vierkantor.com> Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com> Co-authored-by: David Wärn <codwarn@gmail.com> Co-authored-by: Yakov Pechersky <ypechersky@treeline.bio> Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
kmill
reviewed
May 24, 2023
| variable {φ : Quotient sa → Quotient sb → Sort _} | ||
|
|
||
| @[inherit_doc] | ||
| notation:arg "⟦" a "⟧" => Quotient.mk _ a |
Contributor
There was a problem hiding this comment.
Did you mean to change the meaning of this notation from mathlib3? It used to use what's now called Quotient.mk', which takes the setoid as an instance argument, but this notation now only works if it can get the setoid instance from the expected type.
Contributor
Author
There was a problem hiding this comment.
I recall changing some Quotient.mk's to mks because instance inference didn't work well (at least, back then). Perhaps now it is safe to turn it into mk' again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first PR to mathlib4 so please check carefully!
This PR ports
data.quotand the definition ofeqv_genfrom core Lean 3.