Conversation
2 tasks
Contributor
|
Going through a few reviews at the moment, and then I'll take a look at this and #550 :) |
Vierkantor
approved these changes
Nov 8, 2022
Contributor
Vierkantor
left a comment
There was a problem hiding this comment.
With my current knowledge of Lean 4 I think this port in good shape, and it seems to work well for equiv, but I'm sure we'll run into some annoying detail once we get into more complicated stuff like semilinear_map_class.
Member
|
I've added a commit which registers bors d+ |
|
✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
Author
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Nov 10, 2022
This is a very naive port of `data.fun_like`. I've never really engaged with this classes in mathlib3, and I haven't attempted to think about how they might work in Lean 4... This PR is really just provocation, hoping that @Vierkantor may come and have a look. :-) Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Vierkantor <vierkantor@vierkantor.com> Co-authored-by: Gabriel Ebner <gebner@gebner.org>
|
Pull request successfully merged into master. Build succeeded: |
bors bot
pushed a commit
that referenced
this pull request
Nov 18, 2022
mathlib3 sha: 7951ed37deb3b2923a6f47d9bdcb4d69a8703550 ~~Waiting on the release of [nightly-2022-11-17](https://github.com/leanprover/lean4-nightly/releases/tag/nightly-2022-11-17).~~ - [x] depends on: #541 - [x] depends on: #559 Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Vierkantor <vierkantor@vierkantor.com> Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com> Co-authored-by: David Wärn <codwarn@gmail.com> Co-authored-by: Yakov Pechersky <ypechersky@treeline.bio> Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a very naive port of
data.fun_like. I've never really engaged with this classes in mathlib3, and I haven't attempted to think about how they might work in Lean 4...This PR is really just provocation, hoping that @Vierkantor may come and have a look. :-)