[Merged by Bors] - feat(RingTheory): decompose archimedean classes of HahnSeries#25970
Closed
wwylele wants to merge 8 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - feat(RingTheory): decompose archimedean classes of HahnSeries#25970wwylele wants to merge 8 commits intoleanprover-community:masterfrom
wwylele wants to merge 8 commits intoleanprover-community:masterfrom
Conversation
PR summary 8bb991a4a0Import changes exceeding 2%
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.RingTheory.HahnSeries.Lex | 780 | 900 | +120 (+15.38%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.RingTheory.HahnSeries.Lex |
120 |
Declarations diff
+ abs_lt_abs_of_orderTop_ofLex
+ archimedeanClassMk_eq_archimedeanClassMk_iff
+ archimedeanClassMk_le_archimedeanClassMk_iff
+ archimedeanClassMk_le_archimedeanClassMk_iff_of_orderTop_ofLex
+ archimedeanClassOrderIsoWithTop
+ archimedeanClassOrderIsoWithTop_apply
+ finiteArchimedeanClassOrderHomInvLex
+ finiteArchimedeanClassOrderHomLex
+ finiteArchimedeanClassOrderIso
+ finiteArchimedeanClassOrderIsoLex
+ finiteArchimedeanClassOrderIsoLex_apply_fst
+ finiteArchimedeanClassOrderIsoLex_apply_snd
+ finiteArchimedeanClassOrderIso_apply
+ toLex_eq_one
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
Collaborator
Author
|
I realized recent updates from master caused conflicts, so I took this chance to separate out a small PR: #26773 |
Collaborator
|
This pull request has conflicts, please merge |
fecfbf1 to
0bd0d80
Compare
Collaborator
|
This pull request has conflicts, please merge |
0bd0d80 to
0248a0b
Compare
847c366 to
e34ba34
Compare
7 tasks
Collaborator
Author
|
Thanks @YaelDillies , and I did some more clean up after merging |
Collaborator
pfaffelh
pushed a commit
to pfaffelh/mathlib4
that referenced
this pull request
Aug 20, 2025
…unity#28394) Separated from leanprover-community#25970. This adds a subtype of (Mul)ArchimedeanClass that is useful in formalizing Hahn embedding theorem. The only code change since last review was doc string update for `to_additive`
YaelDillies
reviewed
Aug 20, 2025
YaelDillies
approved these changes
Aug 22, 2025
Contributor
YaelDillies
left a comment
There was a problem hiding this comment.
Thanks!
maintainer delegate
Comment on lines
+300
to
+302
| · ext x | ||
| cases x with | h x | ||
| obtain ⟨order, coeff⟩ := x |
Contributor
There was a problem hiding this comment.
This really ought to work, but it doesn't because Lex is too see-through...
Suggested change
| · ext x | |
| cases x with | h x | |
| obtain ⟨order, coeff⟩ := x | |
| · ext ⟨order, coeff⟩ |
Collaborator
Author
There was a problem hiding this comment.
Yeah I tried a few variation of this but coundn't make it work. I am going to merge this as-is
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
Paul-Lez
pushed a commit
to Paul-Lez/mathlib4
that referenced
this pull request
Aug 23, 2025
Paul-Lez
pushed a commit
to Paul-Lez/mathlib4
that referenced
this pull request
Aug 23, 2025
…unity#28394) Separated from leanprover-community#25970. This adds a subtype of (Mul)ArchimedeanClass that is useful in formalizing Hahn embedding theorem. The only code change since last review was doc string update for `to_additive`
pechersky
pushed a commit
to pechersky/mathlib4
that referenced
this pull request
Aug 25, 2025
pechersky
pushed a commit
to pechersky/mathlib4
that referenced
this pull request
Aug 25, 2025
…unity#28394) Separated from leanprover-community#25970. This adds a subtype of (Mul)ArchimedeanClass that is useful in formalizing Hahn embedding theorem. The only code change since last review was doc string update for `to_additive`
Member
|
Thanks! bors d+ |
Contributor
|
✌️ wwylele can now approve this pull request. To approve and merge a pull request, simply reply with |
Collaborator
Author
|
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Aug 26, 2025
In preparation for #25140, this connects archimedean class and HahnSeries Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Contributor
|
This PR was included in a batch that was canceled, it will be automatically retried |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Aug 26, 2025
In preparation for #25140, this connects archimedean class and HahnSeries Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
FormulaRabbit81
pushed a commit
to YaelDillies/mathlib4
that referenced
this pull request
Aug 30, 2025
…over-community#25970) In preparation for leanprover-community#25140, this connects archimedean class and HahnSeries Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for #25140, this connects archimedean class and HahnSeries