[Merged by Bors] - feat(Algebra/Order): add Finite(Mul)ArchimedeanClass#28394
Closed
wwylele wants to merge 14 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - feat(Algebra/Order): add Finite(Mul)ArchimedeanClass#28394wwylele wants to merge 14 commits intoleanprover-community:masterfrom
wwylele wants to merge 14 commits intoleanprover-community:masterfrom
Conversation
7 tasks
PR summary 45e60eb5ad
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Algebra.Order.Archimedean.Class | 760 | 761 | +1 (+0.13%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.Algebra.Order.Archimedean.Class |
1 |
Declarations diff
+ FiniteMulArchimedeanClass
+ ind
+ instance [MulArchimedean M] : Subsingleton (FiniteMulArchimedeanClass M)
+ instance [Nontrivial M] : Nonempty (FiniteMulArchimedeanClass M) := by
+ lift
+ liftOrderHom
+ liftOrderHom_mk
+ lift_mk
+ mk
+ mk_le_mk
+ mk_lt_mk
+ val_mk
+ withTopOrderIso
+ withTopOrderIso_apply_coe
+ withTopOrderIso_symm_apply
+ «forall»
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
YaelDillies
reviewed
Aug 14, 2025
Contributor
YaelDillies
left a comment
There was a problem hiding this comment.
Thanks for splitting!
b0014fa to
21ac1ab
Compare
YaelDillies
reviewed
Aug 14, 2025
YaelDillies
approved these changes
Aug 14, 2025
Contributor
YaelDillies
left a comment
There was a problem hiding this comment.
Thanks!
maintainer delegate
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
wwylele
commented
Aug 14, 2025
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
c31ee49 to
3537a15
Compare
Collaborator
Author
|
Small changes since YaelDillies's review on 0d83c45:
|
Contributor
|
✌️ wwylele can now approve this pull request. To approve and merge a pull request, simply reply with |
alreadydone
reviewed
Aug 18, 2025
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
wwylele
commented
Aug 18, 2025
wwylele
commented
Aug 18, 2025
Collaborator
Author
|
Looks like I got hit by cache issue again... let me just try merging? bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Aug 18, 2025
Separated from #25970. This adds a subtype of (Mul)ArchimedeanClass that is useful in formalizing Hahn embedding theorem. The only code change since last review was doc string update for `to_additive`
Contributor
|
Pull request successfully merged into master. Build succeeded: |
pfaffelh
pushed a commit
to pfaffelh/mathlib4
that referenced
this pull request
Aug 20, 2025
…unity#28394) Separated from leanprover-community#25970. This adds a subtype of (Mul)ArchimedeanClass that is useful in formalizing Hahn embedding theorem. The only code change since last review was doc string update for `to_additive`
Paul-Lez
pushed a commit
to Paul-Lez/mathlib4
that referenced
this pull request
Aug 23, 2025
…unity#28394) Separated from leanprover-community#25970. This adds a subtype of (Mul)ArchimedeanClass that is useful in formalizing Hahn embedding theorem. The only code change since last review was doc string update for `to_additive`
pechersky
pushed a commit
to pechersky/mathlib4
that referenced
this pull request
Aug 25, 2025
…unity#28394) Separated from leanprover-community#25970. This adds a subtype of (Mul)ArchimedeanClass that is useful in formalizing Hahn embedding theorem. The only code change since last review was doc string update for `to_additive`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separated from #25970. This adds a subtype of (Mul)ArchimedeanClass that is useful in formalizing Hahn embedding theorem.
The only code change since last review was doc string update for
to_additive