Skip to content

[Merged by Bors] - chore(HahnSeries): make more usable, golf#28632

Closed
YaelDillies wants to merge 5 commits intoleanprover-community:masterfrom
YaelDillies:golf_hahn_series
Closed

[Merged by Bors] - chore(HahnSeries): make more usable, golf#28632
YaelDillies wants to merge 5 commits intoleanprover-community:masterfrom
YaelDillies:golf_hahn_series

Conversation

@YaelDillies
Copy link
Copy Markdown
Contributor

A lot of lemmas were misnamed or the wrong way around.


Open in Gitpod

A lot of lemmas were misnamed or the wrong way around.
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 19, 2025

PR summary 9411739906

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ leadingCoeff_eq_zero
+ leadingCoeff_ne_zero
+ leadingCoeff_of_ne_zero
+ ofLex_eq_one
+ orderTop_eq_top
+ orderTop_lt_top
+ orderTop_ne_top
+ orderTop_of_ne_zero
+ orderTop_of_subsingleton
+ order_eq_orderTop_of_ne_zero

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@YaelDillies YaelDillies added the t-ring-theory Ring theory label Aug 19, 2025
@bryangingechen
Copy link
Copy Markdown
Contributor

Thanks!
bors r+

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Aug 19, 2025
mathlib-bors bot pushed a commit that referenced this pull request Aug 19, 2025
A lot of lemmas were misnamed or the wrong way around.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Aug 20, 2025

Pull request successfully merged into master.

Build succeeded:

  • CI Success

@mathlib-bors mathlib-bors bot changed the title chore(HahnSeries): make more usable, golf [Merged by Bors] - chore(HahnSeries): make more usable, golf Aug 20, 2025
@mathlib-bors mathlib-bors bot closed this Aug 20, 2025
@YaelDillies YaelDillies deleted the golf_hahn_series branch August 20, 2025 05:32
pfaffelh pushed a commit to pfaffelh/mathlib4 that referenced this pull request Aug 20, 2025
A lot of lemmas were misnamed or the wrong way around.
Paul-Lez pushed a commit to Paul-Lez/mathlib4 that referenced this pull request Aug 23, 2025
A lot of lemmas were misnamed or the wrong way around.
pechersky pushed a commit to pechersky/mathlib4 that referenced this pull request Aug 25, 2025
A lot of lemmas were misnamed or the wrong way around.
pfaffelh pushed a commit to pfaffelh/mathlib4 that referenced this pull request Jan 9, 2026
A lot of lemmas were misnamed or the wrong way around.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants