Skip to content

[Merged by Bors] - feat(Order): orderIso for degenerate Lex prod#26773

Closed
wwylele wants to merge 4 commits intoleanprover-community:masterfrom
wwylele:prod-lex
Closed

[Merged by Bors] - feat(Order): orderIso for degenerate Lex prod#26773
wwylele wants to merge 4 commits intoleanprover-community:masterfrom
wwylele:prod-lex

Conversation

@wwylele
Copy link
Copy Markdown
Collaborator

@wwylele wwylele commented Jul 5, 2025


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 5, 2025

PR summary 0f3d46263d

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Order.Hom.Lex 252 253 +1 (+0.40%)
Import changes for all files
Files Import difference
Mathlib.Order.Hom.Lex 1

Declarations diff

+ prodUnique
+ prodUnique_apply
+ uniqueProd
+ uniqueProd_apply

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-order Order theory label Jul 5, 2025
@bryangingechen bryangingechen changed the title feature(Order): orderIso for degenerated Lex prod feature(Order): orderIso for degenerate Lex prod Jul 5, 2025
Copy link
Copy Markdown
Contributor

@bryangingechen bryangingechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM. Thanks!
bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jul 5, 2025

✌️ wwylele can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Jul 5, 2025
@bryangingechen bryangingechen changed the title feature(Order): orderIso for degenerate Lex prod feat(Order): orderIso for degenerate Lex prod Jul 5, 2025
wwylele and others added 3 commits July 4, 2025 23:26
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
@wwylele
Copy link
Copy Markdown
Collaborator Author

wwylele commented Jul 5, 2025

bors r+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jul 5, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Order): orderIso for degenerate Lex prod [Merged by Bors] - feat(Order): orderIso for degenerate Lex prod Jul 5, 2025
@mathlib-bors mathlib-bors bot closed this Jul 5, 2025
joelriou pushed a commit to joelriou/mathlib4 that referenced this pull request Jul 7, 2025
callesonne pushed a commit to callesonne/mathlib4 that referenced this pull request Jul 24, 2025
hrmacbeth pushed a commit to szqzs/mathlib4 that referenced this pull request Jul 28, 2025
@wwylele wwylele deleted the prod-lex branch September 2, 2025 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-order Order theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants