Skip to content

[Merged by Bors] - feat: preserve draft status when migrating PRs to fork#25777

Closed
kim-em wants to merge 2 commits intoleanprover-community:masterfrom
kim-em:preserve-draft-status-migration
Closed

[Merged by Bors] - feat: preserve draft status when migrating PRs to fork#25777
kim-em wants to merge 2 commits intoleanprover-community:masterfrom
kim-em:preserve-draft-status-migration

Conversation

@kim-em
Copy link
Copy Markdown
Contributor

@kim-em kim-em commented Jun 12, 2025

This PR enhances the fork migration script to preserve the draft status of PRs during migration. When contributors migrate from direct write access to fork workflow, maintaining the draft status ensures work-in-progress PRs remain properly marked as drafts with no disruption to existing workflows.

(AI generated.)

…field to JSON query in find_existing_pr() - Display draft status in PR discovery messages - Preserve draft status when creating new PR from fork - Add --draft flag to gh pr create when original PR was draft This ensures that when migrating from direct write access to fork workflow, the draft status of PRs is maintained across the migration.
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 12, 2025

PR summary e7547d8c1b

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mattrobball
Copy link
Copy Markdown
Contributor

Please test and then send it off.

bors delegate+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jun 12, 2025

✌️ kim-em can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Jun 12, 2025
… add robust error handling for fork sync failures
@kim-em
Copy link
Copy Markdown
Contributor Author

kim-em commented Jun 12, 2025

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Jun 12, 2025
mathlib-bors bot pushed a commit that referenced this pull request Jun 12, 2025
This PR enhances the fork migration script to preserve the draft status of PRs during migration. When contributors migrate from direct write access to fork workflow, maintaining the draft status ensures work-in-progress PRs remain properly marked as drafts with no disruption to existing workflows.

(AI generated.)
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jun 12, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: preserve draft status when migrating PRs to fork [Merged by Bors] - feat: preserve draft status when migrating PRs to fork Jun 12, 2025
@mathlib-bors mathlib-bors bot closed this Jun 12, 2025
vlad902 added a commit to vlad902/mathlib4 that referenced this pull request Jun 12, 2025
* master: (447 commits)
  chore(Data/Set): move very basic lemmas earlier (leanprover-community#25707)
  feat: preserve draft status when migrating PRs to fork (leanprover-community#25777)
  chore(Data/Set/Basic): deprecate lemmas that abuse the `Set α := α → Prop` defeq (leanprover-community#25669)
  refactor: redefine `ProperCone` as an `abbrev` for `ClosedSubmodule` (leanprover-community#25204)
  feat: interaction between ContinuousLinearMap.coprod and ContinuousLinearEquiv.prodComm (leanprover-community#25564)
  fix: outdated docstring (leanprover-community#25717)
  feat(MeasureTheory): convolution of measures with densities  (leanprover-community#25718)
  feat: make sure that the simp normal form of equiv-like classes pushes `symm` and `trans` to the right (leanprover-community#25604)
  feat(ModelTheory): Formula.iSup and iInf (leanprover-community#21948)
  feat(RingTheory/Polynomial/ContentIdeal): the content ideal of a polynomial. (leanprover-community#25333)
  fix: typo in labels_from_comment.yml (leanprover-community#25727)
  feat: is{Inducing,Embedding}_prodMkLeft (leanprover-community#25705)
  feat: check that the mathlib options exist (leanprover-community#25687)
  feat(Algebra/Group/Even): Add missing lemmas (leanprover-community#20818)
  refactor: make `Matrix.kroneckerTMulAlgEquiv` heterogeneous (leanprover-community#25693)
  feat: allow contributors to remove labels with comments (leanprover-community#25723)
  chore: disable build.yml and bors.yml on forks (leanprover-community#25722)
  feat: improvements to user_activity_report.py (leanprover-community#25721)
  chore: update the migration script to check for necessary permissions and prefer ssh if possible (leanprover-community#25701)
  chore: update the migration script to check for necessary permissions and prefer ssh if possible (leanprover-community#25701)
  ...
pfaffelh pushed a commit to pfaffelh/mathlib4 that referenced this pull request Jun 15, 2025
…mmunity#25777)

This PR enhances the fork migration script to preserve the draft status of PRs during migration. When contributors migrate from direct write access to fork workflow, maintaining the draft status ensures work-in-progress PRs remain properly marked as drafts with no disruption to existing workflows.

(AI generated.)
pfaffelh pushed a commit to pfaffelh/mathlib4 that referenced this pull request Jun 15, 2025
…mmunity#25777)

This PR enhances the fork migration script to preserve the draft status of PRs during migration. When contributors migrate from direct write access to fork workflow, maintaining the draft status ensures work-in-progress PRs remain properly marked as drafts with no disruption to existing workflows.

(AI generated.)
callesonne pushed a commit to callesonne/mathlib4 that referenced this pull request Jul 24, 2025
…mmunity#25777)

This PR enhances the fork migration script to preserve the draft status of PRs during migration. When contributors migrate from direct write access to fork workflow, maintaining the draft status ensures work-in-progress PRs remain properly marked as drafts with no disruption to existing workflows.

(AI generated.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants