Skip to content

[Merged by Bors] - feat: allow contributors to remove labels with comments#25723

Closed
bryangingechen wants to merge 1 commit intoleanprover-community:masterfrom
bryangingechen:bgc-remove-labels-from-comment
Closed

[Merged by Bors] - feat: allow contributors to remove labels with comments#25723
bryangingechen wants to merge 1 commit intoleanprover-community:masterfrom
bryangingechen:bgc-remove-labels-from-comment

Conversation

@bryangingechen
Copy link
Copy Markdown
Contributor

Currently contributors can add the awaiting-author and WIP labels via comments, but they cannot remove them. This adds that functionality to our workflow.


Question: are there other labels that authors will need to be able to manipulate?

@bryangingechen bryangingechen added the CI Modifies the continuous integration setup or other automation label Jun 12, 2025
@github-actions
Copy link
Copy Markdown

PR summary 6864493fab

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@jcommelin
Copy link
Copy Markdown
Member

Thanks 🎉

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Jun 12, 2025
mathlib-bors bot pushed a commit that referenced this pull request Jun 12, 2025
Currently contributors can **add** the awaiting-author and WIP labels via comments, but they cannot remove them. This adds that functionality to our workflow.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jun 12, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: allow contributors to remove labels with comments [Merged by Bors] - feat: allow contributors to remove labels with comments Jun 12, 2025
@mathlib-bors mathlib-bors bot closed this Jun 12, 2025
vlad902 added a commit to vlad902/mathlib4 that referenced this pull request Jun 12, 2025
* master: (447 commits)
  chore(Data/Set): move very basic lemmas earlier (leanprover-community#25707)
  feat: preserve draft status when migrating PRs to fork (leanprover-community#25777)
  chore(Data/Set/Basic): deprecate lemmas that abuse the `Set α := α → Prop` defeq (leanprover-community#25669)
  refactor: redefine `ProperCone` as an `abbrev` for `ClosedSubmodule` (leanprover-community#25204)
  feat: interaction between ContinuousLinearMap.coprod and ContinuousLinearEquiv.prodComm (leanprover-community#25564)
  fix: outdated docstring (leanprover-community#25717)
  feat(MeasureTheory): convolution of measures with densities  (leanprover-community#25718)
  feat: make sure that the simp normal form of equiv-like classes pushes `symm` and `trans` to the right (leanprover-community#25604)
  feat(ModelTheory): Formula.iSup and iInf (leanprover-community#21948)
  feat(RingTheory/Polynomial/ContentIdeal): the content ideal of a polynomial. (leanprover-community#25333)
  fix: typo in labels_from_comment.yml (leanprover-community#25727)
  feat: is{Inducing,Embedding}_prodMkLeft (leanprover-community#25705)
  feat: check that the mathlib options exist (leanprover-community#25687)
  feat(Algebra/Group/Even): Add missing lemmas (leanprover-community#20818)
  refactor: make `Matrix.kroneckerTMulAlgEquiv` heterogeneous (leanprover-community#25693)
  feat: allow contributors to remove labels with comments (leanprover-community#25723)
  chore: disable build.yml and bors.yml on forks (leanprover-community#25722)
  feat: improvements to user_activity_report.py (leanprover-community#25721)
  chore: update the migration script to check for necessary permissions and prefer ssh if possible (leanprover-community#25701)
  chore: update the migration script to check for necessary permissions and prefer ssh if possible (leanprover-community#25701)
  ...
pfaffelh pushed a commit to pfaffelh/mathlib4 that referenced this pull request Jun 15, 2025
…ommunity#25723)

Currently contributors can **add** the awaiting-author and WIP labels via comments, but they cannot remove them. This adds that functionality to our workflow.
pfaffelh pushed a commit to pfaffelh/mathlib4 that referenced this pull request Jun 15, 2025
…ommunity#25723)

Currently contributors can **add** the awaiting-author and WIP labels via comments, but they cannot remove them. This adds that functionality to our workflow.
callesonne pushed a commit to callesonne/mathlib4 that referenced this pull request Jul 24, 2025
…ommunity#25723)

Currently contributors can **add** the awaiting-author and WIP labels via comments, but they cannot remove them. This adds that functionality to our workflow.
@bryangingechen bryangingechen deleted the bgc-remove-labels-from-comment branch August 20, 2025 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Modifies the continuous integration setup or other automation ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants