[Merged by Bors] - chore(Data/Set/Basic): deprecate lemmas that abuse the `Set α := α → Prop` defeq by YaelDillies · Pull Request #25669 · leanprover-community/mathlib4

YaelDillies · 2025-06-10T16:15:55Z

github-actions · 2025-06-10T16:17:09Z

PR summary 8024e6939a

Import changes for modified files

No significant changes to the import graph

Import changes for all files

Files	Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows

## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary

The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Mathlib/Data/Set/Basic.lean

Mathlib/FieldTheory/AxGrothendieck.lean

Mathlib/Topology/OmegaCompletePartialOrder.lean

Mathlib/Data/Set/Basic.lean

Vierkantor · 2025-06-11T09:43:09Z

Mathlib/FieldTheory/AxGrothendieck.lean

@@ -152,13 +152,15 @@ theorem realize_genericPolyMapSurjOnOfInjOn
      S.InjOn f ↔ ∀ x y, x ∈ S → y ∈ S → f x = f y → x = y := by
    simp [Set.InjOn]; tauto
  simp only [Sentence.Realize, Formula.Realize, genericPolyMapSurjOnOfInjOn, Formula.relabel,


(Oof, this is way too huge of a simp only. That goes on my tech debt todo list.)

…Prop` defeq

alreadydone · 2025-06-11T10:30:50Z

Thanks for the PR! I've observed that when you apply defs involving Sets (example) to Subtypes, the set found by unification will actually be a predicate, so the lemmas deprecated in this PR becomes applicable. I haven't checked whether this issue contribute to the lengthening of some proofs in this PR. Is there a good way to solve this issue, maybe through some unification hint that inserts the setOf?

Co-authored-by: Eric Wieser <wieser.eric@gmail.com>

YaelDillies · 2025-06-11T11:16:11Z

I haven't checked whether this issue contribute to the lengthening of some proofs in this PR

What proofs that get longer do you have in mind? I think all changes in the diff right now are unambiguously improvements, except possibly
https://github.com/leanprover-community/mathlib4/pull/25669/files#diff-d3b8a65b336e621c5039606dc97cab4075b404f6559aedbbdb102e2d9288958eL369-R369
which is pretty minor anyway.

I've observed that when you apply defs involving Sets (example) to Subtypes, the set found by unification will actually be a predicate, so the lemmas deprecated in this PR becomes applicable

↥s is defined as {x // x ∈ s}, not {x // s x}, so everything is fine and the lemmas I am deleting do not apply.

Here's the criterion to decide whether some downstream proof is affected by the current PR: "Does making Set α a one-field structure break the proof?". Equiv.setCongr doesn't break if one does that, therefore it isn't affected.

Vierkantor

Looks good to me with Eric's suggestion.

bors d+

mathlib-bors · 2025-06-12T09:32:50Z

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

YaelDillies · 2025-06-12T09:49:40Z

bors merge

…Prop` defeq (#25669)

mathlib-bors · 2025-06-12T10:15:59Z

Build failed (retrying...):

CI Success

…Prop` defeq (#25669)

mathlib-bors · 2025-06-12T11:25:01Z

Pull request successfully merged into master.

Build succeeded:

CI Success

* master: (447 commits) chore(Data/Set): move very basic lemmas earlier (leanprover-community#25707) feat: preserve draft status when migrating PRs to fork (leanprover-community#25777) chore(Data/Set/Basic): deprecate lemmas that abuse the `Set α := α → Prop` defeq (leanprover-community#25669) refactor: redefine `ProperCone` as an `abbrev` for `ClosedSubmodule` (leanprover-community#25204) feat: interaction between ContinuousLinearMap.coprod and ContinuousLinearEquiv.prodComm (leanprover-community#25564) fix: outdated docstring (leanprover-community#25717) feat(MeasureTheory): convolution of measures with densities (leanprover-community#25718) feat: make sure that the simp normal form of equiv-like classes pushes `symm` and `trans` to the right (leanprover-community#25604) feat(ModelTheory): Formula.iSup and iInf (leanprover-community#21948) feat(RingTheory/Polynomial/ContentIdeal): the content ideal of a polynomial. (leanprover-community#25333) fix: typo in labels_from_comment.yml (leanprover-community#25727) feat: is{Inducing,Embedding}_prodMkLeft (leanprover-community#25705) feat: check that the mathlib options exist (leanprover-community#25687) feat(Algebra/Group/Even): Add missing lemmas (leanprover-community#20818) refactor: make `Matrix.kroneckerTMulAlgEquiv` heterogeneous (leanprover-community#25693) feat: allow contributors to remove labels with comments (leanprover-community#25723) chore: disable build.yml and bors.yml on forks (leanprover-community#25722) feat: improvements to user_activity_report.py (leanprover-community#25721) chore: update the migration script to check for necessary permissions and prefer ssh if possible (leanprover-community#25701) chore: update the migration script to check for necessary permissions and prefer ssh if possible (leanprover-community#25701) ...

alreadydone · 2025-06-12T19:03:25Z

What proofs that get longer do you have in mind?

I was referring to this comment but you've fixed it. I did confuse myself a bit when I wrote my previous comment, and I'm sorry for that. I realized that when dealing with Subtype that is not CoeSort of Set, I should use e.g. Equiv.subtypeEquivProp and Homeomorph.subtype instead of Equiv.setCongr and Homeomorph.setCongr. I recall that in some cases the Subtype version is missing and the Set version gets used in other decls about Subtype, resulting in the unification issue I described when trying to use those decls, but I don't have an example right now.

…Prop` defeq (leanprover-community#25669)

YaelDillies requested a review from eric-wieser June 10, 2025 16:16

eric-wieser reviewed Jun 10, 2025

View reviewed changes

Mathlib/Data/Set/Basic.lean Show resolved Hide resolved

YaelDillies force-pushed the deprecate_set_aubuse branch from 36306f9 to 0e5e4a7 Compare June 10, 2025 16:35

b-mehta added the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jun 10, 2025

YaelDillies added the t-data Data (lists, quotients, numbers, etc) label Jun 11, 2025

YaelDillies mentioned this pull request Jun 11, 2025

[Merged by Bors] - feat(Algebra/Group/Even): Add missing lemmas #20818

Closed

1 task

eric-wieser reviewed Jun 11, 2025

View reviewed changes

Mathlib/FieldTheory/AxGrothendieck.lean Outdated Show resolved Hide resolved

eric-wieser reviewed Jun 11, 2025

View reviewed changes

Mathlib/Topology/OmegaCompletePartialOrder.lean Outdated Show resolved Hide resolved

eric-wieser reviewed Jun 11, 2025

View reviewed changes

Mathlib/Data/Set/Basic.lean Outdated Show resolved Hide resolved

Vierkantor reviewed Jun 11, 2025

View reviewed changes

chore(Data/Set/Basic): deprecate lemmas that abuse the `Set α := α → …

08be2b4

…Prop` defeq

YaelDillies force-pushed the deprecate_set_aubuse branch from 1c78c2b to 08be2b4 Compare June 11, 2025 10:04

rewrap

13f1448

Co-authored-by: Eric Wieser <wieser.eric@gmail.com>

fix

0a249bc

github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jun 11, 2025

artie2000 mentioned this pull request Jun 11, 2025

[Merged by Bors] - chore(Data/Set): move very basic lemmas earlier #25707

Closed

1 task

Vierkantor approved these changes Jun 12, 2025

View reviewed changes

ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Jun 12, 2025

expand deprecations

6e4ffce

mathlib-bors bot pushed a commit that referenced this pull request Jun 12, 2025

chore(Data/Set/Basic): deprecate lemmas that abuse the `Set α := α → …

0131d35

…Prop` defeq (#25669)

mathlib-bors bot pushed a commit that referenced this pull request Jun 12, 2025

chore(Data/Set/Basic): deprecate lemmas that abuse the `Set α := α → …

15af547

…Prop` defeq (#25669)

mathlib-bors bot changed the title ~~chore(Data/Set/Basic): deprecate lemmas that abuse the Set α := α → Prop defeq~~ [Merged by Bors] - chore(Data/Set/Basic): deprecate lemmas that abuse the Set α := α → Prop defeq Jun 12, 2025

mathlib-bors bot closed this Jun 12, 2025

mathlib-bors bot deleted the deprecate_set_aubuse branch June 12, 2025 11:25

pfaffelh pushed a commit to pfaffelh/mathlib4 that referenced this pull request Jun 15, 2025

chore(Data/Set/Basic): deprecate lemmas that abuse the `Set α := α → …

f1874a8

…Prop` defeq (leanprover-community#25669)

pfaffelh pushed a commit to pfaffelh/mathlib4 that referenced this pull request Jun 15, 2025

chore(Data/Set/Basic): deprecate lemmas that abuse the `Set α := α → …

50b53b5

…Prop` defeq (leanprover-community#25669)

callesonne pushed a commit to callesonne/mathlib4 that referenced this pull request Jul 24, 2025

chore(Data/Set/Basic): deprecate lemmas that abuse the `Set α := α → …

c4f1a5d

…Prop` defeq (leanprover-community#25669)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Merged by Bors] - chore(Data/Set/Basic): deprecate lemmas that abuse the `Set α := α → Prop` defeq#25669

[Merged by Bors] - chore(Data/Set/Basic): deprecate lemmas that abuse the `Set α := α → Prop` defeq#25669
YaelDillies wants to merge 4 commits intomasterfrom
deprecate_set_aubuse

YaelDillies commented Jun 10, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jun 10, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Vierkantor Jun 11, 2025

Uh oh!

alreadydone commented Jun 11, 2025 •

edited

Loading

Uh oh!

YaelDillies commented Jun 11, 2025

Uh oh!

Vierkantor left a comment

Uh oh!

mathlib-bors bot commented Jun 12, 2025

Uh oh!

YaelDillies commented Jun 12, 2025

Uh oh!

mathlib-bors bot commented Jun 12, 2025

Uh oh!

mathlib-bors bot commented Jun 12, 2025

Uh oh!

alreadydone commented Jun 12, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

YaelDillies commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR summary 8024e6939a

Import changes for modified files

Declarations diff

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Vierkantor Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

alreadydone commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

YaelDillies commented Jun 11, 2025

Uh oh!

Vierkantor left a comment

Choose a reason for hiding this comment

Uh oh!

mathlib-bors bot commented Jun 12, 2025

Uh oh!

YaelDillies commented Jun 12, 2025

Uh oh!

mathlib-bors bot commented Jun 12, 2025

Uh oh!

mathlib-bors bot commented Jun 12, 2025

Uh oh!

alreadydone commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

YaelDillies commented Jun 10, 2025 •

edited

Loading

github-actions bot commented Jun 10, 2025 •

edited

Loading

alreadydone commented Jun 11, 2025 •

edited

Loading

alreadydone commented Jun 12, 2025 •

edited

Loading