[Merged by Bors] - chore(Data/Set): move very basic lemmas earlier#25707
Closed
[Merged by Bors] - chore(Data/Set): move very basic lemmas earlier#25707
Conversation
PR summary 15af54749b
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Order.Circular | 210 | 188 | -22 (-10.48%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.Order.Circular |
-22 |
Declarations diff
+ _
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
Decrease in tech debt: (relative, absolute) = (1.00, 0.33)
| Current number | Change | Type |
|---|---|---|
| 3 | -1 | large files |
Current commit cf8898697d
Reference commit 15af54749b
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
Collaborator
|
This PR/issue depends on: |
YaelDillies
approved these changes
Jun 12, 2025
Contributor
YaelDillies
left a comment
There was a problem hiding this comment.
Thanks! 🚀
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
Member
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 12, 2025
Move basic projection lemmas about `mem` and `setOf` earlier so that you don't have to import order theory to use them (or for `simp` to see them)!
Contributor
|
Pull request successfully merged into master. Build succeeded: |
vlad902
added a commit
to vlad902/mathlib4
that referenced
this pull request
Jun 12, 2025
* master: (447 commits) chore(Data/Set): move very basic lemmas earlier (leanprover-community#25707) feat: preserve draft status when migrating PRs to fork (leanprover-community#25777) chore(Data/Set/Basic): deprecate lemmas that abuse the `Set α := α → Prop` defeq (leanprover-community#25669) refactor: redefine `ProperCone` as an `abbrev` for `ClosedSubmodule` (leanprover-community#25204) feat: interaction between ContinuousLinearMap.coprod and ContinuousLinearEquiv.prodComm (leanprover-community#25564) fix: outdated docstring (leanprover-community#25717) feat(MeasureTheory): convolution of measures with densities (leanprover-community#25718) feat: make sure that the simp normal form of equiv-like classes pushes `symm` and `trans` to the right (leanprover-community#25604) feat(ModelTheory): Formula.iSup and iInf (leanprover-community#21948) feat(RingTheory/Polynomial/ContentIdeal): the content ideal of a polynomial. (leanprover-community#25333) fix: typo in labels_from_comment.yml (leanprover-community#25727) feat: is{Inducing,Embedding}_prodMkLeft (leanprover-community#25705) feat: check that the mathlib options exist (leanprover-community#25687) feat(Algebra/Group/Even): Add missing lemmas (leanprover-community#20818) refactor: make `Matrix.kroneckerTMulAlgEquiv` heterogeneous (leanprover-community#25693) feat: allow contributors to remove labels with comments (leanprover-community#25723) chore: disable build.yml and bors.yml on forks (leanprover-community#25722) feat: improvements to user_activity_report.py (leanprover-community#25721) chore: update the migration script to check for necessary permissions and prefer ssh if possible (leanprover-community#25701) chore: update the migration script to check for necessary permissions and prefer ssh if possible (leanprover-community#25701) ...
pfaffelh
pushed a commit
to pfaffelh/mathlib4
that referenced
this pull request
Jun 15, 2025
…#25707) Move basic projection lemmas about `mem` and `setOf` earlier so that you don't have to import order theory to use them (or for `simp` to see them)!
pfaffelh
pushed a commit
to pfaffelh/mathlib4
that referenced
this pull request
Jun 15, 2025
…#25707) Move basic projection lemmas about `mem` and `setOf` earlier so that you don't have to import order theory to use them (or for `simp` to see them)!
callesonne
pushed a commit
to callesonne/mathlib4
that referenced
this pull request
Jul 24, 2025
…#25707) Move basic projection lemmas about `mem` and `setOf` earlier so that you don't have to import order theory to use them (or for `simp` to see them)!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move basic projection lemmas about
memandsetOfearlier so that you don't have to import order theory to use them (or forsimpto see them)!Set α := α → Propdefeq #25669