Skip to content

[Merged by Bors] - refactor(CategoryTheory): a structure describing transfinite compositions#21417

Closed
joelriou wants to merge 32 commits intomasterfrom
transfinite-composition-of-shape
Closed

[Merged by Bors] - refactor(CategoryTheory): a structure describing transfinite compositions#21417
joelriou wants to merge 32 commits intomasterfrom
transfinite-composition-of-shape

Conversation

@joelriou
Copy link
Copy Markdown
Contributor

@joelriou joelriou commented Feb 4, 2025

This PR introduces a structure CategoryTheory.TransfiniteCompositionOfShape J f which contains the data to express that a morphism f in a category C is a certain transfinite composition of morphisms indexed by a well ordered type J. This structure is extended in order to redefine MorphismProperty.transfiniteCompositionsOfShape.


I think that the large-import warning can be ignored because it only involves the files that are related to transfinite compositions.

Open in Gitpod

@joelriou joelriou added the t-category-theory Category theory label Feb 4, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 4, 2025

PR summary ae8f72994e

Import changes exceeding 2%

% File
+34.58% Mathlib.CategoryTheory.Limits.Shapes.Preorder.WellOrderContinuous
+36.83% Mathlib.CategoryTheory.MorphismProperty.TransfiniteComposition

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.CategoryTheory.MorphismProperty.TransfiniteComposition 486 665 +179 (+36.83%)
Mathlib.CategoryTheory.Limits.Shapes.Preorder.WellOrderContinuous 483 650 +167 (+34.58%)
Import changes for all files
Files Import difference
Mathlib.CategoryTheory.Limits.Shapes.Preorder.WellOrderContinuous Mathlib.CategoryTheory.SmallObject.TransfiniteCompositionLifting 167
Mathlib.CategoryTheory.MorphismProperty.TransfiniteComposition 179
Mathlib.CategoryTheory.Limits.Shapes.Preorder.TransfiniteCompositionOfShape (new file) 659

Declarations diff

+ TransfiniteCompositionOfShape.mem
+ id
+ instance : RespectsIso (W.transfiniteCompositionsOfShape J)
+ instance : W.IsMultiplicative
+ instance {n : ℕ} (F : Fin n ⥤ C) : F.IsWellOrderContinuous
+ isStableUnderTransfiniteCompositionOfShape_iff_of_orderIso
+ ofComp
+ ofLE
+ ofMem
+ shrink
+ shrink₀
+ transfiniteCompositionsOfShape_eq_of_orderIso
++ TransfiniteCompositionOfShape
++ ofArrowIso
++ ofComposableArrows
++ ofOrderIso
- instance [W.RespectsIso] : RespectsIso (W.transfiniteCompositionsOfShape J)
- mem_of_transfinite_composition

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@joelriou joelriou changed the title refactor(CategoryTheory): introduce a structure describing transfinite compositions refactor(CategoryTheory): a structure describing transfinite compositions Feb 4, 2025
@joelriou joelriou added the WIP Work in progress label Feb 4, 2025
@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Feb 4, 2025
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Feb 4, 2025
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Feb 7, 2025
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Feb 7, 2025
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Feb 8, 2025
joelriou and others added 4 commits February 8, 2025 20:33
…sitionOfShape.lean

Co-authored-by: Markus Himmel <markus@himmel-villmar.de>
…sitionOfShape.lean

Co-authored-by: Markus Himmel <markus@himmel-villmar.de>
@joelriou joelriou removed the WIP Work in progress label Feb 8, 2025
Copy link
Copy Markdown
Member

@TwoFX TwoFX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
bors r+

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Feb 8, 2025
mathlib-bors bot pushed a commit that referenced this pull request Feb 8, 2025
…ions (#21417)

This PR introduces a structure `CategoryTheory.TransfiniteCompositionOfShape J f` which contains the data to express that a morphism `f` in a category `C` is a certain transfinite composition of morphisms indexed by a well ordered type `J`. This structure is extended in order to redefine `MorphismProperty.transfiniteCompositionsOfShape`.



Co-authored-by: Joël Riou <joel.riou@universite-paris-saclay.fr>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 8, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title refactor(CategoryTheory): a structure describing transfinite compositions [Merged by Bors] - refactor(CategoryTheory): a structure describing transfinite compositions Feb 8, 2025
@mathlib-bors mathlib-bors bot closed this Feb 8, 2025
@mathlib-bors mathlib-bors bot deleted the transfinite-composition-of-shape branch February 8, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

large-import Automatically added label for PRs with a significant increase in transitive imports ready-to-merge This PR has been sent to bors. t-category-theory Category theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants