Skip to content

[Merged by Bors] - feat(Order): instances on Shrink#21429

Closed
joelriou wants to merge 5 commits intomasterfrom
jriou-order-shrink
Closed

[Merged by Bors] - feat(Order): instances on Shrink#21429
joelriou wants to merge 5 commits intomasterfrom
jriou-order-shrink

Conversation

@joelriou
Copy link
Copy Markdown
Contributor

@joelriou joelriou commented Feb 4, 2025

If α : Type v is u-small, we transport various order related instances on α to Shrink.{u} α.

Open in Gitpod

@joelriou joelriou added the t-order Order theory label Feb 4, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 4, 2025 •
edited
Loading

PR summary b369e528b1

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Order.Shrink (new file) 383

Declarations diff

+ equivShrink_bot
+ equivShrink_symm_bot
+ equivShrink_symm_top
+ equivShrink_top
+ instance [Bot α] : Bot (Shrink.{u} α)
+ instance [LinearOrder α] : LinearOrder (Shrink.{u} α)
+ instance [OrderBot α] :
+ instance [OrderTop α] :
+ instance [PartialOrder α] : PartialOrder (Shrink.{u} α)
+ instance [PredOrder α] :
+ instance [Preorder α] : Preorder (Shrink.{u} α)
+ instance [SuccOrder α] :
+ instance [Top α] : Top (Shrink.{u} α)
+ instance [WellFoundedLT α] : WellFoundedLT (Shrink.{u} α)
+ orderIsoShrink
+ orderIsoShrink_apply
+ orderIsoShrink_symm_apply

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@joelriou joelriou mentioned this pull request Feb 4, 2025
Closed
3 tasks
@joelriou joelriou mentioned this pull request Feb 4, 2025
Closed
21 tasks
TwoFX
TwoFX approved these changes Feb 7, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@TwoFX TwoFX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose eventually we will want more general constructions similar to Equiv.addCommGroup and friends, but I think this is already useful.

Thanks!
bors r+

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Feb 7, 2025
mathlib-bors bot pushed a commit that referenced this pull request Feb 7, 2025
@joelriou
feat(Order): instances on Shrink (#21429)
bd47360 
If `α : Type v` is `u`-small, we transport various order related instances on `α` to `Shrink.{u} α`.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 7, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Order): instances on Shrink [Merged by Bors] - feat(Order): instances on Shrink Feb 7, 2025
@mathlib-bors mathlib-bors bot closed this Feb 7, 2025
@mathlib-bors mathlib-bors bot deleted the jriou-order-shrink branch February 7, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TwoFX TwoFX TwoFX approved these changes

Assignees

No one assigned

Labels

ready-to-merge This PR has been sent to bors. t-order Order theory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joelriou @TwoFX