Skip to content

[Merged by Bors] - feat(CategoryTheory/Limits): initial and terminal objects in Fin#21561

Closed
joelriou wants to merge 3 commits intomasterfrom
jriou-preorder-fin-limits
Closed

[Merged by Bors] - feat(CategoryTheory/Limits): initial and terminal objects in Fin#21561
joelriou wants to merge 3 commits intomasterfrom
jriou-preorder-fin-limits

Conversation

@joelriou
Copy link
Copy Markdown
Contributor

@joelriou joelriou commented Feb 7, 2025

Open in Gitpod

@joelriou joelriou added the t-category-theory Category theory label Feb 7, 2025
@joelriou joelriou mentioned this pull request Feb 7, 2025
Closed
3 tasks
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 7, 2025 •
edited
Loading

PR summary c5bcb65009

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.CategoryTheory.Limits.Shapes.Preorder.Fin (new file) 408

Declarations diff

+ isInitialZero
+ isTerminalLast

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

erdOne
erdOne reviewed Feb 8, 2025
View reviewed changes
@TwoFX TwoFX added the awaiting-author A reviewer has asked the author a question or requested changes. label Feb 8, 2025
@joelriou joelriou removed the awaiting-author A reviewer has asked the author a question or requested changes. label Feb 8, 2025
TwoFX
TwoFX reviewed Feb 8, 2025
View reviewed changes
@TwoFX TwoFX added the awaiting-author A reviewer has asked the author a question or requested changes. label Feb 8, 2025
@joelriou joelriou removed the awaiting-author A reviewer has asked the author a question or requested changes. label Feb 8, 2025
TwoFX
TwoFX approved these changes Feb 8, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@TwoFX TwoFX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
bors r+

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Feb 8, 2025
mathlib-bors bot pushed a commit that referenced this pull request Feb 8, 2025
@joelriou
feat(CategoryTheory/Limits): initial and terminal objects in Fin (#21561
605ae57 
)
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 8, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(CategoryTheory/Limits): initial and terminal objects in Fin [Merged by Bors] - feat(CategoryTheory/Limits): initial and terminal objects in Fin Feb 8, 2025
@mathlib-bors mathlib-bors bot closed this Feb 8, 2025
@mathlib-bors mathlib-bors bot deleted the jriou-preorder-fin-limits branch February 8, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erdOne erdOne erdOne left review comments

@TwoFX TwoFX TwoFX approved these changes

Assignees

No one assigned

Labels

ready-to-merge This PR has been sent to bors. t-category-theory Category theory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joelriou @TwoFX @erdOne