[Merged by Bors] - chore: Rename coe_nat/coe_int/coe_rat to natCast/intCast/ratCast#11499
[Merged by Bors] - chore: Rename coe_nat/coe_int/coe_rat to natCast/intCast/ratCast#11499YaelDillies wants to merge 31 commits intomasterfrom
coe_nat/coe_int/coe_rat to natCast/intCast/ratCast#11499Conversation
0afe087 to
21cfed0
Compare
|
Can we add deprecated aliases for the old names? Maybe only some of the main lemmas? |
|
Other than that, I'm very much in favor of this, but the poll is indeed not as one-sided as I would have hoped. |
|
I estimate that without automation it would take me several hours to write the deprecated aliases 😦 (and no lemma comes to mind as particularly important) |
j-loreaux
left a comment
There was a problem hiding this comment.
LGTM but I would like one more maintainer to sign off since the poll was close.
e81c896 to
573bc54
Compare
…tCast` Reduce the diff of #11499
|
bors merge |
|
✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
|
Pull request successfully merged into master. Build succeeded: |
coe_nat/coe_int/coe_rat to natCast/intCast/ratCastcoe_nat/coe_int/coe_rat to natCast/intCast/ratCast
Reduce the diff of #11499 ## Renames All in the `Int` namespace: * `ofNat_eq_cast` → `ofNat_eq_natCast` * `cast_eq_cast_iff_Nat` → `natCast_inj` * `natCast_eq_ofNat` → `ofNat_eq_natCast` * `coe_nat_sub` → `natCast_sub` * `coe_nat_nonneg` → `natCast_nonneg` * `sign_coe_add_one` → `sign_natCast_add_one` * `nat_succ_eq_int_succ` → `natCast_succ` * `succ_neg_nat_succ` → `succ_neg_natCast_succ` * `coe_pred_of_pos` → `natCast_pred_of_pos` * `coe_nat_div` → `natCast_div` * `coe_nat_ediv` → `natCast_ediv` * `sign_coe_nat_of_nonzero` → `sign_natCast_of_ne_zero` * `toNat_coe_nat` → `toNat_natCast` * `toNat_coe_nat_add_one` → `toNat_natCast_add_one` * `coe_nat_dvd` → `natCast_dvd_natCast` * `coe_nat_dvd_left` → `natCast_dvd` * `coe_nat_dvd_right` → `dvd_natCast` * `le_coe_nat_sub` → `le_natCast_sub` * `succ_coe_nat_pos` → `succ_natCast_pos` * `coe_nat_modEq_iff` → `natCast_modEq_iff` * `coe_natAbs` → `natCast_natAbs` * `coe_nat_eq_zero` → `natCast_eq_zero` * `coe_nat_ne_zero` → `natCast_ne_zero` * `coe_nat_ne_zero_iff_pos` → `natCast_ne_zero_iff_pos` * `abs_coe_nat` → `abs_natCast` * `coe_nat_nonpos_iff` → `natCast_nonpos_iff` Also rename `Nat.coe_nat_dvd` to `Nat.cast_dvd_cast`
Reduce the diff of #11499 ## Renames All in the `Int` namespace: * `ofNat_eq_cast` → `ofNat_eq_natCast` * `cast_eq_cast_iff_Nat` → `natCast_inj` * `natCast_eq_ofNat` → `ofNat_eq_natCast` * `coe_nat_sub` → `natCast_sub` * `coe_nat_nonneg` → `natCast_nonneg` * `sign_coe_add_one` → `sign_natCast_add_one` * `nat_succ_eq_int_succ` → `natCast_succ` * `succ_neg_nat_succ` → `succ_neg_natCast_succ` * `coe_pred_of_pos` → `natCast_pred_of_pos` * `coe_nat_div` → `natCast_div` * `coe_nat_ediv` → `natCast_ediv` * `sign_coe_nat_of_nonzero` → `sign_natCast_of_ne_zero` * `toNat_coe_nat` → `toNat_natCast` * `toNat_coe_nat_add_one` → `toNat_natCast_add_one` * `coe_nat_dvd` → `natCast_dvd_natCast` * `coe_nat_dvd_left` → `natCast_dvd` * `coe_nat_dvd_right` → `dvd_natCast` * `le_coe_nat_sub` → `le_natCast_sub` * `succ_coe_nat_pos` → `succ_natCast_pos` * `coe_nat_modEq_iff` → `natCast_modEq_iff` * `coe_natAbs` → `natCast_natAbs` * `coe_nat_eq_zero` → `natCast_eq_zero` * `coe_nat_ne_zero` → `natCast_ne_zero` * `coe_nat_ne_zero_iff_pos` → `natCast_ne_zero_iff_pos` * `abs_coe_nat` → `abs_natCast` * `coe_nat_nonpos_iff` → `natCast_nonpos_iff` Also rename `Nat.coe_nat_dvd` to `Nat.cast_dvd_cast`
Reduce the diff of #11499 ## Renames All in the `Int` namespace: * `ofNat_eq_cast` → `ofNat_eq_natCast` * `cast_eq_cast_iff_Nat` → `natCast_inj` * `natCast_eq_ofNat` → `ofNat_eq_natCast` * `coe_nat_sub` → `natCast_sub` * `coe_nat_nonneg` → `natCast_nonneg` * `sign_coe_add_one` → `sign_natCast_add_one` * `nat_succ_eq_int_succ` → `natCast_succ` * `succ_neg_nat_succ` → `succ_neg_natCast_succ` * `coe_pred_of_pos` → `natCast_pred_of_pos` * `coe_nat_div` → `natCast_div` * `coe_nat_ediv` → `natCast_ediv` * `sign_coe_nat_of_nonzero` → `sign_natCast_of_ne_zero` * `toNat_coe_nat` → `toNat_natCast` * `toNat_coe_nat_add_one` → `toNat_natCast_add_one` * `coe_nat_dvd` → `natCast_dvd_natCast` * `coe_nat_dvd_left` → `natCast_dvd` * `coe_nat_dvd_right` → `dvd_natCast` * `le_coe_nat_sub` → `le_natCast_sub` * `succ_coe_nat_pos` → `succ_natCast_pos` * `coe_nat_modEq_iff` → `natCast_modEq_iff` * `coe_natAbs` → `natCast_natAbs` * `coe_nat_eq_zero` → `natCast_eq_zero` * `coe_nat_ne_zero` → `natCast_ne_zero` * `coe_nat_ne_zero_iff_pos` → `natCast_ne_zero_iff_pos` * `abs_coe_nat` → `abs_natCast` * `coe_nat_nonpos_iff` → `natCast_nonpos_iff` Also rename `Nat.coe_nat_dvd` to `Nat.cast_dvd_cast`
Reduce the diff of #11499 ## Renames All in the `Int` namespace: * `ofNat_eq_cast` → `ofNat_eq_natCast` * `cast_eq_cast_iff_Nat` → `natCast_inj` * `natCast_eq_ofNat` → `ofNat_eq_natCast` * `coe_nat_sub` → `natCast_sub` * `coe_nat_nonneg` → `natCast_nonneg` * `sign_coe_add_one` → `sign_natCast_add_one` * `nat_succ_eq_int_succ` → `natCast_succ` * `succ_neg_nat_succ` → `succ_neg_natCast_succ` * `coe_pred_of_pos` → `natCast_pred_of_pos` * `coe_nat_div` → `natCast_div` * `coe_nat_ediv` → `natCast_ediv` * `sign_coe_nat_of_nonzero` → `sign_natCast_of_ne_zero` * `toNat_coe_nat` → `toNat_natCast` * `toNat_coe_nat_add_one` → `toNat_natCast_add_one` * `coe_nat_dvd` → `natCast_dvd_natCast` * `coe_nat_dvd_left` → `natCast_dvd` * `coe_nat_dvd_right` → `dvd_natCast` * `le_coe_nat_sub` → `le_natCast_sub` * `succ_coe_nat_pos` → `succ_natCast_pos` * `coe_nat_modEq_iff` → `natCast_modEq_iff` * `coe_natAbs` → `natCast_natAbs` * `coe_nat_eq_zero` → `natCast_eq_zero` * `coe_nat_ne_zero` → `natCast_ne_zero` * `coe_nat_ne_zero_iff_pos` → `natCast_ne_zero_iff_pos` * `abs_coe_nat` → `abs_natCast` * `coe_nat_nonpos_iff` → `natCast_nonpos_iff` Also rename `Nat.coe_nat_dvd` to `Nat.cast_dvd_cast`
This is less exhaustive than its sibling #11486 because edge cases are harder to classify. No fundamental difficulty, just me being a bit fast and lazy.
Reduce the diff of #11203
zpow_coe_nattozpow_natCast#11528cat_coe_nat/cast_coe_inttocast_natCast/cast_intCast#11552coe_nattonatCast#11637