[Merged by Bors] - chore: Rename cat_coe_nat/cast_coe_int to cast_natCast/cast_intCast#11552
Closed
YaelDillies wants to merge 1 commit intomasterfrom
Closed
[Merged by Bors] - chore: Rename cat_coe_nat/cast_coe_int to cast_natCast/cast_intCast#11552YaelDillies wants to merge 1 commit intomasterfrom
cat_coe_nat/cast_coe_int to cast_natCast/cast_intCast#11552YaelDillies wants to merge 1 commit intomasterfrom
Conversation
…tCast` Reduce the diff of #11499
3 tasks
eric-wieser
approved these changes
Mar 20, 2024
Member
eric-wieser
left a comment
There was a problem hiding this comment.
I think these are fundamental enough that they are worth deprecating too.
Will let someone else decide
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by eric-wieser. |
Contributor
|
bors merge |
Contributor
|
Pull request successfully merged into master. Build succeeded: |
cat_coe_nat/cast_coe_int to cast_natCast/cast_intCastcat_coe_nat/cast_coe_int to cast_natCast/cast_intCast
Contributor
Author
|
Ah sorry, I meant to deprecate them but forgot. Will add deprecated aliases in #11499 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce the diff of #11499