Skip to content

[Merged by Bors] - chore: Rename cat_coe_nat/cast_coe_int to cast_natCast/cast_intCast#11552

Closed
YaelDillies wants to merge 1 commit intomasterfrom
cast_nat_cast
Closed

[Merged by Bors] - chore: Rename cat_coe_nat/cast_coe_int to cast_natCast/cast_intCast#11552
YaelDillies wants to merge 1 commit intomasterfrom
cast_nat_cast

Conversation

@YaelDillies
Copy link
Copy Markdown
Contributor

Reduce the diff of #11499


Open in Gitpod

Copy link
Copy Markdown
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these are fundamental enough that they are worth deprecating too.

Will let someone else decide

maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by eric-wieser.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Mar 20, 2024
@mattrobball
Copy link
Copy Markdown
Contributor

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Mar 20, 2024
mathlib-bors bot pushed a commit that referenced this pull request Mar 20, 2024
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Mar 21, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: Rename cat_coe_nat/cast_coe_int to cast_natCast/cast_intCast [Merged by Bors] - chore: Rename cat_coe_nat/cast_coe_int to cast_natCast/cast_intCast Mar 21, 2024
@mathlib-bors mathlib-bors bot closed this Mar 21, 2024
@mathlib-bors mathlib-bors bot deleted the cast_nat_cast branch March 21, 2024 00:44
@YaelDillies
Copy link
Copy Markdown
Contributor Author

Ah sorry, I meant to deprecate them but forgot. Will add deprecated aliases in #11499

dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
mathlib-bors bot pushed a commit that referenced this pull request Mar 24, 2024
xgenereux pushed a commit that referenced this pull request Mar 25, 2024
utensil pushed a commit that referenced this pull request Mar 26, 2024
utensil pushed a commit that referenced this pull request Mar 26, 2024
xgenereux pushed a commit that referenced this pull request Apr 15, 2024
xgenereux pushed a commit that referenced this pull request Apr 15, 2024
atarnoam pushed a commit that referenced this pull request Apr 16, 2024
atarnoam pushed a commit that referenced this pull request Apr 16, 2024
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
callesonne pushed a commit that referenced this pull request Apr 22, 2024
callesonne pushed a commit that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants