[Merged by Bors] - chore(Data/Int): Rename coe_nat to natCast#11637
Closed
YaelDillies wants to merge 10 commits intomasterfrom
Closed
[Merged by Bors] - chore(Data/Int): Rename coe_nat to natCast#11637YaelDillies wants to merge 10 commits intomasterfrom
coe_nat to natCast#11637YaelDillies wants to merge 10 commits intomasterfrom
Conversation
Reduce the diff of #11499
3 tasks
eric-wieser
reviewed
Mar 24, 2024
Member
|
Can you list all the renames in the description? Perhaps this would be a good excuse to use |
fpvandoorn
approved these changes
Apr 2, 2024
Member
fpvandoorn
left a comment
There was a problem hiding this comment.
LGTM
I still think you should add deprecated aliases, to make updating downstream projects easier.
Member
|
Thanks a lot! bors merge |
Contributor
|
✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 3, 2024
Reduce the diff of #11499 ## Renames All in the `Int` namespace: * `ofNat_eq_cast` → `ofNat_eq_natCast` * `cast_eq_cast_iff_Nat` → `natCast_inj` * `natCast_eq_ofNat` → `ofNat_eq_natCast` * `coe_nat_sub` → `natCast_sub` * `coe_nat_nonneg` → `natCast_nonneg` * `sign_coe_add_one` → `sign_natCast_add_one` * `nat_succ_eq_int_succ` → `natCast_succ` * `succ_neg_nat_succ` → `succ_neg_natCast_succ` * `coe_pred_of_pos` → `natCast_pred_of_pos` * `coe_nat_div` → `natCast_div` * `coe_nat_ediv` → `natCast_ediv` * `sign_coe_nat_of_nonzero` → `sign_natCast_of_ne_zero` * `toNat_coe_nat` → `toNat_natCast` * `toNat_coe_nat_add_one` → `toNat_natCast_add_one` * `coe_nat_dvd` → `natCast_dvd_natCast` * `coe_nat_dvd_left` → `natCast_dvd` * `coe_nat_dvd_right` → `dvd_natCast` * `le_coe_nat_sub` → `le_natCast_sub` * `succ_coe_nat_pos` → `succ_natCast_pos` * `coe_nat_modEq_iff` → `natCast_modEq_iff` * `coe_natAbs` → `natCast_natAbs` * `coe_nat_eq_zero` → `natCast_eq_zero` * `coe_nat_ne_zero` → `natCast_ne_zero` * `coe_nat_ne_zero_iff_pos` → `natCast_ne_zero_iff_pos` * `abs_coe_nat` → `abs_natCast` * `coe_nat_nonpos_iff` → `natCast_nonpos_iff` Also rename `Nat.coe_nat_dvd` to `Nat.cast_dvd_cast`
Contributor
|
Pull request successfully merged into master. Build succeeded: |
coe_nat to natCastcoe_nat to natCast
xgenereux
pushed a commit
that referenced
this pull request
Apr 15, 2024
Reduce the diff of #11499 ## Renames All in the `Int` namespace: * `ofNat_eq_cast` → `ofNat_eq_natCast` * `cast_eq_cast_iff_Nat` → `natCast_inj` * `natCast_eq_ofNat` → `ofNat_eq_natCast` * `coe_nat_sub` → `natCast_sub` * `coe_nat_nonneg` → `natCast_nonneg` * `sign_coe_add_one` → `sign_natCast_add_one` * `nat_succ_eq_int_succ` → `natCast_succ` * `succ_neg_nat_succ` → `succ_neg_natCast_succ` * `coe_pred_of_pos` → `natCast_pred_of_pos` * `coe_nat_div` → `natCast_div` * `coe_nat_ediv` → `natCast_ediv` * `sign_coe_nat_of_nonzero` → `sign_natCast_of_ne_zero` * `toNat_coe_nat` → `toNat_natCast` * `toNat_coe_nat_add_one` → `toNat_natCast_add_one` * `coe_nat_dvd` → `natCast_dvd_natCast` * `coe_nat_dvd_left` → `natCast_dvd` * `coe_nat_dvd_right` → `dvd_natCast` * `le_coe_nat_sub` → `le_natCast_sub` * `succ_coe_nat_pos` → `succ_natCast_pos` * `coe_nat_modEq_iff` → `natCast_modEq_iff` * `coe_natAbs` → `natCast_natAbs` * `coe_nat_eq_zero` → `natCast_eq_zero` * `coe_nat_ne_zero` → `natCast_ne_zero` * `coe_nat_ne_zero_iff_pos` → `natCast_ne_zero_iff_pos` * `abs_coe_nat` → `abs_natCast` * `coe_nat_nonpos_iff` → `natCast_nonpos_iff` Also rename `Nat.coe_nat_dvd` to `Nat.cast_dvd_cast`
atarnoam
pushed a commit
that referenced
this pull request
Apr 16, 2024
Reduce the diff of #11499 ## Renames All in the `Int` namespace: * `ofNat_eq_cast` → `ofNat_eq_natCast` * `cast_eq_cast_iff_Nat` → `natCast_inj` * `natCast_eq_ofNat` → `ofNat_eq_natCast` * `coe_nat_sub` → `natCast_sub` * `coe_nat_nonneg` → `natCast_nonneg` * `sign_coe_add_one` → `sign_natCast_add_one` * `nat_succ_eq_int_succ` → `natCast_succ` * `succ_neg_nat_succ` → `succ_neg_natCast_succ` * `coe_pred_of_pos` → `natCast_pred_of_pos` * `coe_nat_div` → `natCast_div` * `coe_nat_ediv` → `natCast_ediv` * `sign_coe_nat_of_nonzero` → `sign_natCast_of_ne_zero` * `toNat_coe_nat` → `toNat_natCast` * `toNat_coe_nat_add_one` → `toNat_natCast_add_one` * `coe_nat_dvd` → `natCast_dvd_natCast` * `coe_nat_dvd_left` → `natCast_dvd` * `coe_nat_dvd_right` → `dvd_natCast` * `le_coe_nat_sub` → `le_natCast_sub` * `succ_coe_nat_pos` → `succ_natCast_pos` * `coe_nat_modEq_iff` → `natCast_modEq_iff` * `coe_natAbs` → `natCast_natAbs` * `coe_nat_eq_zero` → `natCast_eq_zero` * `coe_nat_ne_zero` → `natCast_ne_zero` * `coe_nat_ne_zero_iff_pos` → `natCast_ne_zero_iff_pos` * `abs_coe_nat` → `abs_natCast` * `coe_nat_nonpos_iff` → `natCast_nonpos_iff` Also rename `Nat.coe_nat_dvd` to `Nat.cast_dvd_cast`
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
Reduce the diff of #11499 ## Renames All in the `Int` namespace: * `ofNat_eq_cast` → `ofNat_eq_natCast` * `cast_eq_cast_iff_Nat` → `natCast_inj` * `natCast_eq_ofNat` → `ofNat_eq_natCast` * `coe_nat_sub` → `natCast_sub` * `coe_nat_nonneg` → `natCast_nonneg` * `sign_coe_add_one` → `sign_natCast_add_one` * `nat_succ_eq_int_succ` → `natCast_succ` * `succ_neg_nat_succ` → `succ_neg_natCast_succ` * `coe_pred_of_pos` → `natCast_pred_of_pos` * `coe_nat_div` → `natCast_div` * `coe_nat_ediv` → `natCast_ediv` * `sign_coe_nat_of_nonzero` → `sign_natCast_of_ne_zero` * `toNat_coe_nat` → `toNat_natCast` * `toNat_coe_nat_add_one` → `toNat_natCast_add_one` * `coe_nat_dvd` → `natCast_dvd_natCast` * `coe_nat_dvd_left` → `natCast_dvd` * `coe_nat_dvd_right` → `dvd_natCast` * `le_coe_nat_sub` → `le_natCast_sub` * `succ_coe_nat_pos` → `succ_natCast_pos` * `coe_nat_modEq_iff` → `natCast_modEq_iff` * `coe_natAbs` → `natCast_natAbs` * `coe_nat_eq_zero` → `natCast_eq_zero` * `coe_nat_ne_zero` → `natCast_ne_zero` * `coe_nat_ne_zero_iff_pos` → `natCast_ne_zero_iff_pos` * `abs_coe_nat` → `abs_natCast` * `coe_nat_nonpos_iff` → `natCast_nonpos_iff` Also rename `Nat.coe_nat_dvd` to `Nat.cast_dvd_cast`
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
Reduce the diff of #11499 ## Renames All in the `Int` namespace: * `ofNat_eq_cast` → `ofNat_eq_natCast` * `cast_eq_cast_iff_Nat` → `natCast_inj` * `natCast_eq_ofNat` → `ofNat_eq_natCast` * `coe_nat_sub` → `natCast_sub` * `coe_nat_nonneg` → `natCast_nonneg` * `sign_coe_add_one` → `sign_natCast_add_one` * `nat_succ_eq_int_succ` → `natCast_succ` * `succ_neg_nat_succ` → `succ_neg_natCast_succ` * `coe_pred_of_pos` → `natCast_pred_of_pos` * `coe_nat_div` → `natCast_div` * `coe_nat_ediv` → `natCast_ediv` * `sign_coe_nat_of_nonzero` → `sign_natCast_of_ne_zero` * `toNat_coe_nat` → `toNat_natCast` * `toNat_coe_nat_add_one` → `toNat_natCast_add_one` * `coe_nat_dvd` → `natCast_dvd_natCast` * `coe_nat_dvd_left` → `natCast_dvd` * `coe_nat_dvd_right` → `dvd_natCast` * `le_coe_nat_sub` → `le_natCast_sub` * `succ_coe_nat_pos` → `succ_natCast_pos` * `coe_nat_modEq_iff` → `natCast_modEq_iff` * `coe_natAbs` → `natCast_natAbs` * `coe_nat_eq_zero` → `natCast_eq_zero` * `coe_nat_ne_zero` → `natCast_ne_zero` * `coe_nat_ne_zero_iff_pos` → `natCast_ne_zero_iff_pos` * `abs_coe_nat` → `abs_natCast` * `coe_nat_nonpos_iff` → `natCast_nonpos_iff` Also rename `Nat.coe_nat_dvd` to `Nat.cast_dvd_cast`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce the diff of #11499
Renames
All in the
Intnamespace:ofNat_eq_cast→ofNat_eq_natCastcast_eq_cast_iff_Nat→natCast_injnatCast_eq_ofNat→ofNat_eq_natCastcoe_nat_sub→natCast_subcoe_nat_nonneg→natCast_nonnegsign_coe_add_one→sign_natCast_add_onenat_succ_eq_int_succ→natCast_succsucc_neg_nat_succ→succ_neg_natCast_succcoe_pred_of_pos→natCast_pred_of_poscoe_nat_div→natCast_divcoe_nat_ediv→natCast_edivsign_coe_nat_of_nonzero→sign_natCast_of_ne_zerotoNat_coe_nat→toNat_natCasttoNat_coe_nat_add_one→toNat_natCast_add_onecoe_nat_dvd→natCast_dvd_natCastcoe_nat_dvd_left→natCast_dvdcoe_nat_dvd_right→dvd_natCastle_coe_nat_sub→le_natCast_subsucc_coe_nat_pos→succ_natCast_poscoe_nat_modEq_iff→natCast_modEq_iffcoe_natAbs→natCast_natAbscoe_nat_eq_zero→natCast_eq_zerocoe_nat_ne_zero→natCast_ne_zerocoe_nat_ne_zero_iff_pos→natCast_ne_zero_iff_posabs_coe_nat→abs_natCastcoe_nat_nonpos_iff→natCast_nonpos_iffAlso rename
Nat.coe_nat_dvdtoNat.cast_dvd_cast