[Merged by Bors] - chore: Rename nat_cast/int_cast/rat_cast to natCast/intCast/ratCast#11486
Closed
YaelDillies wants to merge 34 commits intomasterfrom
Closed
[Merged by Bors] - chore: Rename nat_cast/int_cast/rat_cast to natCast/intCast/ratCast#11486YaelDillies wants to merge 34 commits intomasterfrom
nat_cast/int_cast/rat_cast to natCast/intCast/ratCast#11486YaelDillies wants to merge 34 commits intomasterfrom
Conversation
Now that I am defining `NNRat.cast`, I want a definitive answer to this naming issue. Plenty of lemmas in mathlib already use `natCast`/`intCast`/`ratCast` over `nat_cast`/`int_cast`/`rat_cast`, and this matches with the general expectation that underscore-separated name parts correspond to a single declaration.
12 tasks
Member
|
Let's solicit a few more votes on https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/naming.20conventions.3A.20natCast.20vs.20nat_cast/near/346323810 first. |
3 tasks
Contributor
Author
|
Seems like there's a majority in favour |
natCast/intCast/ratCastnat_cast/int_cast/rat_cast to natCast/intCast/ratCast
Contributor
|
bors d+ |
Contributor
|
✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
Author
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 17, 2024
…/`ratCast` (#11486) Now that I am defining `NNRat.cast`, I want a definitive answer to this naming issue. Plenty of lemmas in mathlib already use `natCast`/`intCast`/`ratCast` over `nat_cast`/`int_cast`/`rat_cast`, and this matches with the general expectation that underscore-separated name parts correspond to a single declaration.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
nat_cast/int_cast/rat_cast to natCast/intCast/ratCastnat_cast/int_cast/rat_cast to natCast/intCast/ratCast
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
…/`ratCast` (#11486) Now that I am defining `NNRat.cast`, I want a definitive answer to this naming issue. Plenty of lemmas in mathlib already use `natCast`/`intCast`/`ratCast` over `nat_cast`/`int_cast`/`rat_cast`, and this matches with the general expectation that underscore-separated name parts correspond to a single declaration.
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
…/`ratCast` (#11486) Now that I am defining `NNRat.cast`, I want a definitive answer to this naming issue. Plenty of lemmas in mathlib already use `natCast`/`intCast`/`ratCast` over `nat_cast`/`int_cast`/`rat_cast`, and this matches with the general expectation that underscore-separated name parts correspond to a single declaration.
fpvandoorn
pushed a commit
to leanprover-community/leanprover-community.github.io
that referenced
this pull request
Apr 24, 2024
Explain the naming convention pushed for by leanprover-community/mathlib4#11486.
Jun2M
pushed a commit
that referenced
this pull request
Apr 24, 2024
…/`ratCast` (#11486) Now that I am defining `NNRat.cast`, I want a definitive answer to this naming issue. Plenty of lemmas in mathlib already use `natCast`/`intCast`/`ratCast` over `nat_cast`/`int_cast`/`rat_cast`, and this matches with the general expectation that underscore-separated name parts correspond to a single declaration.
mathlib-bors bot
pushed a commit
that referenced
this pull request
May 30, 2024
…3368) Deprecations have been forgotten in #11486. We add them in this PR. Methodology: start from the last commit of #11486, use the script by @adomani in #10185 (comment) to generate deprecation aliases (I am also adding an updated version of the script in a comment below) and commit. Then cherry pick this last commit on master and fix whatever has changed in between. This is not perfect as declarations which have been moved since #11486 won't get their deprecated alias, but this should be good enough.
callesonne
pushed a commit
that referenced
this pull request
Jun 4, 2024
…3368) Deprecations have been forgotten in #11486. We add them in this PR. Methodology: start from the last commit of #11486, use the script by @adomani in #10185 (comment) to generate deprecation aliases (I am also adding an updated version of the script in a comment below) and commit. Then cherry pick this last commit on master and fix whatever has changed in between. This is not perfect as declarations which have been moved since #11486 won't get their deprecated alias, but this should be good enough.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that I am defining
NNRat.cast, I want a definitive answer to this naming issue. Plenty of lemmas in mathlib already usenatCast/intCast/ratCastovernat_cast/int_cast/rat_cast, and this matches with the general expectation that underscore-separated name parts correspond to a single declaration.