Skip to content

chore: bump for leanprover/lean4#2904#383

Merged
joehendrix merged 121 commits intobump/v4.4.0from
lean-pr-testing-2904
Nov 26, 2023
Merged

chore: bump for leanprover/lean4#2904#383
joehendrix merged 121 commits intobump/v4.4.0from
lean-pr-testing-2904

Conversation

@mhuisi
Copy link
Copy Markdown
Contributor

@mhuisi mhuisi commented Nov 22, 2023

As part of leanprover/lean4#2904, an unused parameter of initSrcSearchPath was removed. This PR adjusts Std for this change.

@mhuisi mhuisi added depends on core changes This PR need only be reviewed after changes land in Lean core. v4.3.0 labels Nov 22, 2023
@kim-em kim-em added the merged-into-nightly-testing This has been merged into `nightly-testing`, and will join `main` when we update the toolchain. label Nov 26, 2023
@kim-em
Copy link
Copy Markdown
Collaborator

kim-em commented Nov 26, 2023

I have now merged this into nightly-testing, as leanprover/lean4#2904 has landed in the nightly releases.

@kim-em kim-em added v4.4.0 and removed v4.3.0 labels Nov 26, 2023
@kim-em kim-em changed the base branch from nightly-testing-2023-11-21 to bump/v4.4.0 November 26, 2023 01:38
@kim-em
Copy link
Copy Markdown
Collaborator

kim-em commented Nov 26, 2023

I've now changed the base of this PR to bump/v4.4.0, and marked it awaiting-review. According the plan, this can now be reviewed (easy!), and merged there.

@kim-em kim-em added awaiting-review This PR is ready for review; the author thinks it is ready to be merged. and removed depends on core changes This PR need only be reviewed after changes land in Lean core. labels Nov 26, 2023
@kim-em kim-em requested a review from joehendrix November 26, 2023 01:40
@joehendrix joehendrix merged commit e91c48b into bump/v4.4.0 Nov 26, 2023
mathlib-bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Nov 26, 2023
As part of leanprover/lean4#2904, an unused parameter of `initSrcSearchPath` was removed. This PR adjusts Mathlib for this change. The corresponding Std PR that adjusts a use of `initSrcSearchPath` there is at leanprover-community/batteries#383.



Co-authored-by: mhuisi <mhuisi@protonmail.com>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
mathlib-bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Nov 27, 2023
As part of leanprover/lean4#2904, an unused parameter of `initSrcSearchPath` was removed. This PR adjusts Mathlib for this change. The corresponding Std PR that adjusts a use of `initSrcSearchPath` there is at leanprover-community/batteries#383.



Co-authored-by: mhuisi <mhuisi@protonmail.com>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: François G. Dorais <fgdorais@gmail.com>
Co-authored-by: Scott Morrison <scott@tqft.net>
Co-authored-by: Alex J Best <alex.j.best@gmail.com>
Co-authored-by: Eric Rodriguez <ericrboidi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-review This PR is ready for review; the author thinks it is ready to be merged. merged-into-nightly-testing This has been merged into `nightly-testing`, and will join `main` when we update the toolchain.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants