Merged
Conversation
This commit also removes parameter `simpleReduce` from discrimination trees, and take WHNF configuration options. Reason: it is more dynamic now. For example, the simplifier will be able to use different configurations for discrimination tree insertion and retrieval. We need this feature to address issues #2669 and #2281 This commit also removes the dead Meta.Config field `zetaNonDep`.
Member
Author
|
!bench |
Collaborator
|
Here are the benchmark results for commit bc03c21. |
ghost
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 22, 2023
|
kim-em
added a commit
to leanprover-community/batteries
that referenced
this pull request
Oct 23, 2023
kim-em
added a commit
to leanprover-community/aesop
that referenced
this pull request
Oct 23, 2023
kim-em
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 23, 2023
kim-em
reviewed
Oct 23, 2023
kim-em
reviewed
Oct 23, 2023
kim-em
reviewed
Oct 23, 2023
kim-em
reviewed
Oct 23, 2023
Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
ghost
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 23, 2023
Given a local context containing `x : t := e`,
`simp (config := { zeta := false }) [x]` will expand `x` even
if `zeta := false`.
ghost
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 24, 2023
This was referenced Jan 4, 2024
This was referenced Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@semorrison This PR fixes a high priority issue, but will probably break user-defined functions that manipulate discrimination trees.