chore: remove unnecessary % operations at Fin.mod and Fin.div#2688
Merged
leodemoura merged 2 commits intomasterfrom Oct 21, 2023
Merged
chore: remove unnecessary % operations at Fin.mod and Fin.div#2688leodemoura merged 2 commits intomasterfrom
% operations at Fin.mod and Fin.div#2688leodemoura merged 2 commits intomasterfrom
Conversation
We now have the missing proofs `Nat.mod_le` and `Nat.div_le_self` in core. See: leanprover-community/batteries#286 (comment)
ghost
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 15, 2023
|
Collaborator
|
This will have a fair amount of fallout in mathlib. |
eric-wieser
reviewed
Oct 15, 2023
Member
Author
There is no rush to merge this PR. It is here just to address a suggestion at leanprover-community/batteries#286 |
ghost
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 15, 2023
Collaborator
|
(I am in favor of the change, but it seems low priority and will need some mathlib cleanup. Maybe when Scott has some free time... 😉 ) |
kim-em
added a commit
to leanprover-community/batteries
that referenced
this pull request
Oct 16, 2023
Collaborator
|
Strangely, it required only trivial cleanup in Std, and then nothing in Mathlib! |
kim-em
added a commit
to leanprover-community/batteries
that referenced
this pull request
Oct 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now have the missing proofs
Nat.mod_leandNat.div_le_selfin core.See: leanprover-community/batteries#286 (comment)