Skip to content

[Merged by Bors] - chore: bump for leanprover/lean4#2904#8586

Closed
mhuisi wants to merge 1341 commits intobump/v4.4.0from
lean-pr-testing-2904
Closed

[Merged by Bors] - chore: bump for leanprover/lean4#2904#8586
mhuisi wants to merge 1341 commits intobump/v4.4.0from
lean-pr-testing-2904

Conversation

@mhuisi
Copy link
Copy Markdown

@mhuisi mhuisi commented Nov 23, 2023

As part of leanprover/lean4#2904, an unused parameter of initSrcSearchPath was removed. This PR adjusts Mathlib for this change. The corresponding Std PR that adjusts a use of initSrcSearchPath there is at leanprover-community/batteries#383.


Open in Gitpod

@kim-em kim-em changed the base branch from master to bump/v4.4.0 November 26, 2023 01:43
@kim-em kim-em added v4.4.0 and removed blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) blocked-by-core-PR This PR depends on a PR to Core/Std v4.3.0 labels Nov 26, 2023
@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Nov 26, 2023

I have updated the lean-toolchain to leanprover/lean4:nightly-2023-11-25, and set the base of this PR to bump/v4.4.0.

Once leanprover-community/batteries#383 has been merged in Std's bump/v4.4.0, this PR needs to have its lakefile.lean dependency on Std updated to use the bump/v4.4.0, and then it can be merged into Mathlib's bump/v4.4.0.

@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Nov 26, 2023

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 26, 2023

✌️ mhuisi can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Nov 26, 2023
@ghost ghost added blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) and removed blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) labels Nov 26, 2023
@ghost
Copy link
Copy Markdown

ghost commented Nov 26, 2023

@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Nov 26, 2023

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Nov 26, 2023
mathlib-bors bot pushed a commit that referenced this pull request Nov 26, 2023
As part of leanprover/lean4#2904, an unused parameter of `initSrcSearchPath` was removed. This PR adjusts Mathlib for this change. The corresponding Std PR that adjusts a use of `initSrcSearchPath` there is at leanprover-community/batteries#383.



Co-authored-by: mhuisi <mhuisi@protonmail.com>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 26, 2023

Build failed:

@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Nov 27, 2023

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Nov 27, 2023
As part of leanprover/lean4#2904, an unused parameter of `initSrcSearchPath` was removed. This PR adjusts Mathlib for this change. The corresponding Std PR that adjusts a use of `initSrcSearchPath` there is at leanprover-community/batteries#383.



Co-authored-by: mhuisi <mhuisi@protonmail.com>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: François G. Dorais <fgdorais@gmail.com>
Co-authored-by: Scott Morrison <scott@tqft.net>
Co-authored-by: Alex J Best <alex.j.best@gmail.com>
Co-authored-by: Eric Rodriguez <ericrboidi@gmail.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 27, 2023

Pull request successfully merged into bump/v4.4.0.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: bump for leanprover/lean4#2904 [Merged by Bors] - chore: bump for leanprover/lean4#2904 Nov 27, 2023
@mathlib-bors mathlib-bors bot closed this Nov 27, 2023
@mathlib-bors mathlib-bors bot deleted the lean-pr-testing-2904 branch November 27, 2023 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked-by-batt-PR This PR depends on a PR to Batteries delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants