OTA: Make the final ConfirmBox undismissable by NiLuJe · Pull Request #12676 · koreader/koreader

NiLuJe · 2024-10-24T13:31:58Z

It's relatively easy to miss-click the buttons, especially on devices with questionable touch panels...

And while doing so is perfectly fine, ~~you miss the InfoMessage telling you that the update will be applied on restart, which is potentially confusing.~~.

(Turns out it's only mildly confusing, I was just confused about my own half-remembered confusion ;p).

Re: #12674

(Rebase me)

This change is

It's relatively easy to miss-click the buttons, especially on devices with questionable touch panels... And while doing so is perfectly fine, you miss the InfoMessage telling you that the update will be applied on restart, which is potentially confusing. Re: koreader#12674

Frenzie · 2024-10-24T14:58:40Z

I wonder if the default should be changed. What even is a ConfirmBox without callbacks?

koreader/frontend/ui/widget/confirmbox.lua

Line 57 in f844653

dismissable = true, -- set to false if any button callback is required

mergen3107 · 2024-10-24T15:12:43Z

@NiLuJe
I don't know if that's related, but do you think this observation is related?
Since I reverted back to 5.16.2.0.1, when I do OTA update in KOReader, it asks me if I want to restart KOReader to apply update. I say yes, and it just closes KOReader. Then I open it, and it starts the update process.

Before, re-opening happened immediately.

poire-z · 2024-10-24T15:29:32Z

I wonder if the default should be changed. What even is a ConfirmBox without callbacks?

koreader/frontend/ui/widget/confirmbox.lua

Line 57 in f844653

dismissable = true, -- set to false if any button callback is required

If dismissable, taping outside will call the cancel_callback, same as taping on the "cancel" button.
But when ConfirmBox is used as a real choice between 2 alternatives, and there is no obvious "cancel" / not-dangerous one, we may want to prevent the cancel one to be called when taping outside to abort. That's when it's useful to set dismissable=false.
In most cases, it's just fine having dismissable=true and taping outside doing "cancel" or "abort" or any other "gentle" action set for the cancel callback.

NiLuJe · 2024-10-24T16:07:55Z

If dismissable, taping outside will call the cancel_callback, same as taping on the "cancel" button.

Oh, right, I missed that ;p.

(Got confused w/ InfoMessage, that has a separate dismiss_callback, and where a dismiss does not call cancel_callback... because there's no cancel_callback to begin with ^^).

NiLuJe · 2024-10-24T16:10:26Z

and it just closes KOReader.

closes as in exit to the stock OS?

Anything particular in the logs?

(FWIW, something like that is what drove me to look into this, the linked issue just reminded me of it. But that was on a device where I had tested a custom build w/ the new TCs, and that usually does weird crap to the OTA mechanism ;p. Wasn't home and couldn't look at the logs, though, so I just assumed I'd clicked outside the confirmbox).

EDIT: Well... not quite like that, as KOReader didn't exit on its own, and it's entirely plausible I missed the "we"ll update on restart" infobox, as I was half asleep at the time ;p.

Commodore64user · 2024-10-24T17:15:14Z

as I was half asleep at the time ;p.

Famous last words. ;)

mergen3107 · 2024-10-24T17:20:25Z

closes as in exit to the stock OS?
Anything particular in the logs?

AFAIR yes, just a clean exit with status 0.

It updated fine after launching, so I didn't bother opening a ticket.

Let me see if I can catch this again.

Frenzie · 2024-10-24T18:12:55Z

But when ConfirmBox is used as a real choice between 2 alternatives, and there is no obvious "cancel" / not-dangerous one, we may want to prevent the cancel one to be called when taping outside to abort. That's when it's useful to set dismissable=false.

Fair enough.

mergen3107 · 2024-10-24T18:32:01Z

@NiLuJe
Yep, it did this again.
Here is the log:
OTA_no_restart_crash.txt

Just a clean exit after I hit the button Install in the prompt (do you want to install now), I even shot a video :D

mergen3107 · 2024-10-24T18:36:55Z

After starting KOReader manually, it is just OTA update and then usual startup (crash.log doesn't know about OTA update's progress?):

---------------------------------------------
                launching...
  _  _____  ____                _
 | |/ / _ \|  _ \ ___  __ _  __| | ___ _ __
 | ' / | | | |_) / _ \/ _` |/ _` |/ _ \ '__|
 | . \ |_| |  _ <  __/ (_| | (_| |  __/ |
 |_|\_\___/|_| \_\___|\__,_|\__,_|\___|_|

 It's a scroll... It's a codex... It's KOReader!

 [*] Current time: 10/24/24-14:32:20
has monolibtic? no (libs/libkoreader-monolibtic.so: cannot open shared object file: No such file or directory)
lib_search_path: libs/?
lib_basic_format: lib%s.so
lib_version_format: lib%s.so.%s
 [*] Version: v2024.07-264-g42d3f2503_2024-10-23

ffi.load: rt.so.1 (RTLD_GLOBAL)
ffi.findlib: utf8proc [3]
ffi.load: libs/libutf8proc.so.3
ffi.findlib: blitbuffer
ffi.load: libs/libblitbuffer.so
ffi.findlib: sqlite3 [0]
ffi.load: libs/libsqlite3.so.0
10/24/24-14:32:20 INFO  loaded custom event map {
  [45] = "Q"
} --[[table: 0xb6920668]] 
ffi.findlib: fbink_input [1]
ffi.load: libs/libfbink_input.so.1
[FBInk] /dev/input/event0: `bd71828-pwrkey` = KEY | POWER_BUTTON
[FBInk] /dev/input/event1: `kx132-accel` = ACCELEROMETER | ROTATION_EVENT
[FBInk] /dev/input/event2: `WacomDigitizer` = TABLET | ROTATION_EVENT
[FBInk] /dev/input/event3: `pt_mt` = TOUCHSCREEN
[FBInk] /dev/input/event4: `stylus-custom` = TABLET | ROTATION_EVENT | SCALED_TABLET
[ko-input] Forked off fake event generator (pid: 7419)
10/24/24-14:32:20 INFO  initializing for device KindleScribe 
10/24/24-14:32:20 INFO  framebuffer resolution: {
  h = 2480,
  w = 1860
} --[[table: 0xb69217f0]] 
ffi.findlib: wrap-mupdf
ffi.load: libs/libwrap-mupdf.so
10/24/24-14:32:20 INFO  Applying patch: ./patches/2-TOC-title-patch.lua 
ffi.findlib: freetype [6]
ffi.load: libs/libfreetype.so.6
ffi.findlib: harfbuzz [0]
ffi.load: libs/libharfbuzz.so.0
ffi.findlib: zstd [1]
ffi.load: libs/libzstd.so.1
10/24/24-14:32:21 INFO  Applying patch: ./patches/2-exporter-file-format.lua 
10/24/24-14:32:21 INFO  Applying patch: ./patches/2-font-override.lua 
10/24/24-14:32:21 INFO  Applying patch: ./patches/2-footer-line-word-counts-sessionduration.lua 
10/24/24-14:32:21 INFO  opening file /mnt/us/koreader/zotero/storage/XZBZITYB/Zirnstein et al. - 2024 - Evolving Outer Heliosphere Tracking Solar Wind Transients from 1 au to the VLISM with IBEX and Voya.pdf 
ffi.findlib: leptonica [6]
ffi.load: libs/libleptonica.so.6
ffi.findlib: k2pdfopt [2]
ffi.load: libs/libk2pdfopt.so.2
10/24/24-14:32:21 INFO  Inhibiting user input 
10/24/24-14:32:22 INFO  Loading plugins from directory: plugins 
10/24/24-14:32:22 WARN  Calling deprecated ButtonDialogTitle widget 
10/24/24-14:32:22 INFO  Terminal: default shell is /bin/ash 
10/24/24-14:32:22 INFO  setting zoom mode to content 
10/24/24-14:32:24 INFO  Restoring user input handling

NiLuJe · 2024-10-24T22:15:15Z

10/24/24-14:29:15 INFO  Tearing down UIManager with exit code: 0

koreader/frontend/device/generic/device.lua

Line 448 in f844653

UIManager:quit(85)

😕

NiLuJe · 2024-10-24T22:20:51Z

Ping @hius07

Looks like a regression from bf290e0#diff-16859aefa5d4dbe879ade176c19b3d5038938075d456f5703bda2f376a2d4086

The callback passed to Exit handlers matters, and this dropped it from DeviceListener ;).

mergen3107 · 2024-10-24T22:46:36Z

So, this wasn't due to me going back and forth between hf/non-hf versions :D
That PR just happened to be exactly in this period

hius07 · 2024-10-25T04:16:48Z

Sorry, overlooked

koreader/frontend/device/generic/device.lua

Line 450 in f844653

UIManager:broadcastEvent(Event:new("Exit", save_quit))

NiLuJe · 2024-10-25T11:27:51Z

Sorry, overlooked

No worries, I'll add another commit in this PR to deal with it.

Just wanted to check if you'd actually encountered some issues with the callback or if it was simply an oversight when wanting to clean things up ;).

That callback is used for custom exit paths (e.g., OTA). Regression in koreader#12509

@Sonnenfee

KOReader 2024.11 "Slang" ![koreader-2024-11-slangie](https://github.com/user-attachments/assets/cb9e68bf-aa0f-47c7-a093-46fbf8bb19c3) Some of you on Android may have had dictionary issues. That should be fixed now. Connecting to Wi-Fi should be more reliable on platforms where we manage it ourselves, most notably Kobo (koreader/lj-wpaclient#11). Color is now supported when reflowing (koreader#12085). This month's logo was contributed by @Sonnenfee We'd like to thank all contributors for their efforts. Some highlights since the previous release include: * Certain network features will now work in Flatpak (<flathub/rocks.koreader.KOReader#52>) @kii-chan-reloaded * 'Use left and right keys for page turning' option added (koreader#12174) @Commodore64user * Text editor: enhancement (koreader#12176) @hius07 (1) Speed up adding/deleting chars (by avoiding a call of expensive splitToChars), noticeable on big files. (2) Indicate select mode: wider cursor. * Annotations: more fixes (koreader#12181) @hius07 (1) Allows annotations with equal datetime fields. (2) Allows page bookmarks with equal page numbers. * kopt: color support (koreader#12085) @benoit-pierre * bump base (updated build system) & fix macOS CI (koreader#12187) @benoit-pierre * AltStatusBar/Footer: add the read timer value (koreader#12002) @zwim * bump translations (koreader#12193) @pazos * CRE call cache: don't wrap setViewMode (koreader#12194) @poire-z * bump crengine: various fixes and optimizations (koreader#12200) @poire-z * Add author option for alt status bar (koreader/crengine#575) (koreader#12197) @trash-pandy * Page turns: invert vertical tap zones (koreader#12195) @hius07 * Annotations: pageno honors reference pages and hidden flows (koreader#12214) @hius07 * ToggleSwitch: fix long-press (koreader#12215) @hius07 * SDL: Return true in NetworkMgr:isConnected on !hasWifiToggle platforms (koreader#12217) @NiLuJe * Kobo: Refactor various aspects of the Kaleido/MTK support (koreader#12221) @NiLuJe * ReaderAnnotation: fix doesMatch func (koreader#12231) @hius07 * bump base (koreader#12241) @benoit-pierre * NetworkMgr: Attempt to handle wpa_supplicant rescans better (koreader#12236) @NiLuJe * miscellaneous build system changes (koreader#12242) @benoit-pierre * make: handle old build data directory (koreader#12259) @benoit-pierre * ReaderFooter: improve (koreader#12243) @hius07 * Annotations: fix exporting (koreader#12261) @hius07 * make: install missing `cr3.css`… (koreader#12262) @benoit-pierre * [fix] NetworkMgr: apply HTTP proxy setting on startup (koreader#12260) @Frenzie * Kobo: Track frontlight state more accurately on suspend/resume (koreader#12256) @NiLuJe * Make W-Fi scan more reliable (koreader#12265, koreader/lj-wpaclient#11) @NiLuJe * ReaderAnnotation: fix doesMatch func 2 (koreader#12270) @hius07 * make: fix android update sdcv (koreader#12275) @benoit-pierre * [plugin] Reader footer: check if header resp. footer are available (koreader#12264) @zwim * ReadHistory: On remove, trust the index from FileManagerHistory if possible (koreader#12253) @NiLuJe * ReaderUI: add `seamless` argument to switchDocument (koreader#12290) @ziz57 * Fix early unhighlight after Add to vocab builder (koreader#12288) @poire-z * [CoverBrowser.MosaicMenu] Increase the thickness of the mosaic’s focus underline (koreader#12189) @Commodore64user * doc: update building documentation (koreader#12295) @benoit-pierre * NetworkMgr: fix debug trace (koreader#12297) @benoit-pierre * Panel zoom: Properly handle `renderPage()` not rendering the whole page (koreader#12296) @fbriere * PowerD: Keep track of frontlight state change by interactive callers for suspend/resume purposes (koreader#12283) @NiLuJe * InputDialog and MultiInputDialog: improve enter and edit callback handling, and implement addWidget (koreader#12289) @ziz57 * ReaderSearch: "All text" improve (koreader#12287) @hius07 * Show/Hide Virtual keyboard and more keyboard shortcuts (koreader#12162) @Commodore64user * bump base; mostly thirdparty bumps (koreader#12311) @benoit-pierre * Document: Do not cache panel-zoom tiles to disk and fix their caching and rendering (koreader#12303) @NiLuJe * Disable the legacy ReaderRotation module (koreader#12309) @NiLuJe * bump luajit (koreader#12317) @benoit-pierre * [AutoWarmth] Delay front light actions after resume (koreader#12315) @zwim * Allow numbers in measure text: fixes a crash in table of contents when debugging on (koreader#12310) @zwim * ReaderFooter: Add page-turn item (koreader#12249) @Commodore64user * luajit launcher: out of tree build + don't rebuild luajit (koreader#12285) @benoit-pierre * BookInfo: rating, review (koreader#12313) @hius07 * fix missing android APK asset (koreader#12333) @benoit-pierre * ImageWidget: Don't attempt to pan if we haven't rendered the bb yet (koreader#12331) @NiLuJe * OTM: Unbreak koreader#11999 (koreader#12337) @NiLuJe * Kobo: Refactor suspend in order to be able to catch input events sent during the 2s window of ntx madness (koreader#12330) @NiLuJe * [Menu] Remove title bar buttons from layout on hasSymKey or hasScreenKB (koreader#12328) @Commodore64user * [doc] Build: update Android instructions to openjdk-17-jdk (koreader#12345) @Frenzie * Support 'Ctrl' shortcuts on hasKeyboard (koreader#12347) @Commodore64user * Annotations: fix page numbers (koreader#12324) @hius07 * Bug Fix: DPad conflict on Kindle Keyboard (koreader#12341) @Commodore64user * Nit: Make some cache keys prettier (koreader#12354) @NiLuJe * Dispatcher: minor wording fixes (koreader#12356) @hius07 * kodev rework (koreader#12338) @benoit-pierre * czmq & libzmq: update to 4.2.1 & 4.3.5 respectively (koreader#12350) @benoit-pierre * [TextViewer] Add hamburger menu to FocusManager and Menu key (koreader#12365) @Commodore64user * ci: fix test / coverage (koreader#12367) @benoit-pierre * A couple of tiny fixes (koreader#12359) @NiLuJe * android: tweak update rule (koreader#12370) @benoit-pierre * doc: update Android build instructions (koreader#12368) @benoit-pierre * Display menu preview of italic-only fonts (koreader#12351) @charrarr * ReaderStatus, Book status widget: cleanup (koreader#12343) @hius07 * ci/macos: fix homebrew packages install (koreader#12382) @benoit-pierre * Fix terminal broken cursor and backspace (koreader#12375) @zwim * Screensaver: add option to rotate to fit screen (koreader#12366) @charrarr * Minor keyboard corrections (koreader#12372) @Commodore64user * Touch menu: always go up to correct parent page (koreader#12378) @hius07 * Collections: fix context menu (koreader#12383) @hius07 * PDF: no "Contrast set to" notification on opening (koreader#12391) @hius07 * Closing Bookmark details dialog with X should also refresh list entry (koreader#12390) @fbriere * Add numerical key_codes to event_map on kindle 3 (koreader#12358) @Commodore64user * FocusManager: Fix focus_flags check in moveFocusTo, and deal with the fallout (koreader#12361) @NiLuJe * Various notification, text editor and footnote popup minor fixes (koreader#12406) @poire-z * Bug: Account for local reading order direction adjustments. (koreader#12388) @Commodore64user * android: add custom `adb logcat` formatter (koreader#12385) @benoit-pierre * kodev: improve `kodev prompt` (koreader#12408) @benoit-pierre * kodev: fix `./kodev run android…` (koreader#12407) @benoit-pierre * Readerfont: Current font on top in menu; New fonts from current session on top in font test doc (koreader#12410) @jonnyl2 * Fix a couple of potentially spurious footer refreshes (koreader#12422) @NiLuJe * FileManager: Handle the FlushSettings event (koreader#12425) @NiLuJe * PageBrowser: fix drawing of thicker thumbnail frame on tap (koreader#12432) @poire-z * FileManagerSetDefaults: Handle strings that we default to nil (koreader#12433) @NiLuJe * Input: Ignore ABS_X, ABS_Y & ABS_PRESSURE for snow_protocol (koreader#12427) @NiLuJe * Add color highlight menu (koreader#11044) @smasher816 * Exporter: choose highlight styles to be exported (koreader#12431) @hius07 * ReaderView: Don't crash on pre-koreader#11044 highlights without a color field (koreader#12438) @NiLuJe * Terminal fixes (koreader#12369) @ziz57 * Dispatcher/DeviceListener: Temporarily turn on Accelerometer/GSensor for 5 sec (koreader#12419) @jonnyl2 * fix bug preventing export to joplin; (koreader#12446) @bitterlox * bump base: blitbuffer, android build, crengine (koreader#12451) @poire-z * InputText: Unbreak onTapTextBox on an already in-focus field (koreader#12449) @NiLuJe * Update el_popup.lua (koreader#12463) @ichnilatis-gr * [Dispatcher] add [missing] conditions to dispatcher items (koreader#12453) @Commodore64user * ReaderView: Fix a couple of edge-cases in onReaderFooterVisibilityChange (koreader#12466) @NiLuJe * misc: Move cleanupSelectedText to util (koreader#12477) @NiLuJe * ReaderHighlight: Fix an old typo in the OCR help string (koreader#12479) @NiLuJe * Highlights popup dialog: add "Color" and "Details" buttons (koreader#12461) @hius07 * ButtonDialogTitle: remove (koreader#12394) @hius07 * [Dispatcher] new events for selecting links (koreader#12474) @Commodore64user * Doc: Update quickstartguide on kindle non touch (koreader#12426) @Commodore64user * [NT] Call GotoViewRel for page up/down on useDPadAsActionKeys devices (koreader#12495) @cccslater * bump base (koreader#12503) @benoit-pierre * Defaults: Deprecate DKOPTREADER_CONFIG_DOC_LANGS_TEXT (koreader#12504) @NiLuJe * ReaderAnnotation: skip old highlights with invalid xpointers (koreader#12494) @hius07 * Cloud Sync: handles potentially incompatible backup and incoming dbs (koreader#12470) @weijiuqiao * VocabBuilder.koplugin: Better handling word context (koreader#12469) @weijiuqiao * Write highlights into PDF: revisited (koreader#12509) @hius07 * SyncService: Only require online connectivity when using Dropbox (koreader#12520) @NiLuJe * Chore: Don't cache static data tables (ui/elements, ui/data, kb layouts & co) (koreader#12519) @NiLuJe * Fix page gap inconsistencies between doc open & config change (koreader#12507) @NiLuJe * Kindle: Restore hall effect sensor state on startup (koreader#12521) @NiLuJe * VocabBuilder.koplugin: save dict headword as entry (koreader#12530) @weijiuqiao * Add PocketBook Verse Pro Color (PB634K3) (koreader#12476) @ElimGarak1 * Onyx Boox Go 10.3 support (koreader#12533) @hugleo * Statistics: fix null terminated strings, add toggle stats (koreader#12547) @hius07 * input: drop use of `ffi/input` (koreader#12486) @benoit-pierre * ci/circle: fix tests parallelism (koreader#12551) @benoit-pierre * input: fix kobo init (koreader#12553) @benoit-pierre * [ReaderFooter] update status bar in real time when inverting page turning (koreader#12424) @Commodore64user * input: fix pocketbook init (koreader#12555) @benoit-pierre * use new `ffi.loadlib` helper (koreader#12545) @benoit-pierre * input: fix loading of `fbink_input` library (koreader#12560) @benoit-pierre * Fix typos in quickstart (koreader#12566) @cheywood * File search: improve (koreader#12549) @hius07 * [DictQuickLookup] shortcuts for editing searches (koreader#12539) @Commodore64user * Profiles: auto-execute on events (koreader#12564) @hius07 * Exporter: export to book folder, register to Dispatcher (koreader#12569) @hius07 * sdl: use our compiled version for the AppImage (koreader#12575) @benoit-pierre * Add kobov4 & kobov5 targets (koreader#12568) @NiLuJe * android: switch to monolibtic mode (koreader#12576) @benoit-pierre * android: fix apkanalyzer location (koreader#12563) @benoit-pierre * Disabled rotation map for Android devices where "hw media keys follow gravity" (koreader#12557) @jkl16 * Quickstart guide kindle illustrations (koreader#12577) @Commodore64user * [plugin] Exporter: fix typo (koreader#12592) @Frenzie * Dispatcher: values' range consistent with bottom menu (koreader#12580) @hius07 * metadata translations for fdroid/flathub (koreader#12581) @pazos * ProgressWidget: fix misalignment (koreader#12526) @wbstx * Add wifi support to Cervantes Touch Light devices (koreader#12148) @jsanpe * ReaderTypeset: fix margins info (koreader#12609) @hius07 * DocSettingsTweak: apply to books with status (koreader#12606) @hius07 * Menu widget: rotation handler (koreader#12573) @hius07 * Profiles: add "on rotation" auto-execute event (koreader#12612) @hius07 * ReaderHighlight: adjustable "Edit highlight" dialog position (koreader#12599) @hius07 * KOSync/Kobo: Explicitly kill Wi-Fi on suspend (koreader#12616) @NiLuJe * Kobo: Minor simplification after koreader#12616 (koreader#12629) @NiLuJe * bump luajit-launcher (koreader#12630) @benoit-pierre * Terminal: Minor cleanups (koreader#12631) @NiLuJe * Menu widget: draw focus on focused item (koreader#12583) @hius07 * Cloud storage: fix sorting non-English filenames (koreader#12644) @hius07 * Text editor: show current line number (koreader#12632) @hius07 * InputText: fix Terminal plugin input (koreader#12652) @hius07 * ReaderFont test: Error correction -- new fonts were not rendering in own font (koreader#12646) @jonnyl2 * ReaderHighlight: fix color for extended highlight in pdf (koreader#12654) @hius07 * Kindle Scribe: fix elseif for orientation code (koreader#12663) @mergen3107 * Menu: Fix fallout from koreader#12583 on hasDPad devices (koreader#12657) @NiLuJe * Misc: Some more FocusManager fallout (koreader#12667) @NiLuJe * plugin messages (koreader#12636) @pazos * And deprecation to autofrontlight (koreader#12619) @pazos * Add deprecation for unmaintained targets (koreader#12620) @pazos * Profiles: more auto-exec triggers (koreader#12651) @hius07 * PatchManagement: prettify menu (koreader#12668) @hius07 * Fix KOReader spelling in the code (koreader#12670) @mergen3107 * Update Building.md - meson install from backports (koreader#12680) @mergen3107 * OTA: Make the final ConfirmBox undismissable (koreader#12676) @NiLuJe * Text editor: rotate (koreader#12658) @hius07 * Profiles: more auto-exec triggers 2 (koreader#12691) @hius07 * Add authentication request and cookies management for news (koreader#12496) @bateast * calibre: always use custom fast parser (koreader#12714, koreader#12715) @pazos * Add Nextcloud Notes to exporter plugin (koreader#12301) @kotnik * [plugin] Wallabag: remove empty file when download fails (koreader#12723) @fenuks * [plugin] Wallabag: separate option to delete ‘on hold’ articles (koreader#12722) @fenuks * kopt: fix OCR segmentation mode (koreader#12726) @benoit-pierre * bump base (koreader#12727) @benoit-pierre Most notably dropbear: update to 2024.85 (koreader/koreader-base#1964) * bump android-luajit-launcher (koreader#12734) @pazos * ci/circle: manually cap build jobs (koreader#12751) @benoit-pierre * Adjust Minimum Font Size in Terminal Emulator (koreader#12752) @pphszx * ReaderHighlight: Highlight menu, change 'Delete' to Trash can icon (koreader#12758) @jonnyl2 * @trash-pandy made their first contribution in koreader#12197 * @fbriere made their first contribution in koreader#12296 * @charrarr made their first contribution in koreader#12351 * @smasher816 made their first contribution in koreader#11044 * @bitterlox made their first contribution in koreader#12446 * @cccslater made their first contribution in koreader#12495 * @cheywood made their first contribution in koreader#12566 * @jkl16 made their first contribution in koreader#12557 * @wbstx made their first contribution in koreader#12526 * @jsanpe made their first contribution in koreader#12148 * @fenuks made their first contribution in koreader#12723 * @pphszx made their first contribution in koreader#12752 **Full Changelog**: koreader/koreader@v2024.07...v2024.11 — [closed milestone issues](https://github.com/koreader/koreader/milestone/74?closed=1) --- **Installation instructions**: [Android](https://github.com/koreader/koreader/wiki/Installation-on-Android-devices) • [Cervantes](https://github.com/koreader/koreader/wiki/Installation-on-BQ-devices) • [ChromeOS](https://github.com/koreader/koreader/wiki/Installation-on-Chromebook-devices) • [Kindle](https://github.com/koreader/koreader/wiki/Installation-on-Kindle-devices) • [Kobo](https://github.com/koreader/koreader/wiki/Installation-on-Kobo-devices) • [PocketBook](https://github.com/koreader/koreader/wiki/Installation-on-PocketBook-devices) • [ReMarkable](https://github.com/koreader/koreader/wiki/Installation-on-ReMarkable) • [Desktop Linux](https://github.com/koreader/koreader/wiki/Installation-on-desktop-linux) • [MacOS](https://github.com/koreader/koreader/wiki/Installation-on-MacOS)

NiLuJe added this to the 2024.10 milestone Oct 24, 2024

DeviceListener: Restore onExit callback passing

1539e73

That callback is used for custom exit paths (e.g., OTA). Regression in koreader#12509

NiLuJe merged commit b42b9a8 into koreader:master Oct 26, 2024

Frenzie mentioned this pull request May 30, 2025

improve ota updates #13888

Merged

Uh oh!

Uh oh!

Conversation

NiLuJe commented Oct 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Frenzie commented Oct 24, 2024

Uh oh!

mergen3107 commented Oct 24, 2024

Uh oh!

poire-z commented Oct 24, 2024

Uh oh!

NiLuJe commented Oct 24, 2024

Uh oh!

NiLuJe commented Oct 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Commodore64user commented Oct 24, 2024

Uh oh!

mergen3107 commented Oct 24, 2024

Uh oh!

Frenzie commented Oct 24, 2024

Uh oh!

mergen3107 commented Oct 24, 2024

Uh oh!

mergen3107 commented Oct 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NiLuJe commented Oct 24, 2024

Uh oh!

NiLuJe commented Oct 24, 2024

Uh oh!

mergen3107 commented Oct 24, 2024

Uh oh!

hius07 commented Oct 25, 2024

Uh oh!

NiLuJe commented Oct 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

NiLuJe commented Oct 24, 2024 •

edited

Loading

NiLuJe commented Oct 24, 2024 •

edited

Loading

mergen3107 commented Oct 24, 2024 •

edited

Loading

NiLuJe commented Oct 25, 2024 •

edited

Loading