Menu widget: draw focus on focused item by hius07 · Pull Request #12583 · koreader/koreader

hius07 · 2024-10-03T06:30:27Z

(1) Focus on the last opened book when closing Reader. Closes #12574.
(2) Focus on the folder when going up to the parent folder.
(3) Focus on a target item (like "Last bookmark" in bookmark list, or "Current page" in fulltext search results list etc.)
Since the Menu widget is affected, the focus may appear in some other (unexpected) places. If it is the case and annoying, the corresponding module to be fixed, after testing in the field.

This change is

NiLuJe

Some mostly trivial things to tweak for now, but I might want to spend some more time thinking about this. Hopefully this WE, but no guarantees ;).

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @hius07)

frontend/ui/widget/focusmanager.lua line 302 at r1 (raw file):

-- In some cases, we may only want to send Focus events on non-Touch devices
FocusManager.FOCUS_ONLY_ON_NT = (Device:hasDPad() and not Device:isTouchDevice()) and 0 or FocusManager.NOT_FOCUS
FocusManager.FORCED_FOCUS = 3

Needs a description explaining that it bypassesany and all heuristics and other flags in moveFocusTo (given that the default behavior is otherwise to send the unfocus/focus events, which makes this look redundant at first glance).

Also, needs to be set to 4, flags is intended to be a bitfield. (e.g., (1<<0, 1<<1, 1<<2, 1<<3, ...).

frontend/ui/widget/focusmanager.lua line 323 at r1 (raw file):

        self.selected.y = y
        -- widget create new layout on update, previous may be removed from new layout.
        local is_forced = focus_flags == FocusManager.FORCED_FOCUS

Needs to be tested properly, it's a bitfield, you have no guarantee there won't be another bit set in there.

frontend/ui/widget/menu.lua line 1014 at r1 (raw file):

            -- NOTE: Since this runs automatically on init,
            --       we use FOCUS_ONLY_ON_NT as we don't want to see the initial underline on Touch devices.
            self:moveFocusTo(x, y, is_focused and FocusManager.FORCED_FOCUS or FocusManager.FOCUS_ONLY_ON_NT)

Untested, but I imagine this no longer makes as much sense as before and we now get to see the initial focus on Touch devices regardless?

hius07 · 2024-10-03T14:34:23Z

We will see the initial focus only when we pass itemnumber or itemmatch to Menu:switchItemTable, i.e. when we have a target item.
We will always see the initial focus in the file browser (if there is no focused file, it will be the item No. 1, usually the upper folder).

hius07 · 2024-10-03T14:36:09Z

I override the bitfield check for this special case only.

NiLuJe · 2024-10-03T21:47:54Z

I override the bitfield check for this special case only.

Which was precisely my point ;).

Please make the flag value the next available bit instead (i.e., 4), and switch to an actual mask via bit.band to check it ;).

Commodore64user · 2024-10-04T16:11:17Z

Since the Menu widget is affected, the focus may appear in some other (unexpected) places.

this right here is already making me nervous.

NiLuJe · 2024-10-04T23:15:04Z

        self.selected.y = y
        -- widget create new layout on update, previous may be removed from new layout.
-        if Device:hasDPad() then
+        if focus_flags == FocusManager.FORCED_FOCUS or Device:hasDPad() then


if bit.band(focus_flags, FocusManager.FORCED_FOCUS) == FocusManager.FORCED_FOCUS or Device:hasDPad() then

What is the reason of this complication that gives the same result?
Next bitfield checks simplify, this one doesn't.

focus_flags is a bitfield, any and all of the flags can be OR'ed in it, it's not 1:1.

I'm not entirely sure anything actually relies on that right now, but that's how it was designed ;o).

Which allows us demonstrating using it as a bit, and making sure everything still behaves as expected, without breaking the expectation that focus_flags behaves like a sane bitfield, regardless of the fact that nothing was actually setting multiple bits in it before ;p.

This reverts commit 6ec4128.

FileChooser It's never really useful information. That doesn't really solve the fact that FORCED_FOCUS essentially breaks FOCUS_ONLY_ON_NT, but at least it deals with it for the most obvuois user: FileChooser.

NiLuJe · 2024-10-05T19:52:57Z

Untested, but I imagine this no longer makes as much sense as before and we now get to see the initial focus on Touch devices regardless?

Pushed a dirty hack to address this issue for FileChooser, but this is indeed a larger issue, as FORCED_FOCUS effectively breaks FOCUS_ONLY_ON_NT ;).

NiLuJe · 2024-10-05T19:53:04Z

So, err, RFC, I guess?

hius07 · 2024-10-05T19:56:47Z

Why don't you want to focus the first item in FC? It shows that we have come from the parent folder.

hius07 · 2024-10-05T19:59:58Z

So we focus either
-a book when came from Reader
-a folder when went up
-the first item (..) when went down

NiLuJe · 2024-10-05T20:02:28Z

Why don't you want to focus the first item in FC?

The general dislike about that probably came up early on in comments about #12361

It shows that we have come from the parent folder.

And where else would we have come from? ;o).

While the feature makes sense the other way around, when going from parent to children, there's only one parent, so it's pretty obvious where you came from, as there's no other choice.

hius07 · 2024-10-05T20:33:15Z

FC first item is focused because itemnumber is passed:

koreader/frontend/ui/widget/filechooser.lua

Line 513 in 3bc03d9

    
           self:switchItemTable(nil, self:genItemTableFromPath(self.path), self.path_items[self.path] or 1, itemmatch, subtitle)

hius07 · 2024-10-05T20:42:21Z

I want to investigate the usage of path_items.

NiLuJe · 2024-10-05T21:33:12Z

To recap my train of thought:

My original gripe was with showing any focus on init. That happens to be ../ in FC, which lead me to think some more about it, and realize that having this one focused didn't really ever make sense (in the context of the PR, not talking about NT).
That also made the stupid PoC hack I pushed very simple and easy, so, two birds, one stone ;).

TL;DR: Yeah, you're very very welcome to find a better solution ;).

hius07 · 2024-10-06T04:52:49Z

I do not see the focused first item in FC now.

NiLuJe · 2024-10-09T07:04:17Z

Right now I'd say FM only probably makes the most sense?

hius07 · 2024-10-13T15:02:35Z

Finally, focus in the FM only.

NiLuJe

Reviewed 1 of 1 files at r7, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion

mergen3107 · 2024-10-14T02:38:28Z

@hius07
Works great, thank you!

benoit-pierre · 2024-10-19T04:01:47Z

This does not seem to work as expected: if in the file manager, I enter the third folder, then go back to the parent, said 3rd folder appears as focused, but it actually does not have keyboard focus. Using the down key will focus the 1st item after "../" (all the while keeping the 3rd folder "focused" too). I also disagree that "../" should not be focused on init when entering a folder.

NiLuJe · 2024-10-19T19:17:15Z

I also disagree that "../" should not be focused on init when entering a folder.

To clarify, my issue with that would be on touch devices only. I don't think I tested this one on other devices, so the final approach may have been a bit too heavy-handed ;).

This was breaking koreader#12583 on hasDPad devices c.f., koreader#12583 (comment)

Tweak `mergeTitleBarIntoLayout` to keep the current selection (adjusted for the added rows) instead of resetting the focus. It only actually called `moveFocusTo` on `hasDPad` devices, which explains why this was missed during testing. Fix #12583 (comment)

poire-z · 2024-10-21T18:14:38Z

Seeing this only now, I have to say I really don't like it :) it feels like a bug, what's that rectangle ?!.

Moreover, and this is an issue - and not a question of taste I think - : the highlighted text, probably because of the added border, moves (a few pixels south east) when you select it:

mergen3107 · 2024-10-21T18:25:05Z

Is this on emulator? I don't see these boxes in Book information on Kindle

poire-z · 2024-10-21T18:33:57Z

Yes, on the emulator, which has keys/keypad, like NT Kindles.
Fortunately, we don't witness all that on our modern Kobo/Kindles :)
(Which is a reason for my request at #12579 (comment) and the next comment - if adding borders for that focus thingie make all things a little uglier, it should be made to only happen on these ugly devices :))

hius07 · 2024-10-21T18:37:32Z

Is it related to this PR?
It draws the focus in FM only.

poire-z · 2024-10-21T18:46:31Z

It's KeyValuePage - so probably not, sorry :/
But it must be another crazy Focus/NT related PR :)
I guess that until recently, the focusing only happened after the first move - so we were not seeing it.

NiLuJe · 2024-10-21T19:19:23Z

Yeah, the whole FocusManager.FOCUS_ONLY_ON_NT thing came to be just for that purpose.

I distinctly recall fixing the KVP case specifically when that was implemented (unless I hallucinated that, but I recall testing that on the Dict/WIkipedia history, which is a KVP, I think?).

So, possibly fairly new regression?

Don't show initial focus in KVP & CalendarView Fix koreader#12583 (comment)

NiLuJe · 2024-10-21T19:33:53Z

Welp, apparently clearly not ;p.

Note that the focus affecting text layout is an actual issue with a few widgets, we briefly talked about that in the Focus & NT PRs.

Don't show initial focus in KVP & CalendarView Fix #12583 (comment)

) Tweak `mergeTitleBarIntoLayout` to keep the current selection (adjusted for the added rows) instead of resetting the focus. It only actually called `moveFocusTo` on `hasDPad` devices, which explains why this was missed during testing. Fix koreader#12583 (comment)

Don't show initial focus in KVP & CalendarView Fix koreader#12583 (comment)

@Sonnenfee

KOReader 2024.11 "Slang" ![koreader-2024-11-slangie](https://github.com/user-attachments/assets/cb9e68bf-aa0f-47c7-a093-46fbf8bb19c3) Some of you on Android may have had dictionary issues. That should be fixed now. Connecting to Wi-Fi should be more reliable on platforms where we manage it ourselves, most notably Kobo (koreader/lj-wpaclient#11). Color is now supported when reflowing (koreader#12085). This month's logo was contributed by @Sonnenfee We'd like to thank all contributors for their efforts. Some highlights since the previous release include: * Certain network features will now work in Flatpak (<flathub/rocks.koreader.KOReader#52>) @kii-chan-reloaded * 'Use left and right keys for page turning' option added (koreader#12174) @Commodore64user * Text editor: enhancement (koreader#12176) @hius07 (1) Speed up adding/deleting chars (by avoiding a call of expensive splitToChars), noticeable on big files. (2) Indicate select mode: wider cursor. * Annotations: more fixes (koreader#12181) @hius07 (1) Allows annotations with equal datetime fields. (2) Allows page bookmarks with equal page numbers. * kopt: color support (koreader#12085) @benoit-pierre * bump base (updated build system) & fix macOS CI (koreader#12187) @benoit-pierre * AltStatusBar/Footer: add the read timer value (koreader#12002) @zwim * bump translations (koreader#12193) @pazos * CRE call cache: don't wrap setViewMode (koreader#12194) @poire-z * bump crengine: various fixes and optimizations (koreader#12200) @poire-z * Add author option for alt status bar (koreader/crengine#575) (koreader#12197) @trash-pandy * Page turns: invert vertical tap zones (koreader#12195) @hius07 * Annotations: pageno honors reference pages and hidden flows (koreader#12214) @hius07 * ToggleSwitch: fix long-press (koreader#12215) @hius07 * SDL: Return true in NetworkMgr:isConnected on !hasWifiToggle platforms (koreader#12217) @NiLuJe * Kobo: Refactor various aspects of the Kaleido/MTK support (koreader#12221) @NiLuJe * ReaderAnnotation: fix doesMatch func (koreader#12231) @hius07 * bump base (koreader#12241) @benoit-pierre * NetworkMgr: Attempt to handle wpa_supplicant rescans better (koreader#12236) @NiLuJe * miscellaneous build system changes (koreader#12242) @benoit-pierre * make: handle old build data directory (koreader#12259) @benoit-pierre * ReaderFooter: improve (koreader#12243) @hius07 * Annotations: fix exporting (koreader#12261) @hius07 * make: install missing `cr3.css`… (koreader#12262) @benoit-pierre * [fix] NetworkMgr: apply HTTP proxy setting on startup (koreader#12260) @Frenzie * Kobo: Track frontlight state more accurately on suspend/resume (koreader#12256) @NiLuJe * Make W-Fi scan more reliable (koreader#12265, koreader/lj-wpaclient#11) @NiLuJe * ReaderAnnotation: fix doesMatch func 2 (koreader#12270) @hius07 * make: fix android update sdcv (koreader#12275) @benoit-pierre * [plugin] Reader footer: check if header resp. footer are available (koreader#12264) @zwim * ReadHistory: On remove, trust the index from FileManagerHistory if possible (koreader#12253) @NiLuJe * ReaderUI: add `seamless` argument to switchDocument (koreader#12290) @ziz57 * Fix early unhighlight after Add to vocab builder (koreader#12288) @poire-z * [CoverBrowser.MosaicMenu] Increase the thickness of the mosaic’s focus underline (koreader#12189) @Commodore64user * doc: update building documentation (koreader#12295) @benoit-pierre * NetworkMgr: fix debug trace (koreader#12297) @benoit-pierre * Panel zoom: Properly handle `renderPage()` not rendering the whole page (koreader#12296) @fbriere * PowerD: Keep track of frontlight state change by interactive callers for suspend/resume purposes (koreader#12283) @NiLuJe * InputDialog and MultiInputDialog: improve enter and edit callback handling, and implement addWidget (koreader#12289) @ziz57 * ReaderSearch: "All text" improve (koreader#12287) @hius07 * Show/Hide Virtual keyboard and more keyboard shortcuts (koreader#12162) @Commodore64user * bump base; mostly thirdparty bumps (koreader#12311) @benoit-pierre * Document: Do not cache panel-zoom tiles to disk and fix their caching and rendering (koreader#12303) @NiLuJe * Disable the legacy ReaderRotation module (koreader#12309) @NiLuJe * bump luajit (koreader#12317) @benoit-pierre * [AutoWarmth] Delay front light actions after resume (koreader#12315) @zwim * Allow numbers in measure text: fixes a crash in table of contents when debugging on (koreader#12310) @zwim * ReaderFooter: Add page-turn item (koreader#12249) @Commodore64user * luajit launcher: out of tree build + don't rebuild luajit (koreader#12285) @benoit-pierre * BookInfo: rating, review (koreader#12313) @hius07 * fix missing android APK asset (koreader#12333) @benoit-pierre * ImageWidget: Don't attempt to pan if we haven't rendered the bb yet (koreader#12331) @NiLuJe * OTM: Unbreak koreader#11999 (koreader#12337) @NiLuJe * Kobo: Refactor suspend in order to be able to catch input events sent during the 2s window of ntx madness (koreader#12330) @NiLuJe * [Menu] Remove title bar buttons from layout on hasSymKey or hasScreenKB (koreader#12328) @Commodore64user * [doc] Build: update Android instructions to openjdk-17-jdk (koreader#12345) @Frenzie * Support 'Ctrl' shortcuts on hasKeyboard (koreader#12347) @Commodore64user * Annotations: fix page numbers (koreader#12324) @hius07 * Bug Fix: DPad conflict on Kindle Keyboard (koreader#12341) @Commodore64user * Nit: Make some cache keys prettier (koreader#12354) @NiLuJe * Dispatcher: minor wording fixes (koreader#12356) @hius07 * kodev rework (koreader#12338) @benoit-pierre * czmq & libzmq: update to 4.2.1 & 4.3.5 respectively (koreader#12350) @benoit-pierre * [TextViewer] Add hamburger menu to FocusManager and Menu key (koreader#12365) @Commodore64user * ci: fix test / coverage (koreader#12367) @benoit-pierre * A couple of tiny fixes (koreader#12359) @NiLuJe * android: tweak update rule (koreader#12370) @benoit-pierre * doc: update Android build instructions (koreader#12368) @benoit-pierre * Display menu preview of italic-only fonts (koreader#12351) @charrarr * ReaderStatus, Book status widget: cleanup (koreader#12343) @hius07 * ci/macos: fix homebrew packages install (koreader#12382) @benoit-pierre * Fix terminal broken cursor and backspace (koreader#12375) @zwim * Screensaver: add option to rotate to fit screen (koreader#12366) @charrarr * Minor keyboard corrections (koreader#12372) @Commodore64user * Touch menu: always go up to correct parent page (koreader#12378) @hius07 * Collections: fix context menu (koreader#12383) @hius07 * PDF: no "Contrast set to" notification on opening (koreader#12391) @hius07 * Closing Bookmark details dialog with X should also refresh list entry (koreader#12390) @fbriere * Add numerical key_codes to event_map on kindle 3 (koreader#12358) @Commodore64user * FocusManager: Fix focus_flags check in moveFocusTo, and deal with the fallout (koreader#12361) @NiLuJe * Various notification, text editor and footnote popup minor fixes (koreader#12406) @poire-z * Bug: Account for local reading order direction adjustments. (koreader#12388) @Commodore64user * android: add custom `adb logcat` formatter (koreader#12385) @benoit-pierre * kodev: improve `kodev prompt` (koreader#12408) @benoit-pierre * kodev: fix `./kodev run android…` (koreader#12407) @benoit-pierre * Readerfont: Current font on top in menu; New fonts from current session on top in font test doc (koreader#12410) @jonnyl2 * Fix a couple of potentially spurious footer refreshes (koreader#12422) @NiLuJe * FileManager: Handle the FlushSettings event (koreader#12425) @NiLuJe * PageBrowser: fix drawing of thicker thumbnail frame on tap (koreader#12432) @poire-z * FileManagerSetDefaults: Handle strings that we default to nil (koreader#12433) @NiLuJe * Input: Ignore ABS_X, ABS_Y & ABS_PRESSURE for snow_protocol (koreader#12427) @NiLuJe * Add color highlight menu (koreader#11044) @smasher816 * Exporter: choose highlight styles to be exported (koreader#12431) @hius07 * ReaderView: Don't crash on pre-koreader#11044 highlights without a color field (koreader#12438) @NiLuJe * Terminal fixes (koreader#12369) @ziz57 * Dispatcher/DeviceListener: Temporarily turn on Accelerometer/GSensor for 5 sec (koreader#12419) @jonnyl2 * fix bug preventing export to joplin; (koreader#12446) @bitterlox * bump base: blitbuffer, android build, crengine (koreader#12451) @poire-z * InputText: Unbreak onTapTextBox on an already in-focus field (koreader#12449) @NiLuJe * Update el_popup.lua (koreader#12463) @ichnilatis-gr * [Dispatcher] add [missing] conditions to dispatcher items (koreader#12453) @Commodore64user * ReaderView: Fix a couple of edge-cases in onReaderFooterVisibilityChange (koreader#12466) @NiLuJe * misc: Move cleanupSelectedText to util (koreader#12477) @NiLuJe * ReaderHighlight: Fix an old typo in the OCR help string (koreader#12479) @NiLuJe * Highlights popup dialog: add "Color" and "Details" buttons (koreader#12461) @hius07 * ButtonDialogTitle: remove (koreader#12394) @hius07 * [Dispatcher] new events for selecting links (koreader#12474) @Commodore64user * Doc: Update quickstartguide on kindle non touch (koreader#12426) @Commodore64user * [NT] Call GotoViewRel for page up/down on useDPadAsActionKeys devices (koreader#12495) @cccslater * bump base (koreader#12503) @benoit-pierre * Defaults: Deprecate DKOPTREADER_CONFIG_DOC_LANGS_TEXT (koreader#12504) @NiLuJe * ReaderAnnotation: skip old highlights with invalid xpointers (koreader#12494) @hius07 * Cloud Sync: handles potentially incompatible backup and incoming dbs (koreader#12470) @weijiuqiao * VocabBuilder.koplugin: Better handling word context (koreader#12469) @weijiuqiao * Write highlights into PDF: revisited (koreader#12509) @hius07 * SyncService: Only require online connectivity when using Dropbox (koreader#12520) @NiLuJe * Chore: Don't cache static data tables (ui/elements, ui/data, kb layouts & co) (koreader#12519) @NiLuJe * Fix page gap inconsistencies between doc open & config change (koreader#12507) @NiLuJe * Kindle: Restore hall effect sensor state on startup (koreader#12521) @NiLuJe * VocabBuilder.koplugin: save dict headword as entry (koreader#12530) @weijiuqiao * Add PocketBook Verse Pro Color (PB634K3) (koreader#12476) @ElimGarak1 * Onyx Boox Go 10.3 support (koreader#12533) @hugleo * Statistics: fix null terminated strings, add toggle stats (koreader#12547) @hius07 * input: drop use of `ffi/input` (koreader#12486) @benoit-pierre * ci/circle: fix tests parallelism (koreader#12551) @benoit-pierre * input: fix kobo init (koreader#12553) @benoit-pierre * [ReaderFooter] update status bar in real time when inverting page turning (koreader#12424) @Commodore64user * input: fix pocketbook init (koreader#12555) @benoit-pierre * use new `ffi.loadlib` helper (koreader#12545) @benoit-pierre * input: fix loading of `fbink_input` library (koreader#12560) @benoit-pierre * Fix typos in quickstart (koreader#12566) @cheywood * File search: improve (koreader#12549) @hius07 * [DictQuickLookup] shortcuts for editing searches (koreader#12539) @Commodore64user * Profiles: auto-execute on events (koreader#12564) @hius07 * Exporter: export to book folder, register to Dispatcher (koreader#12569) @hius07 * sdl: use our compiled version for the AppImage (koreader#12575) @benoit-pierre * Add kobov4 & kobov5 targets (koreader#12568) @NiLuJe * android: switch to monolibtic mode (koreader#12576) @benoit-pierre * android: fix apkanalyzer location (koreader#12563) @benoit-pierre * Disabled rotation map for Android devices where "hw media keys follow gravity" (koreader#12557) @jkl16 * Quickstart guide kindle illustrations (koreader#12577) @Commodore64user * [plugin] Exporter: fix typo (koreader#12592) @Frenzie * Dispatcher: values' range consistent with bottom menu (koreader#12580) @hius07 * metadata translations for fdroid/flathub (koreader#12581) @pazos * ProgressWidget: fix misalignment (koreader#12526) @wbstx * Add wifi support to Cervantes Touch Light devices (koreader#12148) @jsanpe * ReaderTypeset: fix margins info (koreader#12609) @hius07 * DocSettingsTweak: apply to books with status (koreader#12606) @hius07 * Menu widget: rotation handler (koreader#12573) @hius07 * Profiles: add "on rotation" auto-execute event (koreader#12612) @hius07 * ReaderHighlight: adjustable "Edit highlight" dialog position (koreader#12599) @hius07 * KOSync/Kobo: Explicitly kill Wi-Fi on suspend (koreader#12616) @NiLuJe * Kobo: Minor simplification after koreader#12616 (koreader#12629) @NiLuJe * bump luajit-launcher (koreader#12630) @benoit-pierre * Terminal: Minor cleanups (koreader#12631) @NiLuJe * Menu widget: draw focus on focused item (koreader#12583) @hius07 * Cloud storage: fix sorting non-English filenames (koreader#12644) @hius07 * Text editor: show current line number (koreader#12632) @hius07 * InputText: fix Terminal plugin input (koreader#12652) @hius07 * ReaderFont test: Error correction -- new fonts were not rendering in own font (koreader#12646) @jonnyl2 * ReaderHighlight: fix color for extended highlight in pdf (koreader#12654) @hius07 * Kindle Scribe: fix elseif for orientation code (koreader#12663) @mergen3107 * Menu: Fix fallout from koreader#12583 on hasDPad devices (koreader#12657) @NiLuJe * Misc: Some more FocusManager fallout (koreader#12667) @NiLuJe * plugin messages (koreader#12636) @pazos * And deprecation to autofrontlight (koreader#12619) @pazos * Add deprecation for unmaintained targets (koreader#12620) @pazos * Profiles: more auto-exec triggers (koreader#12651) @hius07 * PatchManagement: prettify menu (koreader#12668) @hius07 * Fix KOReader spelling in the code (koreader#12670) @mergen3107 * Update Building.md - meson install from backports (koreader#12680) @mergen3107 * OTA: Make the final ConfirmBox undismissable (koreader#12676) @NiLuJe * Text editor: rotate (koreader#12658) @hius07 * Profiles: more auto-exec triggers 2 (koreader#12691) @hius07 * Add authentication request and cookies management for news (koreader#12496) @bateast * calibre: always use custom fast parser (koreader#12714, koreader#12715) @pazos * Add Nextcloud Notes to exporter plugin (koreader#12301) @kotnik * [plugin] Wallabag: remove empty file when download fails (koreader#12723) @fenuks * [plugin] Wallabag: separate option to delete ‘on hold’ articles (koreader#12722) @fenuks * kopt: fix OCR segmentation mode (koreader#12726) @benoit-pierre * bump base (koreader#12727) @benoit-pierre Most notably dropbear: update to 2024.85 (koreader/koreader-base#1964) * bump android-luajit-launcher (koreader#12734) @pazos * ci/circle: manually cap build jobs (koreader#12751) @benoit-pierre * Adjust Minimum Font Size in Terminal Emulator (koreader#12752) @pphszx * ReaderHighlight: Highlight menu, change 'Delete' to Trash can icon (koreader#12758) @jonnyl2 * @trash-pandy made their first contribution in koreader#12197 * @fbriere made their first contribution in koreader#12296 * @charrarr made their first contribution in koreader#12351 * @smasher816 made their first contribution in koreader#11044 * @bitterlox made their first contribution in koreader#12446 * @cccslater made their first contribution in koreader#12495 * @cheywood made their first contribution in koreader#12566 * @jkl16 made their first contribution in koreader#12557 * @wbstx made their first contribution in koreader#12526 * @jsanpe made their first contribution in koreader#12148 * @fenuks made their first contribution in koreader#12723 * @pphszx made their first contribution in koreader#12752 **Full Changelog**: koreader/koreader@v2024.07...v2024.11 — [closed milestone issues](https://github.com/koreader/koreader/milestone/74?closed=1) --- **Installation instructions**: [Android](https://github.com/koreader/koreader/wiki/Installation-on-Android-devices) • [Cervantes](https://github.com/koreader/koreader/wiki/Installation-on-BQ-devices) • [ChromeOS](https://github.com/koreader/koreader/wiki/Installation-on-Chromebook-devices) • [Kindle](https://github.com/koreader/koreader/wiki/Installation-on-Kindle-devices) • [Kobo](https://github.com/koreader/koreader/wiki/Installation-on-Kobo-devices) • [PocketBook](https://github.com/koreader/koreader/wiki/Installation-on-PocketBook-devices) • [ReMarkable](https://github.com/koreader/koreader/wiki/Installation-on-ReMarkable) • [Desktop Linux](https://github.com/koreader/koreader/wiki/Installation-on-desktop-linux) • [MacOS](https://github.com/koreader/koreader/wiki/Installation-on-MacOS)

) Tweak `mergeTitleBarIntoLayout` to keep the current selection (adjusted for the added rows) instead of resetting the focus. It only actually called `moveFocusTo` on `hasDPad` devices, which explains why this was missed during testing. Fix koreader#12583 (comment)

Don't show initial focus in KVP & CalendarView Fix koreader#12583 (comment)

hius07 added 7 commits October 3, 2024 09:22

focusmanager: forced draw focus on touch devices

4c78d53

filechooser: default focus to 1

7ae1b41

menu widget: draw focus for focused item

ad85658

covermenu: draw focus for focused item

e02b7ee

listmenu: draw focus for focused item

0c26c76

mosaicmenu: draw focus for focused item

6b818eb

Update menu.lua

a3aca64

NiLuJe requested changes Oct 3, 2024

View reviewed changes

focusmanager: fix bitfield check

f33836d

NiLuJe reviewed Oct 4, 2024

View reviewed changes

hius07 and others added 5 commits October 5, 2024 19:42

focusmanager: always check bitfield

c21b85d

Ugh, dealing with this is going to be painful.

6ec4128

Revert "Ugh, dealing with this is going to be painful."

b414850

This reverts commit 6ec4128.

So, here's a shitty hack: never set FORCED_FOCUS for item 1 (..) in

3bc03d9

FileChooser It's never really useful information. That doesn't really solve the fact that FORCED_FOCUS essentially breaks FOCUS_ONLY_ON_NT, but at least it deals with it for the most obvuois user: FileChooser.

menu: special case for FileChooser

e9fca68

Update filechooser.lua

d25af38

menu: draw focus in FM only

0b7564c

hius07 merged commit ce7fcff into koreader:master Oct 13, 2024

hius07 deleted the menu-focus branch October 13, 2024 15:02

hius07 added this to the 2024.10 milestone Oct 13, 2024

NiLuJe reviewed Oct 13, 2024

View reviewed changes

NiLuJe added a commit to NiLuJe/koreader that referenced this pull request Oct 19, 2024

Menu: Keep the current focus in mergeTitleBarIntoLayout

7d611c2

This was breaking koreader#12583 on hasDPad devices c.f., koreader#12583 (comment)

NiLuJe mentioned this pull request Oct 19, 2024

Menu: Fix fallout from #12583 on hasDPad devices #12657

Merged

NiLuJe added a commit to NiLuJe/koreader that referenced this pull request Oct 21, 2024

Misc: Some more FocusManager fallout

5742c14

Don't show initial focus in KVP & CalendarView Fix koreader#12583 (comment)

NiLuJe mentioned this pull request Oct 21, 2024

Misc: Some more FocusManager fallout #12667

Merged

NiLuJe added a commit that referenced this pull request Oct 22, 2024

Misc: Some more FocusManager fallout (#12667)

2497d8f

Don't show initial focus in KVP & CalendarView Fix #12583 (comment)

poire-z mentioned this pull request Oct 22, 2024

NT Device: BookMap and PageBrowser #12579

Merged

Commodore64user pushed a commit to Commodore64user/KOReader_fork that referenced this pull request Nov 13, 2024

Misc: Some more FocusManager fallout (koreader#12667)

6d92d99

Don't show initial focus in KVP & CalendarView Fix koreader#12583 (comment)

0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026

Menu widget: draw focus on focused item (koreader#12583)

496c489

0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026

Misc: Some more FocusManager fallout (koreader#12667)

6dc735d

Don't show initial focus in KVP & CalendarView Fix koreader#12583 (comment)

Uh oh!

Uh oh!

Conversation

hius07 commented Oct 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NiLuJe left a comment

Choose a reason for hiding this comment

Uh oh!

hius07 commented Oct 3, 2024

Uh oh!

hius07 commented Oct 3, 2024

Uh oh!

NiLuJe commented Oct 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Commodore64user commented Oct 4, 2024

Uh oh!

NiLuJe Oct 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hius07 Oct 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NiLuJe Oct 5, 2024

Choose a reason for hiding this comment

Uh oh!

NiLuJe commented Oct 5, 2024

Uh oh!

NiLuJe commented Oct 5, 2024

Uh oh!

hius07 commented Oct 5, 2024

Uh oh!

hius07 commented Oct 5, 2024

Uh oh!

NiLuJe commented Oct 5, 2024

Uh oh!

hius07 commented Oct 5, 2024

Uh oh!

hius07 commented Oct 5, 2024

Uh oh!

NiLuJe commented Oct 5, 2024

Uh oh!

hius07 commented Oct 6, 2024

Uh oh!

NiLuJe commented Oct 9, 2024

Uh oh!

hius07 commented Oct 13, 2024

Uh oh!

NiLuJe left a comment

Choose a reason for hiding this comment

Uh oh!

mergen3107 commented Oct 14, 2024

Uh oh!

benoit-pierre commented Oct 19, 2024

Uh oh!

NiLuJe commented Oct 19, 2024

Uh oh!

poire-z commented Oct 21, 2024

Uh oh!

mergen3107 commented Oct 21, 2024

Uh oh!

poire-z commented Oct 21, 2024

Uh oh!

hius07 commented Oct 21, 2024

Uh oh!

poire-z commented Oct 21, 2024

Uh oh!

NiLuJe commented Oct 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NiLuJe commented Oct 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

hius07 commented Oct 3, 2024 •

edited

Loading

NiLuJe commented Oct 3, 2024 •

edited

Loading

NiLuJe Oct 4, 2024 •

edited

Loading

hius07 Oct 5, 2024 •

edited

Loading

NiLuJe commented Oct 21, 2024 •

edited

Loading

NiLuJe commented Oct 21, 2024 •

edited

Loading