Highlights popup dialog: add "Color" and "Details" buttons by hius07 · Pull Request #12461 · koreader/koreader

hius07 · 2024-09-04T10:58:44Z

(Also minor fixes and UX standartization)

Closes #12439. Closes #11845.

This change is

NiLuJe · 2024-09-04T11:32:52Z

Nothing jumps out at a glance ;).

(And I won't rehash what was said before about that many buttons in the dialog and i18n ;p).

Tests are upset because they relied on the self.edit_highlight_dialog nonsense you rightfully got rid of -_-".

hius07 · 2024-09-04T11:39:59Z

I removed notification when setting the default color, it didn't work well, disappeared on hold_release.
Now the star appears, so we see the action.

poire-z

Parts too out of my confort zone, so trusting you.

poire-z · 2024-09-04T14:12:45Z

            text_func = function()
                local text = v[1]
-                if v[2] == G_reader_settings:readSetting("highlight_drawing_style") then
+                if v[2] == G_reader_settings:readSetting("highlight_drawing_style", self._fallback_drawer) then


This will save as highlight_drawing_style the value of self._fallback_drawer once this is merged (while G_reader_settings:readSetting("highlight_drawing_style") or self._fallback_drawer would not).
Just asking (no idea) if that's really what you want.
(Other similar below.)

Modern trend is not to save.

poire-z · 2024-09-04T14:18:20Z

(And I won't rehash what was said before about that many buttons in the dialog and i18n ;p).

I will then :)
Do we really want to go with that (and see how translators end up managing that - or live with irregular font size depending on these words length) ?
There was also a nice suggestion with icons: #12439 (comment)

Frenzie · 2024-09-04T14:21:58Z

The two types of ellipses (or whatever they are) aren't good, but the rest is indeed largely preferable. They could simply say what they are on long press.

hius07 · 2024-09-04T14:58:34Z

So, words or icons?
I'm not sure I got the notice about the Delete icon with the immediate effect.

poire-z · 2024-09-04T15:04:00Z

If it's about my:

except for Delete, whose icon is quite explicite, the others (I think?) don't do any action directly, and open dialogs that may be explicite enough to explain what they allow, and are easily dismissable without causing any change.

I meant I am fine with the Delete icon directly deleting the highlight with no confirmation: I'd like it to be usable as quickly as before without a ConfirmBox, most people using highlights as just remporary markers would prefer that. Other users will learn the hard way and for good that Delete is without confirmation :)

hius07 · 2024-09-04T15:08:08Z

It's without confirmation from the popup; and it's with confirmation from the details.

poire-z · 2024-09-04T15:23:36Z

I don't mind that - people going into details are more serious about this bookmark, so ok.
I let others comment about the need or not for a confirmation in the quick edit dialog (I understand it's different than most other stuff, where we ask for a confirmation - so I understand if we go with adding confirmation - but it has been so practical (for me) without that confirmation).

hius07 · 2024-09-06T07:39:23Z

Words or icons? @offset-torque @jonnyl2

jonnyl2 · 2024-09-06T08:01:17Z

Words or icons?

Words would be my clear preference. These words convey the meanings perfectly. The icons can be somewhat ambiguous and don't save any space either.

benoit-pierre · 2024-09-06T08:04:52Z

The icons are nice.

The icons can be somewhat ambiguous and don't save any space either.

What about with other languages? Does using icons save space in some instances?

jonnyl2 · 2024-09-06T08:15:05Z

What about with other languages? Does using icons save space in some instances?

In the second row for example, the icons work perfectly. You couldn't describe what they do in one or two short words.

The options above should have an easily recognizable single word in any language.

But the icons are also nice, so no strong argument against them.

offset-torque · 2024-09-06T08:34:38Z

Thinking like a new user, I would much prefer the text labels since they explain themselves and I don't need to guess the icons. But I see that there are concerns about translations and fitting in the buttons, so icons may be excusable if that is a big problem.

If we prefer to go with the icons:

STYLE icon might be a bit unclear. It can be interpreted as a direct action (underline) instead of opening the style menu because this button never opens a dialog in text editors (Of course when users tap on it they will find out, so not that big problem).
DETAILS icon is confusing, especially next to the ellipsis.

Others are pretty standard and easy to guess. If we can find better options for these two items, icon dialog can be as usable as the text labels.

jonnyl2 - In the second row for example, the icons work perfectly.

Improving them was the first issue I opened here years ago and poire-z came up with these nice ones. I still enjoy their minimalist aesthetics when using this dialog.

Frenzie · 2024-09-06T09:03:05Z

The options above should have an easily recognizable single word in any language.

A single word perhaps, but not a single word that is as short.

Frenzie · 2024-09-06T09:03:42Z

STYLE icon might be a bit unclear. It can be interpreted as a direct action (underline) instead of opening the style menu because this button never opens a dialog in text editors (Of course when users tap on it they will find out, so not that big problem).

If you also add a bold in there or something it'd be clearer.

jonnyl2 · 2024-09-06T10:02:00Z

[offset-torque] DETAILS icon is confusing, especially next to the ellipsis.

Something like this could be used (if going for the icons):
(EA4A)

Thanks for adding direct access to the detail screen, btw!

hius07 · 2024-09-06T10:48:26Z

Thanks to all.
Actually the porposed "icons" are characters from our built-in fonts. There are not so many options. I've checked nerd fonts
(https://www.nerdfonts.com), not all of interesting symbols are supported. Some of them do not look good in small size.
("Vertical ellipsis" is taken from our bottom menu, there it means "More options")
Cannot find anything more.

Another way is to show real icons, but that means adding svg files.

NiLuJe · 2024-09-06T12:22:02Z

Thanks to all. Actually the porposed "icons" are characters from our built-in fonts. There are not so many options. I've checked nerd fonts (https://www.nerdfonts.com), not all of interesting symbols are supported. Some of them do not look good in small size. ("Vertical ellipsis" is taken from our bottom menu, there it means "More options") Cannot find anything more.

Another way is to show real icons, but that means adding svg files.

What would the caret and square point to here? (i.e., the last two buttons of the top row).

(FWIW, I find the palette and highlighter from your first iteration much much clearer ;p).

Frenzie · 2024-09-06T12:45:55Z

(FWIW, I find the palette and highlighter from your first iteration much much clearer ;p).

Same.

hius07 · 2024-09-06T12:48:23Z

What would the caret and square point to here?

The screenshot shows possible options: the first row for "Style", the second row for "Details".

offset-torque · 2024-09-06T13:45:11Z

Some suggestions I found in Nerd Fonts, these are coming from Material Design icons.
Details even have a little bookmark on it!

Style:
Details:

jonnyl2 · 2024-09-06T13:50:49Z

I also wanted to suggest that details icon, but alas it is not available in the KOReader character set.

The styles icon looks a bit too much like font style? Remember, this is for selecting underline/strikethrough/lighten/invert.

NiLuJe · 2024-09-06T13:51:00Z

We may not have access to it in our old/custom nerdfont version.

(And updating would be... nontrivial, as a whole swath of icons have changed codepoints, c.f., koreader/KoboUSBMS@760633c).

Frenzie · 2024-09-06T14:04:47Z

as a whole swath of icons have changed codepoints

Strange, you'd think backwards compatibility would be fairly important for its raison d'être.

hius07 · 2024-09-06T14:09:24Z

Let's keep words?

offset-torque · 2024-09-06T14:23:09Z

I think words are the best option if our icon selection is limited like this.

If they have to be icons, then my vote is:

STYLE: It can stay as the "underline" icon in the beginning. As I said this one is not very critical and its function is clear when users tap on it.
DETAILS: jonnyl2's "magnifier with plus sign", assuming it is available.

mergen3107 · 2024-09-06T16:06:08Z

What does "Details" button do? How about a gear/cog?

mergen3107 · 2024-09-06T16:08:14Z

For style, there are also many "equal" signs that might work good here. For example, ≈ or equal with wavy line on top (congruent).

https://www.alt-codes.net/equal-symbols

mergen3107 · 2024-09-06T16:09:31Z

⧤

mergen3107 · 2024-09-06T16:09:48Z

≟

mergen3107 · 2024-09-06T16:10:31Z

⩰

NiLuJe · 2024-09-06T18:00:55Z

Strange, you'd think backwards compatibility would be fairly important for its raison d'être.

They were encroaching on non-reserved ranges, causing massive i18n issues (which is why I switched to a WIP codepoint scheme at some point, because it took years for upstream to release a fixed version).

NiLuJe · 2024-09-07T14:21:44Z

Are we happy with this?

(In case I need to make conflicting changes when fixing #12473, I'd ideally want this merged first to avoid saddling @hius07 with a painful merge conflict ;))

NiLuJe · 2024-09-07T14:30:49Z

(In case I need to make conflicting changes when fixing #12473, I'd ideally want this merged first to avoid saddling @hius07 with a painful merge conflict ;))

Okay, issue is in base, so we're good ;).

poire-z · 2024-09-07T14:31:10Z

Not unhappy (but not super happy), so we can merge and see.

ptrm · 2024-09-08T09:58:03Z

Wait so you can hold the highligjt color and make it default? I only get the window half-opaque :o (on androids and Clara bw)

hius07 · 2024-09-08T10:13:15Z

To make a color default for new books: long-press the "Highlight color" menu item. It will be marked with a star.

NiLuJe · 2024-09-08T14:30:15Z

Yep, the default is set via the top menu, not the highlight context pop-up.

…

On Sun, Sep 8, 2024, 12:13 hius07 ***@***.***> wrote: To make a color default for new books: long-press the "Highlight color" menu item. It will be marked with a star. — Reply to this email directly, view it on GitHub <#12461 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAA3KZW73HEIPUMOFYN4HCDZVQPNBAVCNFSM6AAAAABNUBTC3SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZWGYZDONZXGQ> . You are receiving this because you commented.Message ID: ***@***.***>

@Sonnenfee

KOReader 2024.11 "Slang" ![koreader-2024-11-slangie](https://github.com/user-attachments/assets/cb9e68bf-aa0f-47c7-a093-46fbf8bb19c3) Some of you on Android may have had dictionary issues. That should be fixed now. Connecting to Wi-Fi should be more reliable on platforms where we manage it ourselves, most notably Kobo (koreader/lj-wpaclient#11). Color is now supported when reflowing (koreader#12085). This month's logo was contributed by @Sonnenfee We'd like to thank all contributors for their efforts. Some highlights since the previous release include: * Certain network features will now work in Flatpak (<flathub/rocks.koreader.KOReader#52>) @kii-chan-reloaded * 'Use left and right keys for page turning' option added (koreader#12174) @Commodore64user * Text editor: enhancement (koreader#12176) @hius07 (1) Speed up adding/deleting chars (by avoiding a call of expensive splitToChars), noticeable on big files. (2) Indicate select mode: wider cursor. * Annotations: more fixes (koreader#12181) @hius07 (1) Allows annotations with equal datetime fields. (2) Allows page bookmarks with equal page numbers. * kopt: color support (koreader#12085) @benoit-pierre * bump base (updated build system) & fix macOS CI (koreader#12187) @benoit-pierre * AltStatusBar/Footer: add the read timer value (koreader#12002) @zwim * bump translations (koreader#12193) @pazos * CRE call cache: don't wrap setViewMode (koreader#12194) @poire-z * bump crengine: various fixes and optimizations (koreader#12200) @poire-z * Add author option for alt status bar (koreader/crengine#575) (koreader#12197) @trash-pandy * Page turns: invert vertical tap zones (koreader#12195) @hius07 * Annotations: pageno honors reference pages and hidden flows (koreader#12214) @hius07 * ToggleSwitch: fix long-press (koreader#12215) @hius07 * SDL: Return true in NetworkMgr:isConnected on !hasWifiToggle platforms (koreader#12217) @NiLuJe * Kobo: Refactor various aspects of the Kaleido/MTK support (koreader#12221) @NiLuJe * ReaderAnnotation: fix doesMatch func (koreader#12231) @hius07 * bump base (koreader#12241) @benoit-pierre * NetworkMgr: Attempt to handle wpa_supplicant rescans better (koreader#12236) @NiLuJe * miscellaneous build system changes (koreader#12242) @benoit-pierre * make: handle old build data directory (koreader#12259) @benoit-pierre * ReaderFooter: improve (koreader#12243) @hius07 * Annotations: fix exporting (koreader#12261) @hius07 * make: install missing `cr3.css`… (koreader#12262) @benoit-pierre * [fix] NetworkMgr: apply HTTP proxy setting on startup (koreader#12260) @Frenzie * Kobo: Track frontlight state more accurately on suspend/resume (koreader#12256) @NiLuJe * Make W-Fi scan more reliable (koreader#12265, koreader/lj-wpaclient#11) @NiLuJe * ReaderAnnotation: fix doesMatch func 2 (koreader#12270) @hius07 * make: fix android update sdcv (koreader#12275) @benoit-pierre * [plugin] Reader footer: check if header resp. footer are available (koreader#12264) @zwim * ReadHistory: On remove, trust the index from FileManagerHistory if possible (koreader#12253) @NiLuJe * ReaderUI: add `seamless` argument to switchDocument (koreader#12290) @ziz57 * Fix early unhighlight after Add to vocab builder (koreader#12288) @poire-z * [CoverBrowser.MosaicMenu] Increase the thickness of the mosaic’s focus underline (koreader#12189) @Commodore64user * doc: update building documentation (koreader#12295) @benoit-pierre * NetworkMgr: fix debug trace (koreader#12297) @benoit-pierre * Panel zoom: Properly handle `renderPage()` not rendering the whole page (koreader#12296) @fbriere * PowerD: Keep track of frontlight state change by interactive callers for suspend/resume purposes (koreader#12283) @NiLuJe * InputDialog and MultiInputDialog: improve enter and edit callback handling, and implement addWidget (koreader#12289) @ziz57 * ReaderSearch: "All text" improve (koreader#12287) @hius07 * Show/Hide Virtual keyboard and more keyboard shortcuts (koreader#12162) @Commodore64user * bump base; mostly thirdparty bumps (koreader#12311) @benoit-pierre * Document: Do not cache panel-zoom tiles to disk and fix their caching and rendering (koreader#12303) @NiLuJe * Disable the legacy ReaderRotation module (koreader#12309) @NiLuJe * bump luajit (koreader#12317) @benoit-pierre * [AutoWarmth] Delay front light actions after resume (koreader#12315) @zwim * Allow numbers in measure text: fixes a crash in table of contents when debugging on (koreader#12310) @zwim * ReaderFooter: Add page-turn item (koreader#12249) @Commodore64user * luajit launcher: out of tree build + don't rebuild luajit (koreader#12285) @benoit-pierre * BookInfo: rating, review (koreader#12313) @hius07 * fix missing android APK asset (koreader#12333) @benoit-pierre * ImageWidget: Don't attempt to pan if we haven't rendered the bb yet (koreader#12331) @NiLuJe * OTM: Unbreak koreader#11999 (koreader#12337) @NiLuJe * Kobo: Refactor suspend in order to be able to catch input events sent during the 2s window of ntx madness (koreader#12330) @NiLuJe * [Menu] Remove title bar buttons from layout on hasSymKey or hasScreenKB (koreader#12328) @Commodore64user * [doc] Build: update Android instructions to openjdk-17-jdk (koreader#12345) @Frenzie * Support 'Ctrl' shortcuts on hasKeyboard (koreader#12347) @Commodore64user * Annotations: fix page numbers (koreader#12324) @hius07 * Bug Fix: DPad conflict on Kindle Keyboard (koreader#12341) @Commodore64user * Nit: Make some cache keys prettier (koreader#12354) @NiLuJe * Dispatcher: minor wording fixes (koreader#12356) @hius07 * kodev rework (koreader#12338) @benoit-pierre * czmq & libzmq: update to 4.2.1 & 4.3.5 respectively (koreader#12350) @benoit-pierre * [TextViewer] Add hamburger menu to FocusManager and Menu key (koreader#12365) @Commodore64user * ci: fix test / coverage (koreader#12367) @benoit-pierre * A couple of tiny fixes (koreader#12359) @NiLuJe * android: tweak update rule (koreader#12370) @benoit-pierre * doc: update Android build instructions (koreader#12368) @benoit-pierre * Display menu preview of italic-only fonts (koreader#12351) @charrarr * ReaderStatus, Book status widget: cleanup (koreader#12343) @hius07 * ci/macos: fix homebrew packages install (koreader#12382) @benoit-pierre * Fix terminal broken cursor and backspace (koreader#12375) @zwim * Screensaver: add option to rotate to fit screen (koreader#12366) @charrarr * Minor keyboard corrections (koreader#12372) @Commodore64user * Touch menu: always go up to correct parent page (koreader#12378) @hius07 * Collections: fix context menu (koreader#12383) @hius07 * PDF: no "Contrast set to" notification on opening (koreader#12391) @hius07 * Closing Bookmark details dialog with X should also refresh list entry (koreader#12390) @fbriere * Add numerical key_codes to event_map on kindle 3 (koreader#12358) @Commodore64user * FocusManager: Fix focus_flags check in moveFocusTo, and deal with the fallout (koreader#12361) @NiLuJe * Various notification, text editor and footnote popup minor fixes (koreader#12406) @poire-z * Bug: Account for local reading order direction adjustments. (koreader#12388) @Commodore64user * android: add custom `adb logcat` formatter (koreader#12385) @benoit-pierre * kodev: improve `kodev prompt` (koreader#12408) @benoit-pierre * kodev: fix `./kodev run android…` (koreader#12407) @benoit-pierre * Readerfont: Current font on top in menu; New fonts from current session on top in font test doc (koreader#12410) @jonnyl2 * Fix a couple of potentially spurious footer refreshes (koreader#12422) @NiLuJe * FileManager: Handle the FlushSettings event (koreader#12425) @NiLuJe * PageBrowser: fix drawing of thicker thumbnail frame on tap (koreader#12432) @poire-z * FileManagerSetDefaults: Handle strings that we default to nil (koreader#12433) @NiLuJe * Input: Ignore ABS_X, ABS_Y & ABS_PRESSURE for snow_protocol (koreader#12427) @NiLuJe * Add color highlight menu (koreader#11044) @smasher816 * Exporter: choose highlight styles to be exported (koreader#12431) @hius07 * ReaderView: Don't crash on pre-koreader#11044 highlights without a color field (koreader#12438) @NiLuJe * Terminal fixes (koreader#12369) @ziz57 * Dispatcher/DeviceListener: Temporarily turn on Accelerometer/GSensor for 5 sec (koreader#12419) @jonnyl2 * fix bug preventing export to joplin; (koreader#12446) @bitterlox * bump base: blitbuffer, android build, crengine (koreader#12451) @poire-z * InputText: Unbreak onTapTextBox on an already in-focus field (koreader#12449) @NiLuJe * Update el_popup.lua (koreader#12463) @ichnilatis-gr * [Dispatcher] add [missing] conditions to dispatcher items (koreader#12453) @Commodore64user * ReaderView: Fix a couple of edge-cases in onReaderFooterVisibilityChange (koreader#12466) @NiLuJe * misc: Move cleanupSelectedText to util (koreader#12477) @NiLuJe * ReaderHighlight: Fix an old typo in the OCR help string (koreader#12479) @NiLuJe * Highlights popup dialog: add "Color" and "Details" buttons (koreader#12461) @hius07 * ButtonDialogTitle: remove (koreader#12394) @hius07 * [Dispatcher] new events for selecting links (koreader#12474) @Commodore64user * Doc: Update quickstartguide on kindle non touch (koreader#12426) @Commodore64user * [NT] Call GotoViewRel for page up/down on useDPadAsActionKeys devices (koreader#12495) @cccslater * bump base (koreader#12503) @benoit-pierre * Defaults: Deprecate DKOPTREADER_CONFIG_DOC_LANGS_TEXT (koreader#12504) @NiLuJe * ReaderAnnotation: skip old highlights with invalid xpointers (koreader#12494) @hius07 * Cloud Sync: handles potentially incompatible backup and incoming dbs (koreader#12470) @weijiuqiao * VocabBuilder.koplugin: Better handling word context (koreader#12469) @weijiuqiao * Write highlights into PDF: revisited (koreader#12509) @hius07 * SyncService: Only require online connectivity when using Dropbox (koreader#12520) @NiLuJe * Chore: Don't cache static data tables (ui/elements, ui/data, kb layouts & co) (koreader#12519) @NiLuJe * Fix page gap inconsistencies between doc open & config change (koreader#12507) @NiLuJe * Kindle: Restore hall effect sensor state on startup (koreader#12521) @NiLuJe * VocabBuilder.koplugin: save dict headword as entry (koreader#12530) @weijiuqiao * Add PocketBook Verse Pro Color (PB634K3) (koreader#12476) @ElimGarak1 * Onyx Boox Go 10.3 support (koreader#12533) @hugleo * Statistics: fix null terminated strings, add toggle stats (koreader#12547) @hius07 * input: drop use of `ffi/input` (koreader#12486) @benoit-pierre * ci/circle: fix tests parallelism (koreader#12551) @benoit-pierre * input: fix kobo init (koreader#12553) @benoit-pierre * [ReaderFooter] update status bar in real time when inverting page turning (koreader#12424) @Commodore64user * input: fix pocketbook init (koreader#12555) @benoit-pierre * use new `ffi.loadlib` helper (koreader#12545) @benoit-pierre * input: fix loading of `fbink_input` library (koreader#12560) @benoit-pierre * Fix typos in quickstart (koreader#12566) @cheywood * File search: improve (koreader#12549) @hius07 * [DictQuickLookup] shortcuts for editing searches (koreader#12539) @Commodore64user * Profiles: auto-execute on events (koreader#12564) @hius07 * Exporter: export to book folder, register to Dispatcher (koreader#12569) @hius07 * sdl: use our compiled version for the AppImage (koreader#12575) @benoit-pierre * Add kobov4 & kobov5 targets (koreader#12568) @NiLuJe * android: switch to monolibtic mode (koreader#12576) @benoit-pierre * android: fix apkanalyzer location (koreader#12563) @benoit-pierre * Disabled rotation map for Android devices where "hw media keys follow gravity" (koreader#12557) @jkl16 * Quickstart guide kindle illustrations (koreader#12577) @Commodore64user * [plugin] Exporter: fix typo (koreader#12592) @Frenzie * Dispatcher: values' range consistent with bottom menu (koreader#12580) @hius07 * metadata translations for fdroid/flathub (koreader#12581) @pazos * ProgressWidget: fix misalignment (koreader#12526) @wbstx * Add wifi support to Cervantes Touch Light devices (koreader#12148) @jsanpe * ReaderTypeset: fix margins info (koreader#12609) @hius07 * DocSettingsTweak: apply to books with status (koreader#12606) @hius07 * Menu widget: rotation handler (koreader#12573) @hius07 * Profiles: add "on rotation" auto-execute event (koreader#12612) @hius07 * ReaderHighlight: adjustable "Edit highlight" dialog position (koreader#12599) @hius07 * KOSync/Kobo: Explicitly kill Wi-Fi on suspend (koreader#12616) @NiLuJe * Kobo: Minor simplification after koreader#12616 (koreader#12629) @NiLuJe * bump luajit-launcher (koreader#12630) @benoit-pierre * Terminal: Minor cleanups (koreader#12631) @NiLuJe * Menu widget: draw focus on focused item (koreader#12583) @hius07 * Cloud storage: fix sorting non-English filenames (koreader#12644) @hius07 * Text editor: show current line number (koreader#12632) @hius07 * InputText: fix Terminal plugin input (koreader#12652) @hius07 * ReaderFont test: Error correction -- new fonts were not rendering in own font (koreader#12646) @jonnyl2 * ReaderHighlight: fix color for extended highlight in pdf (koreader#12654) @hius07 * Kindle Scribe: fix elseif for orientation code (koreader#12663) @mergen3107 * Menu: Fix fallout from koreader#12583 on hasDPad devices (koreader#12657) @NiLuJe * Misc: Some more FocusManager fallout (koreader#12667) @NiLuJe * plugin messages (koreader#12636) @pazos * And deprecation to autofrontlight (koreader#12619) @pazos * Add deprecation for unmaintained targets (koreader#12620) @pazos * Profiles: more auto-exec triggers (koreader#12651) @hius07 * PatchManagement: prettify menu (koreader#12668) @hius07 * Fix KOReader spelling in the code (koreader#12670) @mergen3107 * Update Building.md - meson install from backports (koreader#12680) @mergen3107 * OTA: Make the final ConfirmBox undismissable (koreader#12676) @NiLuJe * Text editor: rotate (koreader#12658) @hius07 * Profiles: more auto-exec triggers 2 (koreader#12691) @hius07 * Add authentication request and cookies management for news (koreader#12496) @bateast * calibre: always use custom fast parser (koreader#12714, koreader#12715) @pazos * Add Nextcloud Notes to exporter plugin (koreader#12301) @kotnik * [plugin] Wallabag: remove empty file when download fails (koreader#12723) @fenuks * [plugin] Wallabag: separate option to delete ‘on hold’ articles (koreader#12722) @fenuks * kopt: fix OCR segmentation mode (koreader#12726) @benoit-pierre * bump base (koreader#12727) @benoit-pierre Most notably dropbear: update to 2024.85 (koreader/koreader-base#1964) * bump android-luajit-launcher (koreader#12734) @pazos * ci/circle: manually cap build jobs (koreader#12751) @benoit-pierre * Adjust Minimum Font Size in Terminal Emulator (koreader#12752) @pphszx * ReaderHighlight: Highlight menu, change 'Delete' to Trash can icon (koreader#12758) @jonnyl2 * @trash-pandy made their first contribution in koreader#12197 * @fbriere made their first contribution in koreader#12296 * @charrarr made their first contribution in koreader#12351 * @smasher816 made their first contribution in koreader#11044 * @bitterlox made their first contribution in koreader#12446 * @cccslater made their first contribution in koreader#12495 * @cheywood made their first contribution in koreader#12566 * @jkl16 made their first contribution in koreader#12557 * @wbstx made their first contribution in koreader#12526 * @jsanpe made their first contribution in koreader#12148 * @fenuks made their first contribution in koreader#12723 * @pphszx made their first contribution in koreader#12752 **Full Changelog**: koreader/koreader@v2024.07...v2024.11 — [closed milestone issues](https://github.com/koreader/koreader/milestone/74?closed=1) --- **Installation instructions**: [Android](https://github.com/koreader/koreader/wiki/Installation-on-Android-devices) • [Cervantes](https://github.com/koreader/koreader/wiki/Installation-on-BQ-devices) • [ChromeOS](https://github.com/koreader/koreader/wiki/Installation-on-Chromebook-devices) • [Kindle](https://github.com/koreader/koreader/wiki/Installation-on-Kindle-devices) • [Kobo](https://github.com/koreader/koreader/wiki/Installation-on-Kobo-devices) • [PocketBook](https://github.com/koreader/koreader/wiki/Installation-on-PocketBook-devices) • [ReMarkable](https://github.com/koreader/koreader/wiki/Installation-on-ReMarkable) • [Desktop Linux](https://github.com/koreader/koreader/wiki/Installation-on-desktop-linux) • [MacOS](https://github.com/koreader/koreader/wiki/Installation-on-MacOS)

…12461)

hius07 added 3 commits September 4, 2024 13:52

readerbookmark: hl popup buttons

51bd126

readerhighlight: hl popup buttons

0ac3870

readerview: nits

39a89fd

readerhighlight: restore self.edit_highlight_dialog for unit tests

6819691

poire-z reviewed Sep 4, 2024

View reviewed changes

readerhighlight: do not save G_ default drawer and color

9e01ea3

hius07 merged commit 7572a81 into koreader:master Sep 7, 2024

hius07 deleted the hl-popup branch September 7, 2024 14:56

hius07 added this to the 2024.08 milestone Sep 7, 2024

poire-z mentioned this pull request Nov 20, 2024

Highlight options dialog: possible Delete/Details button confusion #12754

Closed

0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026

Highlights popup dialog: add "Color" and "Details" buttons (koreader#…

e572ae2

…12461)

Uh oh!

Uh oh!

Conversation

hius07 commented Sep 4, 2024 • edited by Frenzie Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NiLuJe commented Sep 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hius07 commented Sep 4, 2024

Uh oh!

poire-z left a comment

Choose a reason for hiding this comment

Uh oh!

poire-z Sep 4, 2024

Choose a reason for hiding this comment

Uh oh!

hius07 Sep 4, 2024

Choose a reason for hiding this comment

Uh oh!

poire-z commented Sep 4, 2024

Uh oh!

Frenzie commented Sep 4, 2024

Uh oh!

hius07 commented Sep 4, 2024

Uh oh!

poire-z commented Sep 4, 2024

Uh oh!

hius07 commented Sep 4, 2024

Uh oh!

poire-z commented Sep 4, 2024

Uh oh!

hius07 commented Sep 6, 2024

Uh oh!

jonnyl2 commented Sep 6, 2024

Uh oh!

benoit-pierre commented Sep 6, 2024

Uh oh!

jonnyl2 commented Sep 6, 2024

Uh oh!

offset-torque commented Sep 6, 2024

Uh oh!

Frenzie commented Sep 6, 2024

Uh oh!

Frenzie commented Sep 6, 2024

Uh oh!

jonnyl2 commented Sep 6, 2024

Uh oh!

hius07 commented Sep 6, 2024

Uh oh!

NiLuJe commented Sep 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Frenzie commented Sep 6, 2024

Uh oh!

hius07 commented Sep 6, 2024

Uh oh!

offset-torque commented Sep 6, 2024

Uh oh!

jonnyl2 commented Sep 6, 2024

Uh oh!

NiLuJe commented Sep 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Frenzie commented Sep 6, 2024

Uh oh!

hius07 commented Sep 6, 2024

Uh oh!

offset-torque commented Sep 6, 2024

Uh oh!

mergen3107 commented Sep 6, 2024

Uh oh!

mergen3107 commented Sep 6, 2024

Uh oh!

mergen3107 commented Sep 6, 2024

Uh oh!

mergen3107 commented Sep 6, 2024

Uh oh!

mergen3107 commented Sep 6, 2024

Uh oh!

hius07 commented Sep 4, 2024 •

edited by Frenzie

Loading

NiLuJe commented Sep 4, 2024 •

edited

Loading

NiLuJe commented Sep 6, 2024 •

edited

Loading

NiLuJe commented Sep 6, 2024 •

edited

Loading

NiLuJe commented Sep 7, 2024 •

edited

Loading