dapr install upgrade #3055
Merged
dapr install upgrade #3055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauron99, lkingland The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/override "Func Integration Test / Integration Test (ubuntu-latest)" |
|
@matejvasek: matejvasek unauthorized: /override is restricted to Repo administrators, and the following github teams:knative: knative-release-leads client-wg-leads eventing-wg-leads functions-wg-leads productivity-wg-leads serving-wg-leads. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Contributor
|
Just override the test @lkingland . Or you could try diff --git a/pkg/pipelines/tekton/gitlab_int_test.go b/pkg/pipelines/tekton/gitlab_int_test.go
index 2f6bd4776..cf321e59d 100644
--- a/pkg/pipelines/tekton/gitlab_int_test.go
+++ b/pkg/pipelines/tekton/gitlab_int_test.go
@@ -503,7 +503,7 @@ func getAPIToken(baseURL, username, password string) (string, error) {
}
data := struct {
- NewToken string `json:"new_token,omitempty"`
+ NewToken string `json:"token,omitempty"`
}{}
e := json.NewDecoder(resp.Body)
err = e.Decode(&data) |
Signed-off-by: David Fridrich <fridrich.david19@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3055 +/- ##
==========================================
+ Coverage 58.60% 59.33% +0.73%
==========================================
Files 133 133
Lines 17094 17094
==========================================
+ Hits 10018 10143 +125
+ Misses 6146 5992 -154
- Partials 930 959 +29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
/lgtm |
matejvasek
added a commit
to openshift-knative/kn-plugin-func
that referenced
this pull request
Oct 5, 2025
picking knative#3055 Co-authored-by: David Fridrich <fridrich.david19@gmail.com> Co-authored-by: Luke Kingland <lkinglan@redhat.com> Signed-off-by: Matej Vašek <mvasek@redhat.com>
matejvasek
added a commit
to openshift-knative/kn-plugin-func
that referenced
this pull request
Oct 6, 2025
* feat: remote storage class picking knative#2693 Co-authored-by: Luke Kingland <lkinglan@redhat.com> Signed-off-by: Matej Vašek <mvasek@redhat.com> * Python Middleware v2 Scaffolding picking knative#2685 Co-authored-by: Luke Kingland <lkinglan@redhat.com> Signed-off-by: Matej Vašek <mvasek@redhat.com> * Fix Python S2I On-Cluster build picking knative#2770 Signed-off-by: Matej Vašek <mvasek@redhat.com> * Fix http port 433 => 443 picking knative#2742 Signed-off-by: Matej Vašek <mvasek@redhat.com> * Trust loopback builders picking knative#2750 Signed-off-by: Matej Vašek <mvasek@redhat.com> * Add testcase for Go private repositories picking knative#2748 Signed-off-by: Matej Vašek <mvasek@redhat.com> * Test adjustments picking knative#2751 Signed-off-by: Matej Vašek <mvasek@redhat.com> * Allow host mounts for build phahse picking knative#2753 Signed-off-by: Matej Vašek <mvasek@redhat.com> * Use s2i in standard mode, not "as-dockerfile" picking knative#2764 Signed-off-by: Matej Vašek <mvasek@redhat.com> * Improvements for Go s2i assembler picking knative#2765 Signed-off-by: Matej Vašek <mvasek@redhat.com> * S2I (source-to-image) host binds picking knative#2766 Signed-off-by: Matej Vašek <mvasek@redhat.com> * Make build binds more similar to runtime binds picking knative#2768 Signed-off-by: Matej Vašek <mvasek@redhat.com> * Add guideline for private Go module usage picking knative#2771 Signed-off-by: Matej Vašek <mvasek@redhat.com> * Improve Go templates README picking knative#2848 Signed-off-by: Matej Vašek <mvasek@redhat.com> * Fix detection of hostname resolution failure picking knative#2841 Signed-off-by: Matej Vašek <mvasek@redhat.com> * Fix: Go scaffolding uses correct module name picking knative#2769 Signed-off-by: Matej Vašek <mvasek@redhat.com> * Fix non-containerized build/run /w external deps picking knative#2847 Signed-off-by: Matej Vašek <mvasek@redhat.com> * Tekton 1.0.x fixes picking #1349 Signed-off-by: Matej Vašek <mvasek@redhat.com> * Fix co-scheduling picking #1358 Co-authored-by: Jefferson Ramos <jeramos@redhat.com> Signed-off-by: Matej Vašek <mvasek@redhat.com> * test: fix gitlab test Signed-off-by: Matej Vašek <mvasek@redhat.com> * dapr install upgrade picking knative#3055 Co-authored-by: David Fridrich <fridrich.david19@gmail.com> Co-authored-by: Luke Kingland <lkinglan@redhat.com> Signed-off-by: Matej Vašek <mvasek@redhat.com> * fixup: go.mod Signed-off-by: Matej Vašek <mvasek@redhat.com> * fixup: update alpine version Signed-off-by: Matej Vašek <mvasek@redhat.com> * Migrate golangci-lint config to v2 picking knative#2781 Signed-off-by: Matej Vašek <mvasek@redhat.com> * Bump golangci-lint version picking knative#2784 Signed-off-by: Matej Vašek <mvasek@redhat.com> * fix flaky unit test picking knative#2749 Signed-off-by: David Fridrich <fridrich.david19@gmail.com> Signed-off-by: Matej Vašek <mvasek@redhat.com> --------- Signed-off-by: Matej Vašek <mvasek@redhat.com> Signed-off-by: David Fridrich <fridrich.david19@gmail.com> Co-authored-by: Luke Kingland <lkinglan@redhat.com> Co-authored-by: Jefferson Ramos <jeramos@redhat.com> Co-authored-by: David Fridrich <fridrich.david19@gmail.com>
matejvasek
added a commit
to matejvasek/faas
that referenced
this pull request
Oct 14, 2025
picking knative#3055 Signed-off-by: David Fridrich <fridrich.david19@gmail.com> Co-authored-by: David Fridrich <fridrich.david19@gmail.com> Signed-off-by: Matej Vašek <mvasek@redhat.com>
Merged
knative-prow bot
pushed a commit
that referenced
this pull request
Oct 14, 2025
* Fix backward compat Python pack build picking #2962 Signed-off-by: Matej Vašek <mvasek@redhat.com> * fix: Python host builder base image version picking #2965 Signed-off-by: Matej Vašek <mvasek@redhat.com> * Remove container flag - variant I picking #2987 Signed-off-by: Matej Vašek <mvasek@redhat.com> * fix python injector bug picking #2992 Signed-off-by: Matej Vašek <mvasek@redhat.com> * fix-of-a-fix picking #2994 Signed-off-by: Matej Vašek <mvasek@redhat.com> * fix: python scaffolding picking #3080 Signed-off-by: Matej Vašek <mvasek@redhat.com> * fix: use python3 when python not presetn picking #3082 Signed-off-by: Matej Vašek <mvasek@redhat.com> * dapr install upgrade picking #3055 Signed-off-by: David Fridrich <fridrich.david19@gmail.com> Co-authored-by: David Fridrich <fridrich.david19@gmail.com> Signed-off-by: Matej Vašek <mvasek@redhat.com> * test: skip ipv6 test correctly picking #3076 Signed-off-by: Matej Vašek <mvasek@redhat.com> --------- Signed-off-by: Matej Vašek <mvasek@redhat.com> Signed-off-by: David Fridrich <fridrich.david19@gmail.com> Co-authored-by: David Fridrich <fridrich.david19@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some problems with the dapr installation which was causing knative services to never become ready due to their Dapr sidecars' hangups