Skip to content

Conversation

matejvasek and others added 20 commits October 3, 2025 17:54
picking knative#2693

Co-authored-by: Luke Kingland <lkinglan@redhat.com>
Signed-off-by: Matej Vašek <mvasek@redhat.com>
picking knative#2685

Co-authored-by: Luke Kingland <lkinglan@redhat.com>
Signed-off-by: Matej Vašek <mvasek@redhat.com>
picking knative#2770

Signed-off-by: Matej Vašek <mvasek@redhat.com>
picking knative#2742

Signed-off-by: Matej Vašek <mvasek@redhat.com>
picking knative#2750

Signed-off-by: Matej Vašek <mvasek@redhat.com>
picking knative#2748

Signed-off-by: Matej Vašek <mvasek@redhat.com>
picking knative#2751

Signed-off-by: Matej Vašek <mvasek@redhat.com>
picking knative#2753

Signed-off-by: Matej Vašek <mvasek@redhat.com>
picking knative#2764

Signed-off-by: Matej Vašek <mvasek@redhat.com>
picking knative#2765

Signed-off-by: Matej Vašek <mvasek@redhat.com>
picking knative#2766

Signed-off-by: Matej Vašek <mvasek@redhat.com>
picking knative#2768

Signed-off-by: Matej Vašek <mvasek@redhat.com>
picking knative#2771

Signed-off-by: Matej Vašek <mvasek@redhat.com>
picking knative#2848

Signed-off-by: Matej Vašek <mvasek@redhat.com>
picking knative#2841

Signed-off-by: Matej Vašek <mvasek@redhat.com>
picking knative#2769

Signed-off-by: Matej Vašek <mvasek@redhat.com>
picking knative#2847

Signed-off-by: Matej Vašek <mvasek@redhat.com>
picking #1349

Signed-off-by: Matej Vašek <mvasek@redhat.com>
picking #1358

Co-authored-by: Jefferson Ramos <jeramos@redhat.com>
Signed-off-by: Matej Vašek <mvasek@redhat.com>
Signed-off-by: Matej Vašek <mvasek@redhat.com>
@matejvasek
Copy link
Collaborator Author

@jrangelramos would you please run some tests on this?

matejvasek and others added 4 commits October 5, 2025 16:05
picking knative#3055

Co-authored-by: David Fridrich <fridrich.david19@gmail.com>
Co-authored-by: Luke Kingland <lkinglan@redhat.com>
Signed-off-by: Matej Vašek <mvasek@redhat.com>
Signed-off-by: Matej Vašek <mvasek@redhat.com>
Signed-off-by: Matej Vašek <mvasek@redhat.com>
picking knative#2781

Signed-off-by: Matej Vašek <mvasek@redhat.com>
picking knative#2784

Signed-off-by: Matej Vašek <mvasek@redhat.com>
@matejvasek
Copy link
Collaborator Author

ptal @gauron99 @lkingland @dsimansk

picking knative#2749

Signed-off-by: David Fridrich <fridrich.david19@gmail.com>
Signed-off-by: Matej Vašek <mvasek@redhat.com>
@gauron99
Copy link

gauron99 commented Oct 6, 2025

/lgtm
/approve

/hold for other reviews if necessary

@openshift-ci
Copy link

openshift-ci bot commented Oct 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [gauron99,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matejvasek
Copy link
Collaborator Author

/override "Code Style / style / Golang / Lint"

@openshift-ci
Copy link

openshift-ci bot commented Oct 6, 2025

@matejvasek: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • Code Style / style / Golang / Lint

Only the following failed contexts/checkruns were expected:

  • Integration Test (ubuntu-latest)
  • ci/prow/419-e2e-oncluster-test
  • ci/prow/419-images
  • ci/prow/419-unit
  • pull-ci-openshift-knative-kn-plugin-func-release-next-419-e2e-oncluster-test
  • pull-ci-openshift-knative-kn-plugin-func-release-next-419-images
  • pull-ci-openshift-knative-kn-plugin-func-release-next-419-unit
  • style / Golang / Lint
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override "Code Style / style / Golang / Lint"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@matejvasek
Copy link
Collaborator Author

/override "Func Integration Test / Integration Test (ubuntu-latest)"

@openshift-ci
Copy link

openshift-ci bot commented Oct 6, 2025

@matejvasek: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • Func Integration Test / Integration Test (ubuntu-latest)

Only the following failed contexts/checkruns were expected:

  • Integration Test (ubuntu-latest)
  • ci/prow/419-e2e-oncluster-test
  • ci/prow/419-images
  • ci/prow/419-unit
  • pull-ci-openshift-knative-kn-plugin-func-release-next-419-e2e-oncluster-test
  • pull-ci-openshift-knative-kn-plugin-func-release-next-419-images
  • pull-ci-openshift-knative-kn-plugin-func-release-next-419-unit
  • style / Golang / Lint
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override "Func Integration Test / Integration Test (ubuntu-latest)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@matejvasek
Copy link
Collaborator Author

/override "style / Golang / Lint"
/override "Integration Test (ubuntu-latest)"

@openshift-ci
Copy link

openshift-ci bot commented Oct 6, 2025

@matejvasek: Overrode contexts on behalf of matejvasek: Integration Test (ubuntu-latest), style / Golang / Lint

Details

In response to this:

/override "style / Golang / Lint"
/override "Integration Test (ubuntu-latest)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@matejvasek matejvasek merged commit 18b1464 into release-v1.17 Oct 6, 2025
46 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants